* [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API
@ 2021-09-15 15:16 Bernard Iremonger
2021-09-22 14:47 ` Kevin Traynor
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bernard Iremonger @ 2021-09-15 15:16 UTC (permalink / raw)
To: ray.kinsella, dev; +Cc: Bernard Iremonger
This API was introduced in 17.11, removing experimental tag
to promote to stable state.
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
lib/flow_classify/rte_flow_classify.h | 7 -------
lib/flow_classify/version.map | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h
index 82ea92b6a6..3759cd32af 100644
--- a/lib/flow_classify/rte_flow_classify.h
+++ b/lib/flow_classify/rte_flow_classify.h
@@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
* @return
* Handle to flow classifier instance on success or NULL otherwise
*/
-__rte_experimental
struct rte_flow_classifier *
rte_flow_classifier_create(struct rte_flow_classifier_params *params);
@@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classifier_free(struct rte_flow_classifier *cls);
@@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_table_create(struct rte_flow_classifier *cls,
struct rte_flow_classify_table_params *params);
@@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_validate(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
* @return
* A valid handle in case of success, NULL otherwise.
*/
-__rte_experimental
struct rte_flow_classify_rule *
rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
struct rte_flow_classify_rule *rule);
@@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classifier_query(struct rte_flow_classifier *cls,
struct rte_mbuf **pkts,
diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map
index 49bc25c6a0..b7a888053b 100644
--- a/lib/flow_classify/version.map
+++ b/lib/flow_classify/version.map
@@ -1,4 +1,4 @@
-EXPERIMENTAL {
+DPDK_22 {
global:
rte_flow_classifier_create;
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API
2021-09-15 15:16 [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API Bernard Iremonger
@ 2021-09-22 14:47 ` Kevin Traynor
2021-09-22 16:12 ` Iremonger, Bernard
2021-09-22 16:48 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2023-06-30 21:56 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2 siblings, 1 reply; 6+ messages in thread
From: Kevin Traynor @ 2021-09-22 14:47 UTC (permalink / raw)
To: Bernard Iremonger, ray.kinsella, dev
s/eperimental/experimental/
On 15/09/2021 16:16, Bernard Iremonger wrote:
> This API was introduced in 17.11, removing experimental tag
> to promote to stable state.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> lib/flow_classify/rte_flow_classify.h | 7 -------
> lib/flow_classify/version.map | 2 +-
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
The library is still listed as experimental
https://git.dpdk.org/dpdk/tree/lib/flow_classify/rte_flow_classify.h#n13
and you can remove the allow_experimental_apis from the example app now.
> diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h
> index 82ea92b6a6..3759cd32af 100644
> --- a/lib/flow_classify/rte_flow_classify.h
> +++ b/lib/flow_classify/rte_flow_classify.h
> @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> * @return
> * Handle to flow classifier instance on success or NULL otherwise
> */
> -__rte_experimental
> struct rte_flow_classifier *
> rte_flow_classifier_create(struct rte_flow_classifier_params *params);
>
> @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classifier_free(struct rte_flow_classifier *cls);
>
> @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> struct rte_flow_classify_table_params *params);
> @@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_validate(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
> * @return
> * A valid handle in case of success, NULL otherwise.
> */
> -__rte_experimental
> struct rte_flow_classify_rule *
> rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> struct rte_flow_classify_rule *rule);
> @@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classifier_query(struct rte_flow_classifier *cls,
> struct rte_mbuf **pkts,
> diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map
> index 49bc25c6a0..b7a888053b 100644
> --- a/lib/flow_classify/version.map
> +++ b/lib/flow_classify/version.map
> @@ -1,4 +1,4 @@
> -EXPERIMENTAL {
> +DPDK_22 {
> global:
>
> rte_flow_classifier_create;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API
2021-09-22 14:47 ` Kevin Traynor
@ 2021-09-22 16:12 ` Iremonger, Bernard
0 siblings, 0 replies; 6+ messages in thread
From: Iremonger, Bernard @ 2021-09-22 16:12 UTC (permalink / raw)
To: Kevin Traynor, Kinsella, Ray, dev
Hi Kevin,
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, September 22, 2021 3:48 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Kinsella, Ray
> <ray.kinsella@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from
> the API
>
> s/eperimental/experimental/
>
> On 15/09/2021 16:16, Bernard Iremonger wrote:
> > This API was introduced in 17.11, removing experimental tag to promote
> > to stable state.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > lib/flow_classify/rte_flow_classify.h | 7 -------
> > lib/flow_classify/version.map | 2 +-
> > 2 files changed, 1 insertion(+), 8 deletions(-)
> >
>
> The library is still listed as experimental
> https://git.dpdk.org/dpdk/tree/lib/flow_classify/rte_flow_classify.h#n13
>
> and you can remove the allow_experimental_apis from the example app
> now.
Good catch.
I will remove allow_experimental_apis from the flow_classify/meson.build file.
> > diff --git a/lib/flow_classify/rte_flow_classify.h
> > b/lib/flow_classify/rte_flow_classify.h
> > index 82ea92b6a6..3759cd32af 100644
> > --- a/lib/flow_classify/rte_flow_classify.h
> > +++ b/lib/flow_classify/rte_flow_classify.h
> > @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> > * @return
> > * Handle to flow classifier instance on success or NULL otherwise
> > */
> > -__rte_experimental
> > struct rte_flow_classifier *
> > rte_flow_classifier_create(struct rte_flow_classifier_params
> > *params);
> >
> > @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct
> rte_flow_classifier_params *params);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_free(struct rte_flow_classifier *cls);
> >
> > @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier
> *cls);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_table_params *params); @@ -205,7
> +202,6
> > @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_validate(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier
> *cls,
> > * @return
> > * A valid handle in case of success, NULL otherwise.
> > */
> > -__rte_experimental
> > struct rte_flow_classify_rule *
> > rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct
> rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_rule *rule); @@ -273,7 +267,6 @@
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_query(struct rte_flow_classifier *cls,
> > struct rte_mbuf **pkts,
> > diff --git a/lib/flow_classify/version.map
> > b/lib/flow_classify/version.map index 49bc25c6a0..b7a888053b 100644
> > --- a/lib/flow_classify/version.map
> > +++ b/lib/flow_classify/version.map
> > @@ -1,4 +1,4 @@
> > -EXPERIMENTAL {
> > +DPDK_22 {
> > global:
> >
> > rte_flow_classifier_create;
> >
Regards,
Bernard.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] flow_classify: remove eperimental tag from the API
2021-09-15 15:16 [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API Bernard Iremonger
2021-09-22 14:47 ` Kevin Traynor
@ 2021-09-22 16:48 ` Bernard Iremonger
2021-09-23 10:09 ` Kevin Traynor
2023-06-30 21:56 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2 siblings, 1 reply; 6+ messages in thread
From: Bernard Iremonger @ 2021-09-22 16:48 UTC (permalink / raw)
To: ray.kinsella, ktraynor, dev; +Cc: Bernard Iremonger
This API was introduced in 17.11, removing experimental tag
to promote to stable state.
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
examples/flow_classify/meson.build | 2 +-
lib/flow_classify/rte_flow_classify.h | 7 -------
lib/flow_classify/version.map | 2 +-
3 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/examples/flow_classify/meson.build b/examples/flow_classify/meson.build
index 1be1bf0374..bffceb9465 100644
--- a/examples/flow_classify/meson.build
+++ b/examples/flow_classify/meson.build
@@ -7,7 +7,7 @@
# DPDK instance, use 'make'
deps += 'flow_classify'
-allow_experimental_apis = true
+
sources = files(
'flow_classify.c',
)
diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h
index 82ea92b6a6..3759cd32af 100644
--- a/lib/flow_classify/rte_flow_classify.h
+++ b/lib/flow_classify/rte_flow_classify.h
@@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
* @return
* Handle to flow classifier instance on success or NULL otherwise
*/
-__rte_experimental
struct rte_flow_classifier *
rte_flow_classifier_create(struct rte_flow_classifier_params *params);
@@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classifier_free(struct rte_flow_classifier *cls);
@@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_table_create(struct rte_flow_classifier *cls,
struct rte_flow_classify_table_params *params);
@@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_validate(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
* @return
* A valid handle in case of success, NULL otherwise.
*/
-__rte_experimental
struct rte_flow_classify_rule *
rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
struct rte_flow_classify_rule *rule);
@@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classifier_query(struct rte_flow_classifier *cls,
struct rte_mbuf **pkts,
diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map
index 49bc25c6a0..b7a888053b 100644
--- a/lib/flow_classify/version.map
+++ b/lib/flow_classify/version.map
@@ -1,4 +1,4 @@
-EXPERIMENTAL {
+DPDK_22 {
global:
rte_flow_classifier_create;
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] flow_classify: remove eperimental tag from the API
2021-09-22 16:48 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
@ 2021-09-23 10:09 ` Kevin Traynor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2021-09-23 10:09 UTC (permalink / raw)
To: Bernard Iremonger, ray.kinsella, dev
Hi Bernard,
On 22/09/2021 17:48, Bernard Iremonger wrote:
> This API was introduced in 17.11, removing experimental tag
> to promote to stable state.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> examples/flow_classify/meson.build | 2 +-
> lib/flow_classify/rte_flow_classify.h | 7 -------
> lib/flow_classify/version.map | 2 +-
> 3 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/examples/flow_classify/meson.build b/examples/flow_classify/meson.build
> index 1be1bf0374..bffceb9465 100644
> --- a/examples/flow_classify/meson.build
> +++ b/examples/flow_classify/meson.build
> @@ -7,7 +7,7 @@
> # DPDK instance, use 'make'
>
> deps += 'flow_classify'
> -allow_experimental_apis = true
> +
> sources = files(
> 'flow_classify.c',
> )
> diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h
> index 82ea92b6a6..3759cd32af 100644
> --- a/lib/flow_classify/rte_flow_classify.h
> +++ b/lib/flow_classify/rte_flow_classify.h
The library is still marked as experimental, but I don't think this is
valid anymore as it now contains stable APIs. So needs some removals:
Text below in rte_flow_classify.h,
* @warning
* @b EXPERIMENTAL:
* All functions in this file may be changed or removed without prior
notice.
Also in MAINTAINERS file,
Flow Classify - EXPERIMENTAL
and as it is lib moving into stable ABI, then probably something should
go in the release notes for this.
thanks,
Kevin.
> @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> * @return
> * Handle to flow classifier instance on success or NULL otherwise
> */
> -__rte_experimental
> struct rte_flow_classifier *
> rte_flow_classifier_create(struct rte_flow_classifier_params *params);
>
> @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classifier_free(struct rte_flow_classifier *cls);
>
> @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> struct rte_flow_classify_table_params *params);
> @@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_validate(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
> * @return
> * A valid handle in case of success, NULL otherwise.
> */
> -__rte_experimental
> struct rte_flow_classify_rule *
> rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> struct rte_flow_classify_rule *rule);
> @@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classifier_query(struct rte_flow_classifier *cls,
> struct rte_mbuf **pkts,
> diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map
> index 49bc25c6a0..b7a888053b 100644
> --- a/lib/flow_classify/version.map
> +++ b/lib/flow_classify/version.map
> @@ -1,4 +1,4 @@
> -EXPERIMENTAL {
> +DPDK_22 {
> global:
>
> rte_flow_classifier_create;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API
2021-09-15 15:16 [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API Bernard Iremonger
2021-09-22 14:47 ` Kevin Traynor
2021-09-22 16:48 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
@ 2023-06-30 21:56 ` Stephen Hemminger
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2023-06-30 21:56 UTC (permalink / raw)
To: Bernard Iremonger; +Cc: ray.kinsella, dev
On Wed, 15 Sep 2021 16:16:35 +0100
Bernard Iremonger <bernard.iremonger@intel.com> wrote:
> This API was introduced in 17.11, removing experimental tag
> to promote to stable state.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
The API is unmaintained and because of that likely to be deprecated in future.
Marking it as stable at this point would not be a good idea.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-30 21:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 15:16 [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API Bernard Iremonger
2021-09-22 14:47 ` Kevin Traynor
2021-09-22 16:12 ` Iremonger, Bernard
2021-09-22 16:48 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2021-09-23 10:09 ` Kevin Traynor
2023-06-30 21:56 ` [dpdk-dev] [PATCH] " Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).