From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEDA442DC6; Tue, 4 Jul 2023 01:19:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60E2340F18; Tue, 4 Jul 2023 01:19:14 +0200 (CEST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by mails.dpdk.org (Postfix) with ESMTP id BCB7540E03 for ; Tue, 4 Jul 2023 01:19:12 +0200 (CEST) Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6b5cf23b9fcso4316642a34.0 for ; Mon, 03 Jul 2023 16:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688426351; x=1691018351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=saFEnsXoY2HJHd5Wdvtc12/PuPn7x9P9QdqAb64mvMA=; b=4ISN2+UQTyfFE/MPPt1m8766/KLwIPGTM40rSxyiA21VOLD4mq0WTfajPF0jzJ8CNN /qR8/fWU8HofDAPwRkIHz89Th5NFLLVzPbnlfBs9H4tUx0DU1I/DZbrsxB6eXhPFxV+A BQrWMNE4g4HlHzOVjIqOSRvEjiXBgti2pk0io9YnfAlhVSUtxA+YJvO4q0lVxopErmHA AQB61QqP8KILMX0tT+9G0RMTxv2C9dt6Q+kUuwZ+mfro2IiOGC+bgzt0ii9CTrdAeIKX 35sR9MTlisSybOG5OJatYhRESoWet1Q955enPkm++Yjx0yWsi7uTVqMFxwA9BcO0vu+W yzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688426351; x=1691018351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=saFEnsXoY2HJHd5Wdvtc12/PuPn7x9P9QdqAb64mvMA=; b=kjATwoWuIHitS2FE+HzabFu5uU/5IP4tWHFdlwTJ2FYMTLWiKOzqsUzkwoRPDUCpIQ YUihz+CHLl5bk55lVx4EDgZ9Zwnrb+UPEZsQV7+AZGmZd2Es6+DjUj2vLP90X6fHcRmG 0MVGDCBFwz9zuQzYr/l8ZWlZR2jmSXtTam1R2h86iRUP0Yf57D/nuwXVr48A5DxrVwov x7VTA8yFzqqU/3copdaVgvd/FOP0gX+aRRn53H/EDj0+zuBLM9mtOzdKff14pS+g8Sy9 k/2o7cajt/sgMpQJhewePOmQdF4XGMWct3w77FzLB+hcY5BajX+GE7vAs3Vo0GCSmfqW 6fig== X-Gm-Message-State: ABy/qLYLtgYclttzEJ1ykMBuQfhYsojbYucxgtb+U9UNhR40FXDW/3IZ +RSgv/uYNPzzp89DZg0G8BGAfw== X-Google-Smtp-Source: APBJJlEsOrbB6fhF7WxUwMrKsiLTmN7u56BdXd2DKTxIxGeqAWZ1g2qbNWgoRaKl23ksRnwBIHy+sA== X-Received: by 2002:a05:6870:96a0:b0:19f:9495:95ff with SMTP id o32-20020a05687096a000b0019f949595ffmr13321744oaq.27.1688426351684; Mon, 03 Jul 2023 16:19:11 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ob11-20020a17090b390b00b00262dc783974sm14469803pjb.31.2023.07.03.16.19.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 16:19:11 -0700 (PDT) Date: Mon, 3 Jul 2023 16:19:09 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , Subject: Re: [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration Message-ID: <20230703161909.23a7da1d@hermes.local> In-Reply-To: <1619599379-470-1-git-send-email-humin29@huawei.com> References: <1619599379-470-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 28 Apr 2021 16:42:59 +0800 "Min Hu (Connor)" wrote: > From: Huisong Li > > Currently, the pause command in ethtool to enable Rx/Tx pause has the > following problem. Namely, Assume that the device supports flow control > auto-negotiation to set pause parameters, which will the device that does > not support flow control auto-negotiation fails to run this command. > > This patch supports the configuration of flow control auto-negotiation > and fixes the print format and style of the pause cmd to make it more > readable. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) Overall, this looks good. DPDK is mainly used in devices 1G and above where I think that auto negotiation is required by IEEE spec. Acked-by: Stephen Hemminger