From: Stephen Hemminger <stephen@networkplumber.org>
To: Sowmini Varadhan <sovaradh@linux.microsoft.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"sowmini05@gmail.com" <sowmini05@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp
Date: Mon, 3 Jul 2023 16:38:18 -0700 [thread overview]
Message-ID: <20230703163818.05bf35f3@hermes.local> (raw)
In-Reply-To: <20210819193446.GA11221@microsoft.com>
On Thu, 19 Aug 2021 12:34:46 -0700
Sowmini Varadhan <sovaradh@linux.microsoft.com> wrote:
> On (08/19/21 16:21), Iremonger, Bernard wrote:
> >
> > Looking closer at this patchset, I am not sure that a second ACL table is needed.
> > The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags.
> > I think it just needs to be modified to process the TCP flags.
> > Could you take another look to see if the above proposed solution will work for you.
>
> I'm not sure it would. As I pointed out in the original rfc at
> https://inbox.dpdk.org/dev/cover.1578936382.git.sowmini.varadhan@microsoft.com/
>
> we need to add a key for the 8 bit flags, but the multibit
> trie lookup moves in steps of 4 bytes.
>
> However, it has admittedly been a while since I tinkereed with this,
> and I can give it a shot and get back.
>
> Thanks
> --Sowmini
>
Doing a cleanup of patch backlog prior to next LTS release.
The patch never got updated based on comments.
Please resubmit if you still want to pursue it.
prev parent reply other threads:[~2023-07-03 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:01 [dpdk-dev] [PATCH v2 0/2] TCP flow classification using 4-tuple and flags Sowmini Varadhan
2021-08-18 15:01 ` [dpdk-dev] [PATCH v2 1/2] examples/flow_classify: hooks for filters on tcp flags Sowmini Varadhan
2021-08-19 16:08 ` Iremonger, Bernard
2021-08-18 15:01 ` [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp Sowmini Varadhan
2021-08-19 15:06 ` Iremonger, Bernard
2021-08-19 15:20 ` Sowmini Varadhan
2021-08-19 16:21 ` Iremonger, Bernard
2021-08-19 19:34 ` Sowmini Varadhan
2023-07-03 23:38 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703163818.05bf35f3@hermes.local \
--to=stephen@networkplumber.org \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=sovaradh@linux.microsoft.com \
--cc=sowmini05@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).