From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 948FD42DC8; Tue, 4 Jul 2023 01:38:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22C6340F18; Tue, 4 Jul 2023 01:38:23 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id B415440E03 for ; Tue, 4 Jul 2023 01:38:21 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b80b3431d2so24918385ad.1 for ; Mon, 03 Jul 2023 16:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688427501; x=1691019501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AQ2biY06V1didvq1dRAxkOZXbzRB9uLcxqc9BrGRX/4=; b=K+jw98gJizd/Jwc8VuVeWeV1fKwHtKYh8L/JLAHj4UyzYRHBpLZKfIkcGm+kRALmok 6mu9hwNHdvDOpVUDrX7BfKufHyA9CkWXMAh6NP9lwfJQn6kbmXksJkzjy0iho5JPkwo9 DW5T41+/FdBcc3EbEDjMtPTZDKh4kBJPIi6W60+CmynNSK7b2gQPFvposYljDJHT9XsO c6cZfHg7oo/FupEOVlhzPynSm6XPgIuGyNQAjXuq8FpOomEJFsvVIFzJvWuMEsTKGZz0 ISFWX9uVohxzv42P8hf4Xg/AO5oZVPYf87QTtOJx9sBvdkJwvzEzUF0AN7qXdoZ7Txnb JWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688427501; x=1691019501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AQ2biY06V1didvq1dRAxkOZXbzRB9uLcxqc9BrGRX/4=; b=aP+AROJ56dpcHJsf61JYU9Mxil6IdhX/HiOusYTkB4a/7QX3ZU5TGjbkba9PKAlHj6 nAYl/RDnguT2s+74moONAlzcQNDx1PGTBiWet/yY34hMFcMWCAsQgmH8ygNhIeKIKCWM 5hmtjMiNjNws2eLVoKkQm9uKDIpEf60mZrdzmsePAnqw4oPu5thg/pAFe1niP4utEZjW AUDkS36n+8a1rRW4bm3efjbiTNcIH1NApmLkk21RWofTuVJbxCWmNGChi0u6lGnuolSY 6MQOpMEkodW5mVFiIWImMW2LzrYqUeq7/K+7JGQcnRLDtmNKx6p0arsDZLyltGIxkvRf 1Kuw== X-Gm-Message-State: AC+VfDwJy/4YznHIAVE5IjOPMPo9GYpaa//ct6ByKEMAWjQ3V4ksqdJM MTtT6rM3QAke5ZAtGyNy4HnYhg== X-Google-Smtp-Source: ACHHUZ5bZKz7gZNtXYbJhldrPp6mSAwa4rxpOFvUzaz4AfCMzsYyjXdrpGvq1uulLqv6sFmb3Xm94A== X-Received: by 2002:a05:6a21:9997:b0:11e:e940:441e with SMTP id ve23-20020a056a21999700b0011ee940441emr12519051pzb.25.1688427500834; Mon, 03 Jul 2023 16:38:20 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id u8-20020a170903124800b001b03cda6389sm15814922plh.10.2023.07.03.16.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 16:38:20 -0700 (PDT) Date: Mon, 3 Jul 2023 16:38:18 -0700 From: Stephen Hemminger To: Sowmini Varadhan Cc: "Iremonger, Bernard" , "sowmini05@gmail.com" , "dev@dpdk.org" , "thomas@monjalon.net" Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp Message-ID: <20230703163818.05bf35f3@hermes.local> In-Reply-To: <20210819193446.GA11221@microsoft.com> References: <9085a3881fabec43eeeb5b3227c569cf559648a2.1629287046.git.sovaradh@linux.microsoft.com> <20210819152009.GA24347@microsoft.com> <20210819193446.GA11221@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 Aug 2021 12:34:46 -0700 Sowmini Varadhan wrote: > On (08/19/21 16:21), Iremonger, Bernard wrote: > > > > Looking closer at this patchset, I am not sure that a second ACL table is needed. > > The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags. > > I think it just needs to be modified to process the TCP flags. > > Could you take another look to see if the above proposed solution will work for you. > > I'm not sure it would. As I pointed out in the original rfc at > https://inbox.dpdk.org/dev/cover.1578936382.git.sowmini.varadhan@microsoft.com/ > > we need to add a key for the 8 bit flags, but the multibit > trie lookup moves in steps of 4 bytes. > > However, it has admittedly been a while since I tinkereed with this, > and I can give it a shot and get back. > > Thanks > --Sowmini > Doing a cleanup of patch backlog prior to next LTS release. The patch never got updated based on comments. Please resubmit if you still want to pursue it.