From: Stephen Hemminger <stephen@networkplumber.org>
To: Harman Kalra <hkalra@marvell.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] interrupts: fix error log level
Date: Thu, 6 Jul 2023 11:52:34 -0700 [thread overview]
Message-ID: <20230706115234.1c7a7340@hermes.local> (raw)
In-Reply-To: <20211101174447.82017-1-hkalra@marvell.com>
On Mon, 1 Nov 2021 23:14:47 +0530
Harman Kalra <hkalra@marvell.com> wrote:
> Fixing the error logs level, as currently default level is
> set to debug. Due to this failure is not getting captured.
>
> Fixes: b7c984291611 ("interrupts: add allocator and accessors")
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> lib/eal/common/eal_common_interrupts.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c
> index 97b64fed58..96c7e9e40e 100644
> --- a/lib/eal/common/eal_common_interrupts.c
> +++ b/lib/eal/common/eal_common_interrupts.c
> @@ -15,7 +15,7 @@
> /* Macros to check for valid interrupt handle */
> #define CHECK_VALID_INTR_HANDLE(intr_handle) do { \
> if (intr_handle == NULL) { \
> - RTE_LOG(DEBUG, EAL, "Interrupt instance unallocated\n"); \
> + RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n"); \
> rte_errno = EINVAL; \
> goto fail; \
> } \
> @@ -37,7 +37,7 @@ struct rte_intr_handle *rte_intr_instance_alloc(uint32_t flags)
> * defined flags.
> */
> if ((flags & ~RTE_INTR_INSTANCE_KNOWN_FLAGS) != 0) {
> - RTE_LOG(DEBUG, EAL, "Invalid alloc flag passed 0x%x\n", flags);
> + RTE_LOG(ERR, EAL, "Invalid alloc flag passed 0x%x\n", flags);
> rte_errno = EINVAL;
> return NULL;
> }
> @@ -100,7 +100,7 @@ struct rte_intr_handle *rte_intr_instance_dup(const struct rte_intr_handle *src)
> struct rte_intr_handle *intr_handle;
>
> if (src == NULL) {
> - RTE_LOG(DEBUG, EAL, "Source interrupt instance unallocated\n");
> + RTE_LOG(ERR, EAL, "Source interrupt instance unallocated\n");
> rte_errno = EINVAL;
> return NULL;
> }
> @@ -129,7 +129,7 @@ int rte_intr_event_list_update(struct rte_intr_handle *intr_handle, int size)
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (size == 0) {
> - RTE_LOG(DEBUG, EAL, "Size can't be zero\n");
> + RTE_LOG(ERR, EAL, "Size can't be zero\n");
> rte_errno = EINVAL;
> goto fail;
> }
> @@ -253,7 +253,7 @@ int rte_intr_max_intr_set(struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (max_intr > intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Maximum interrupt vector ID (%d) exceeds "
> + RTE_LOG(ERR, EAL, "Maximum interrupt vector ID (%d) exceeds "
> "the number of available events (%d)\n", max_intr,
> intr_handle->nb_intr);
> rte_errno = ERANGE;
> @@ -332,7 +332,7 @@ int rte_intr_efds_index_get(const struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Invalid index %d, max limit %d\n", index,
> + RTE_LOG(ERR, EAL, "Invalid index %d, max limit %d\n", index,
> intr_handle->nb_intr);
> rte_errno = EINVAL;
> goto fail;
> @@ -349,7 +349,7 @@ int rte_intr_efds_index_set(struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Invalid index %d, max limit %d\n", index,
> + RTE_LOG(ERR, EAL, "Invalid index %d, max limit %d\n", index,
> intr_handle->nb_intr);
> rte_errno = ERANGE;
> goto fail;
> @@ -368,7 +368,7 @@ struct rte_epoll_event *rte_intr_elist_index_get(
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Invalid index %d, max limit %d\n", index,
> + RTE_LOG(ERR, EAL, "Invalid index %d, max limit %d\n", index,
> intr_handle->nb_intr);
> rte_errno = ERANGE;
> goto fail;
> @@ -385,7 +385,7 @@ int rte_intr_elist_index_set(struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Invalid index %d, max limit %d\n", index,
> + RTE_LOG(ERR, EAL, "Invalid index %d, max limit %d\n", index,
> intr_handle->nb_intr);
> rte_errno = ERANGE;
> goto fail;
> @@ -408,7 +408,7 @@ int rte_intr_vec_list_alloc(struct rte_intr_handle *intr_handle,
> return 0;
>
> if (size > intr_handle->nb_intr) {
> - RTE_LOG(DEBUG, EAL, "Invalid size %d, max limit %d\n", size,
> + RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", size,
> intr_handle->nb_intr);
> rte_errno = ERANGE;
> goto fail;
> @@ -437,7 +437,7 @@ int rte_intr_vec_list_index_get(const struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->vec_list_size) {
> - RTE_LOG(DEBUG, EAL, "Index %d greater than vec list size %d\n",
> + RTE_LOG(ERR, EAL, "Index %d greater than vec list size %d\n",
> index, intr_handle->vec_list_size);
> rte_errno = ERANGE;
> goto fail;
> @@ -454,7 +454,7 @@ int rte_intr_vec_list_index_set(struct rte_intr_handle *intr_handle,
> CHECK_VALID_INTR_HANDLE(intr_handle);
>
> if (index >= intr_handle->vec_list_size) {
> - RTE_LOG(DEBUG, EAL, "Index %d greater than vec list size %d\n",
> + RTE_LOG(ERR, EAL, "Index %d greater than vec list size %d\n",
> index, intr_handle->vec_list_size);
> rte_errno = ERANGE;
> goto fail;
Looks good. It would be better to use %u for nb_intr and vec_list_size since
they are u16 values. But that is a pre-existing bug.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-07-06 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:44 Harman Kalra
2023-07-06 18:52 ` Stephen Hemminger [this message]
2024-03-18 22:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706115234.1c7a7340@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).