From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <dmiller423@gmail.com>
Cc: dev@dpdk.org, Mathew S Thoennes <tardis@us.ibm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Beilei Xing <beilei.xing@intel.com>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH] Add support for IBM Z s390x
Date: Thu, 6 Jul 2023 15:47:23 -0700 [thread overview]
Message-ID: <20230706154723.2f921b28@hermes.local> (raw)
In-Reply-To: <20221028215240.103365-1-dmiller423@gmail.com>
On Fri, 28 Oct 2022 17:52:40 -0400
David Miller <dmiller423@gmail.com> wrote:
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index cc8e7aa138..2a863f3d39 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -245,9 +245,9 @@ nic_stats_display(portid_t port_id)
> static uint64_t prev_bytes_tx[RTE_MAX_ETHPORTS];
> static uint64_t prev_ns[RTE_MAX_ETHPORTS];
> struct timespec cur_time;
> - uint64_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,
> - diff_ns;
> - uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;
> + __uint128_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,
> + diff_ns;
> + __uint128_t mpps_rx, mpps_tx, mbps_rx, mbps_tx
Not all platforms DPDK supports are likely to handle 128 bit numbers.
And unsigned long long is not 128 bit on many platforms.
Better to leave this part alone.
next prev parent reply other threads:[~2023-07-06 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 21:52 David Miller
2022-10-28 22:45 ` Stephen Hemminger
2022-10-28 22:54 ` David Miller
2022-10-28 22:51 ` Stephen Hemminger
2023-07-06 22:47 ` Stephen Hemminger [this message]
2023-07-06 22:49 ` Stephen Hemminger
2023-07-07 0:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706154723.2f921b28@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmiller423@gmail.com \
--cc=dmitry.kozliuk@gmail.com \
--cc=haiyue.wang@intel.com \
--cc=hkalra@marvell.com \
--cc=jgrajcia@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@nvidia.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=sameh.gobriel@intel.com \
--cc=tardis@us.ibm.com \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yipeng1.wang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).