Re: [PATCH v17] app/procinfo: display eventdev xstats

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 07 Jul 2023 11:15:22 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 25/05/2023 22:07, Stephen Hemminger:
> > On Thu, 25 May 2023 13:47:31 -0500
> > Abdullah Sevincer <abdullah.sevincer@intel.com> wrote:
> >   
> > > This commit extends proc-info application to
> > > display xstats for the eventdev devices.
> > > 
> > > New command line arguments are introduced to
> > > display xstats for eventdev devices. The command
> > > example is like:
> > > 
> > > For displaying a specific port stats (e.g. port 1):
> > > ./dpdk-proc-info -- --show-edev-port-xstats=1:0
> > > 
> > > If any xstats parameters for eventdev passed through
> > > proc-info command line, proc-info will only display
> > > requested eventdev data and exit.
> > > 
> > > Users should not pass any eventdev xstats parameters
> > > if they desire to dump other proc-info data such as
> > > Rx/Tx descriptor dump.
> > > More information can be found in proc-info app doc.
> > > 
> > > Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>  
> > 
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>  
> 
> Applied, thanks.

Has new coverity issue.
The reason is the boolean is set every time because it gets every time.

Looks like code goes over eventdev_var[] even if no eventdevs are present.
Should only look for the number of eventdevs

*** CID 395458:  Control flow issues  (DEADCODE)
/app/proc-info/main.c: 2114 in process_eventdev_xstats()
2108     		}
2109     	}
2110     
2111     	if (processing_eventdev_xstats)
2112     		return 1;
2113     
>>>     CID 395458:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return 0;".  
2114     	return 0;
2115     }
2116     
2117     int
2118     main(int argc, char **argv)
2119     {