From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0381A42E4A; Tue, 11 Jul 2023 22:28:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1D2B40A7D; Tue, 11 Jul 2023 22:28:55 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 8D55B40A7D for ; Tue, 11 Jul 2023 22:28:54 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b89d47ffb6so31704495ad.2 for ; Tue, 11 Jul 2023 13:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689107333; x=1691699333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4aJSPNin4XuvpfjrTf9ziR+5TW/1K+mhUzzr5iF5UPw=; b=pi4bk/ij1CA/sqIQe8bdCecb6jIZTryI1aAiazjoHlEhXK3o+d1Vvsl+kMSVWx0D06 7m8zsYOgCCuHEOZ+bAjVsc2qYf+g1t6A6V6GX6r1LNBi+ow2Pjs5vZGEpHGEoultgL0i BZ78xNSNDetW0H5UgHaS/GM6LD0tUjq/viPxq8N/wyinA1N+vqMaDgVbQrKGgrVnH4Vv vAFAYfPC/KsGTsk2lr9P56HU7vo4IBMbiFwLuH6QKXQAk1EAhRuIwGeaSS6wtDtafFjF prMWuQ+1DOpMwHIjSw9jbhRYogIf4cpFmZMWtyAlpIc/6CR0IfFuwoZr8jCYt/m0hUaJ 53Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689107333; x=1691699333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4aJSPNin4XuvpfjrTf9ziR+5TW/1K+mhUzzr5iF5UPw=; b=WtRxoB2L5fFFCVoLnFXuNdQogQx38K+jCgUbhrik8CzzCmzwLNglFyw3mL45mCi7UT kp36JfkrKo+s39MejycCOnzwB7zmtPgzVC0RKJR6luXUznOXsJ0n/onS1J8Fh7u34TYz 3X/4TPY7DLTx2zlIIMjHWY3zdWm9FAzSxdwBMjow9+UUdCKYL4bjTLrFT/62SMaz7txQ uF+tORmGtisP3KdAWATY0qMBSedktxUmvb+uCfiIJGNzX848PahI/OA82f4kbJ0uCUSd LixVCvjNz3/W6DXL/+1oJTIFdLKUEGCI9Ed94PfaeioNBOI6tXoHAmOkiiDNhvyuJp6o WJzw== X-Gm-Message-State: ABy/qLYBDhRgxY4SRkp7eMRA8JMJHIMqE4JAqVhSu8NlCC7ORlUW1VCD 8KodibQQBaB9w4mVOCze0RQSjg== X-Google-Smtp-Source: APBJJlElqK6WdLZGXR7DvgyvBmrS6SYfBIC9EOFmDyX3syu6t/jz96qGg+Yp+CKChsKLS6S5jtcHzQ== X-Received: by 2002:a17:903:41d2:b0:1b8:ab0d:cd5 with SMTP id u18-20020a17090341d200b001b8ab0d0cd5mr17094654ple.49.1689107333612; Tue, 11 Jul 2023 13:28:53 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id t16-20020a170902e85000b001b9de39905asm2345332plg.59.2023.07.11.13.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 13:28:53 -0700 (PDT) Date: Tue, 11 Jul 2023 09:15:00 -0700 From: Stephen Hemminger To: Alexander Kozyrev Cc: , , , , Subject: Re: [PATCH 3/3] app/testpmd: fix meter mark handle update Message-ID: <20230711091500.4aa15bf7@hermes.local> In-Reply-To: <20230711152044.3141138-3-akozyrev@nvidia.com> References: <20230711152044.3141138-1-akozyrev@nvidia.com> <20230711152044.3141138-3-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 Jul 2023 18:20:44 +0300 Alexander Kozyrev wrote: > + case RTE_FLOW_ACTION_TYPE_METER_MARK: > + rte_memcpy(&mtr_update.meter_mark, action->conf, > + sizeof(struct rte_flow_action_meter_mark)); Why use rte_memcpy? memcpy of fixed size is faster. Also, more static checkers know what memcpy is.