* [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse
@ 2023-07-13 22:40 Ivan Malov
2023-07-14 5:38 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Malov @ 2023-07-13 22:40 UTC (permalink / raw)
To: dev; +Cc: Andrew Rybchenko, Ferruh Yigit, Artemii Morozov, stable
Such check is already done at an earlier point, in
sfc_flow_parse_pattern(), so remove it from IPv4
item parser. Doing so should fix Coverity issue.
Coverity issue: 395526
Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
---
drivers/net/sfc/sfc_mae.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index 63f6536243..60a54fd425 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -2331,7 +2331,7 @@ sfc_mae_rule_parse_item_ipv4(const struct rte_flow_item *item,
if (ctx_mae->match_spec != ctx_mae->match_spec_action)
supp_mask.hdr.fragment_offset = 0;
- if (item != NULL && item->last != NULL) {
+ if (item->last != NULL) {
last = item->last;
item_dup.last = NULL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse
2023-07-13 22:40 [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse Ivan Malov
@ 2023-07-14 5:38 ` Andrew Rybchenko
2023-07-17 13:17 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2023-07-14 5:38 UTC (permalink / raw)
To: Ivan Malov, dev; +Cc: Ferruh Yigit, Artemii Morozov, stable
On 7/14/23 01:40, Ivan Malov wrote:
> Such check is already done at an earlier point, in
> sfc_flow_parse_pattern(), so remove it from IPv4
> item parser. Doing so should fix Coverity issue.
>
> Coverity issue: 395526
> Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse
2023-07-14 5:38 ` Andrew Rybchenko
@ 2023-07-17 13:17 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-07-17 13:17 UTC (permalink / raw)
To: Andrew Rybchenko, Ivan Malov, dev; +Cc: Artemii Morozov, stable
On 7/14/2023 6:38 AM, Andrew Rybchenko wrote:
> On 7/14/23 01:40, Ivan Malov wrote:
>> Such check is already done at an earlier point, in
>> sfc_flow_parse_pattern(), so remove it from IPv4
>> item parser. Doing so should fix Coverity issue.
>>
>> Coverity issue: 395526
>> Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in
>> transfer rules")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-17 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 22:40 [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse Ivan Malov
2023-07-14 5:38 ` Andrew Rybchenko
2023-07-17 13:17 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).