From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B293F42E8E; Sun, 16 Jul 2023 19:34:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 419B44114A; Sun, 16 Jul 2023 19:34:49 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 9886F4113F for ; Sun, 16 Jul 2023 19:34:47 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b890e2b9b7so20539365ad.3 for ; Sun, 16 Jul 2023 10:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689528887; x=1692120887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=E+fKpcrLfqwSXaKttWPm9/nVZR1vPgyMlgU1qfCuwZk=; b=g/IL44RREQ3tKEzXGjd/EqRi9YI2aDdL4pgl8EALAQQmZ3BB198rdDpx4V4Qol+uSG xfVE3i8vkN658oIYamDXO+Qlst6XhYAEsITnttGokdLxzninLQBPPDPDAa/a65p31Bxn WIzKLn9Ftk/NGfACh+hIapDoncL0WtmGRsxbBJNuqUg7yXt3o6c9oQgGulDCUXTivaE0 aEloeH1JLIPIfS508O96WMQYHqLexT/gVobE732u1LFAIp6wCNIuj5D4XG0OWE0zfK8X tM5rIZwnGocy2xsfLAlZEj97IXECOGiEhjpf16lS6Mp7cwPZre+im9W5ueEIWKw3Mqd5 O9BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689528887; x=1692120887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+fKpcrLfqwSXaKttWPm9/nVZR1vPgyMlgU1qfCuwZk=; b=EZ+ppE473fqsHOAoSxclOjGI845bmR0X3by1S7QMpjwTEpeq5gejkd+t53eYIKD5pt hUqFnNHsrjvYDQklS/rJEgabVYmZyajhOJ2iWEYgAXDVaVperund9jHUR8Kwr37KZtxX c455G9ZdYlwiSwZ31i7K1KtCGE29kUFy0d6bstTRG36YXYGnMsUgsTLhLZl/1x5hQhAl m1XrlroNg1Fb9K9JAyu/yDFOsEKNpP2oLt2HgJXYYHDVt/qDL7PfWnGNEv+egedFm2I3 8msHVqS2hprtPh94WQDfsGTPAFTITGcrji/ZIEs0r8xgDO8f+eRRLqDmrYeIaUsjGzNJ 3xIQ== X-Gm-Message-State: ABy/qLYPrm81/cpExYe5zAgfozusDPPBpJDVFcR315D5gj7Ub73656o2 QbWf4HybD5OsNhrnnKO+LMUWQg== X-Google-Smtp-Source: APBJJlF5HsvF+7Za6ZKRH3qTw4S1wvn6r8DvRycomEvd75w9ZIgBXiUNKD+6CKRofHmEz4CdbdMSmg== X-Received: by 2002:a17:902:eccb:b0:1b9:e9b2:124b with SMTP id a11-20020a170902eccb00b001b9e9b2124bmr9117498plh.64.1689528886712; Sun, 16 Jul 2023 10:34:46 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id h10-20020a170902748a00b001b830d8bc40sm11228732pll.74.2023.07.16.10.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jul 2023 10:34:46 -0700 (PDT) Date: Sun, 16 Jul 2023 10:34:44 -0700 From: Stephen Hemminger To: Markus Theil Cc: dev@dpdk.org, Ferruh Yigit Subject: Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types Message-ID: <20230716103444.73b1d796@hermes.local> In-Reply-To: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> References: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Oct 2022 10:09:44 +0200 Markus Theil wrote: > DPDK uses many different types for socket_id's in its whole code > base. This leads to many warnings and casts in DPDK-based applications > compiled with -Wconversion. > > Announce a treewide consolidation to the return type of rte_socket_id > in DPDK 23.11. > > Signed-off-by: Markus Theil Yes, this is a problem. But it is a bug not something that needs a deprecation notice. The DPDK has avoided using typedefs for port, queue, lcore, and socket. With socket_id there is the need to represent SOCKET_ID_ANY which is -1. Please file a bugzilla entry instead. Looking at code, there a few places doing using uint8_t which will work since no cpu at present supports that many numa nodes. Should probably be a compile assert for that though.