From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6589642EAA; Tue, 18 Jul 2023 19:40:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4543E42D17; Tue, 18 Jul 2023 19:40:25 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id A484B410D3 for ; Tue, 18 Jul 2023 19:40:23 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1bb2468257fso18823035ad.0 for ; Tue, 18 Jul 2023 10:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689702022; x=1692294022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JrltqfJkyu72Ws0iGAdNwqVkRW5iVeeXW09+lu8zo4o=; b=t82NHlxq8ccQN/951dMXuOFSjfVqal1VasS7ZMQlRUd/zQhgKPn2wCoUis1jdbPZZt BfY7HS/zseEUQTZtHd64Gozwj5xU3wQ0J0dRS56Y6cvgbckSMLU9fh+W6xrQ6xymtrFf t3/Hbe92hrFX7fBlZVyGFh5RfXmu7CqsabgP0y9utot5k2FK0Vi0cTl5PBoycz0TU7D+ MxC+COZw59d0nG+h0eACk7lqsUyygzfqFbS7ivau26btvJSd9ALUOiVaZdg15RVpvWFS /0dqH7o5Gk480PHl5FyD8LPC79ZK5tpOt+C9NGzWxtuF+ZoQAx1zngLVq1i+e/W2SLOH rZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689702022; x=1692294022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JrltqfJkyu72Ws0iGAdNwqVkRW5iVeeXW09+lu8zo4o=; b=Yuv7Y39a9NMMsqF8sjd4aVjz0MVDBgawwwz9wVpZi82FaX9GyD1Mu/02fSdLiGscLt 36NkRdsWYMvQJHSrggU4OwGvXpwC6kO/5KDe7N/bK276yiz0QOGkHITpBJWsW3vhg2WF BS60e8QL4TtTYGLaQsUKN3NglvwGi++wRqPSUVPx+jmlMDHnjFkznY9wtClAZnEW3H3D xr9MEH1z7358/GgKwopnR++AzuM5RpDJf6c7AuT6Tah9H7wtvGVUoMj19j5quYjXZO9B VtrBmLKj49T/8UfFnsECWkd0KeEzCBM6ndJHSiwQ/QT8RS7wvkpE55lf4q0yInn/djjs hbjg== X-Gm-Message-State: ABy/qLawQb4Cx33uunUarz8n81uy4NkHMlL32/E6FuzdjlA6l/FbZP8e 6UV66Z07pKpvXHqrk382W9J+L4UYWMbJkxBuz3iYUg== X-Google-Smtp-Source: APBJJlEVpscsVC5al8eeZxe2uws8/IgPqb3YOUA3PR1J4T7VBe2P6lW8NUbt/BPLSKpMWqP6kfwTxw== X-Received: by 2002:a17:902:c406:b0:1b8:9ecd:8b86 with SMTP id k6-20020a170902c40600b001b89ecd8b86mr17384137plk.5.1689702022526; Tue, 18 Jul 2023 10:40:22 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id y12-20020a17090322cc00b001b8b2fb52d4sm2146906plg.203.2023.07.18.10.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 10:40:22 -0700 (PDT) Date: Tue, 18 Jul 2023 10:40:20 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v3 0/2] Improve docs on getting info on running process Message-ID: <20230718104020.40c2d646@hermes.local> In-Reply-To: <20230718164802.110560-1-bruce.richardson@intel.com> References: <20230613143355.77914-1-bruce.richardson@intel.com> <20230718164802.110560-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 18 Jul 2023 17:48:00 +0100 Bruce Richardson wrote: > Add details to our documentation on how to register logging for a > component. Also provide guidelines on when to use logs vs tracing > vs telemetry. > > V3: Moved new doc section on runtime info, and other minor changes flagged > by David on review. > > V2: extended second patch based on the feedback provided. > Hopefully, we can keep this section short and clear as the > revisions roll! :-) > > Bruce Richardson (2): > doc/contributing: provide coding details for dynamic logging > doc/contributing: guidelines for logging, tracing and telemetry > > doc/guides/contributing/coding_style.rst | 18 +++++++++ > doc/guides/contributing/design.rst | 49 ++++++++++++++++++++++++ > doc/guides/prog_guide/telemetry_lib.rst | 2 + > doc/guides/prog_guide/trace_lib.rst | 2 + > lib/cfgfile/rte_cfgfile.c | 2 + > 5 files changed, 73 insertions(+) > > -- > 2.39.2 > Should we add explicit statements about: - Static logtypes (especially LOGTYPE_PMD) should not be used. - New static logtypes must not be added.