DPDK patches and discussions
 help / color / mirror / Atom feed
From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org
Cc: Robin Jarry <rjarry@redhat.com>, Abhiram R N <arn@redhat.com>
Subject: [PATCH] usertools/rss: fix byte order of the default i40e key
Date: Thu, 20 Jul 2023 10:15:01 +0200	[thread overview]
Message-ID: <20230720081500.156361-2-rjarry@redhat.com> (raw)

The key is represented as uint32 words in the driver source code but it
is actually stored as little endian in the NIC registers. Fix the byte
ordering in the python script.

Fixes: 106a231ae528 ("usertools: add tool to generate balanced rss traffic flows")

Reported-by: Abhiram R N <arn@redhat.com>
Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 usertools/dpdk-rss-flows.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py
index 4cdc524ddcb4..73821eb47125 100755
--- a/usertools/dpdk-rss-flows.py
+++ b/usertools/dpdk-rss-flows.py
@@ -179,13 +179,13 @@ def balanced_traffic(
 # i40e is the only driver that takes 52 bytes keys
 RSS_KEY_I40E = bytes(
     (
-        0x6b, 0x79, 0x39, 0x44, 0x23, 0x50, 0x4c, 0xb5,
-        0x5b, 0xea, 0x75, 0xb6, 0x30, 0x9f, 0x4f, 0x12,
-        0x3d, 0xc0, 0xa2, 0xb8, 0x02, 0x4d, 0xdc, 0xdf,
-        0x33, 0x9b, 0x8c, 0xa0, 0x4c, 0x4a, 0xf6, 0x4a,
-        0x34, 0xfa, 0xc6, 0x05, 0x55, 0xd8, 0x58, 0x39,
-        0x3a, 0x58, 0x99, 0x7d, 0x2e, 0xc9, 0x38, 0xe1,
-        0x66, 0x03, 0x15, 0x81,
+        0x44, 0x39, 0x79, 0x6b, 0xb5, 0x4c, 0x50, 0x23,
+        0xb6, 0x75, 0xea, 0x5b, 0x12, 0x4f, 0x9f, 0x30,
+        0xb8, 0xa2, 0xc0, 0x3d, 0xdf, 0xdc, 0x4d, 0x02,
+        0xa0, 0x8c, 0x9b, 0x33, 0x4a, 0xf6, 0x4a, 0x4c,
+        0x05, 0xc6, 0xfa, 0x34, 0x39, 0x58, 0xd8, 0x55,
+        0x7d, 0x99, 0x58, 0x3a, 0xe1, 0x38, 0xc9, 0x2e,
+        0x81, 0x15, 0x03, 0x66,
     )
 )
 # fmt: on
-- 
2.41.0


             reply	other threads:[~2023-07-20  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  8:15 Robin Jarry [this message]
2023-07-22 12:40 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720081500.156361-2-rjarry@redhat.com \
    --to=rjarry@redhat.com \
    --cc=arn@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).