From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, yidingx.zhou@intel.com,
Mingjin Ye <mingjinx.ye@intel.com>,
Cheng Jiang <cheng1.jiang@intel.com>
Subject: [PATCH] app/dma-perf: fix dma mapping access overruns
Date: Thu, 20 Jul 2023 10:09:36 +0000 [thread overview]
Message-ID: <20230720100937.440849-1-mingjinx.ye@intel.com> (raw)
The dma map supports a maximum of `MAX_WORKER_NB=128`. Initializing
the dma map allows a maximum support of `MAX_WORKER_NB=256`. This results
in memory access out-of-bounds when the actual dma entries exceed
MAX_WORKER_NB.
This patch talks about MAX_WORKER_NB and MAX_WORKER_NB size set to 256 to
fix this.
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
app/test-dma-perf/main.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-dma-perf/main.h b/app/test-dma-perf/main.h
index f65e264378..602ecac858 100644
--- a/app/test-dma-perf/main.h
+++ b/app/test-dma-perf/main.h
@@ -10,11 +10,12 @@
#include <rte_cycles.h>
#include <rte_dev.h>
-#define MAX_WORKER_NB 128
+#define MAX_WORKER_NB 256
#define MAX_OUTPUT_STR_LEN 512
#define MAX_DMA_NB 128
-#define MAX_LCORE_NB 256
+/* Note that MAX_LCORE_NB <= MAX_WORKER_NB */
+#define MAX_LCORE_NB MAX_WORKER_NB
extern char output_str[MAX_WORKER_NB + 1][MAX_OUTPUT_STR_LEN];
--
2.25.1
next reply other threads:[~2023-07-20 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 10:09 Mingjin Ye [this message]
2023-10-26 9:53 ` [PATCH v2] app/dma-perf: fix lcores array out of bounds access Mingjin Ye
2023-10-27 14:27 ` [EXT] " Gowrishankar Muthukrishnan
2023-11-14 14:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720100937.440849-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).