From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F58B42EDB; Fri, 21 Jul 2023 17:43:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFAB540E2D; Fri, 21 Jul 2023 17:43:14 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 3BA5F40DDC for ; Fri, 21 Jul 2023 17:43:13 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b8b4749013so15474965ad.2 for ; Fri, 21 Jul 2023 08:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689954192; x=1690558992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KO9v87eu/aVMcPqgHwKPDXfek5q0IFXd/AXSUiseyYk=; b=qqGTLQq3r0hYsNc9IEl5JyBeyH4hqKP4PZpaHK+6yLMGK/ognR59+5JItz+O7Hr/fe rzQiM8OJTIHhwfrCcChK45w6OjzoIzipYKutXiC9SC/zTTEV7soP9johrD1jImlr3VKz cyscSvrdGWfsxbBnNlQz6YcbXUdd3hYznitElbCoRNwA7UFDQ07NrAXz5JfvmNPDLBiw sQof+Tny7bP09VxZtyipkwD+EVBEOrsE+LZ79cvielQxZ2RrCBqYxrNZ6dK6TfQjiWCa q2wMaeTvPZ5CYEY4Lbo0HnTQeo0Qw5zezPT8YK2/8Hev+p0ZBn9Zt8JP2RJia5HUk1YJ +BOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689954192; x=1690558992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KO9v87eu/aVMcPqgHwKPDXfek5q0IFXd/AXSUiseyYk=; b=XvQlrogz1O0eWiE10pe0UDa8425Ce9UFyteHbUeon15TMaiBm1myowVoOwEKUtGrH3 BylGEKnxFCSbB2W1zMepg/+166UacY9+4m+lHs8FkZVxGQPY6JM3fvONi1tgvI4RagHF qWM+I1Cps1DK/dzYL9QQej08CrjaCyH28YCxGTEy8MvcXvj4efQA2sRJuMHjmsAtKh/Y SF3khR3GUG9H0Iy/DoLBpDSLKJI9sYNw/FpEjrcVCXYZGJk3NllaI+E1LKJS28zSqK7k VMDwgv81F6WgEyUYSosMjWFfosvMWz9+HU/re7ylWiaoUkCpXC83aG+EPQK49yCFRQF8 zl/Q== X-Gm-Message-State: ABy/qLYNiqbwJQ/Fa/MHlk5vQ+Smlv0ElbXB5npFKF9aX7QK1pDhWnHh fpCJJspQxYGnsLnQGqZXcV7Zlg== X-Google-Smtp-Source: APBJJlGKqKQB3dfI/xjI/HjTPNSSUC6qnm2LAiMEqnCLFqsb7OlHYESEWKW44GLACESIRgUSp7Zt6w== X-Received: by 2002:a17:902:e812:b0:1bb:5468:d305 with SMTP id u18-20020a170902e81200b001bb5468d305mr2652783plg.13.1689954192294; Fri, 21 Jul 2023 08:43:12 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id e13-20020a17090301cd00b001b83dc8649dsm3629900plh.250.2023.07.21.08.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 08:43:11 -0700 (PDT) Date: Fri, 21 Jul 2023 08:43:09 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Long Li , Ophir Munk , Thomas Monjalon Subject: Re: [PATCH v3] tap: fix build of TAP BPF program Message-ID: <20230721084309.56adb1db@hermes.local> In-Reply-To: <69cfb305-7673-f026-e2b2-cc7cbf78ddde@amd.com> References: <20230716212544.5625-1-stephen@networkplumber.org> <20230720232549.63619-1-stephen@networkplumber.org> <69cfb305-7673-f026-e2b2-cc7cbf78ddde@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 21 Jul 2023 14:05:52 +0100 Ferruh Yigit wrote: > On 7/21/2023 12:25 AM, Stephen Hemminger wrote: > > Move the BPF program related code into a subdirectory. > > And add a Makefile for building it. > > > > The code was depending on old versions of headers from iproute2. > > Include those headers here so that build works. > > > > Thanks Stephen, build works now. > But I am not sure about importing dependent headers to DPDK, could build > work with latest external headers if application updated accordingly? These are not exported headers, it looks like Ophir was extracting them from iproute2. The headers are GPL-2.0 licensed; though just asked Daniel to allow BSD-3-clause version. Not much is being used so we could just open code the parts that are used.