From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>,
david.marchand@redhat.com
Subject: Re: [PATCH v2] kni: remove deprecated kernel network interface
Date: Mon, 31 Jul 2023 08:13:45 -0700 [thread overview]
Message-ID: <20230731081345.4d7c8b66@hermes.local> (raw)
In-Reply-To: <2655909.KRxA6XjA2N@thomas>
On Mon, 31 Jul 2023 10:40:35 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 30/07/2023 19:12, Stephen Hemminger:
> > On Sat, 29 Jul 2023 19:12:05 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > > Deprecation and removal was announced in 22.11.
> > > Make it so.
>
> Would be good to summarize the reason here,
> and name replacements.
>
> Also it should not be completely removed.
> I think we were supposed to move KNI into the kmod repository?
The decision I remember was to remove it completely.
KNI has several issues which make it unstable and even a potential
security problem. Moving it doesn't stop usage.
> > > Leave kernel/linux with empty directory because
> > > CI is trying to directly build it. At some later date,
> > > kernel/linux can be removed.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> >
> > Want suggestions on this.
> > 1. The release notes gets coding style warning because checkpatch
> > is checking that release note matches current release, and release number
> > hasn't change yet. Should I just wait?
>
> Yes the release notes file for 23.11 should be created today.
>
>
> > 2. The OVSrobot is looking into the port library to see the kni symbols.
> > But port is marked as deprecated already.
> > Perhaps we should just pull out port first?
>
> No we must support it until it is removed.
> You should either disable or remove KNI from the port library.
The patch removed from port library and it builds but the ABI
robot was looking for symbols.
Will just remove port library first.
next prev parent reply other threads:[~2023-07-31 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 22:54 [PATCH] " Stephen Hemminger
2023-07-30 2:12 ` [PATCH v2] " Stephen Hemminger
2023-07-30 17:12 ` Stephen Hemminger
2023-07-31 8:40 ` Thomas Monjalon
2023-07-31 15:13 ` Stephen Hemminger [this message]
2023-07-31 15:21 ` David Marchand
2023-07-31 15:35 ` Thomas Monjalon
2023-07-31 21:12 ` Stephen Hemminger
2023-07-31 21:27 ` Thomas Monjalon
2023-08-01 7:33 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731081345.4d7c8b66@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).