From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0828842F92; Mon, 31 Jul 2023 18:42:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D48C740A89; Mon, 31 Jul 2023 18:42:12 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DF1BC4067B for ; Mon, 31 Jul 2023 18:42:10 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 418A12385543; Mon, 31 Jul 2023 09:42:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 418A12385543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1690821730; bh=mhDgZqYx4zuDkeYOlGtw0CeX92+j6PJFmZ6D4liRibI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YbuYycJdyGCLs43PtiiNIBq0JuCJEG/GeQXekKQAquPl0Ad4CBeldsuykVbhKlpwl mbZJHZnEd90VoLLGJADr41p/ZHVCK/vvIgBIqEdrpoHAmyJuNVXU0gmHbPSgBxdVS3 Fms1S1lLcnMS4nwgrJsBk2A8twfZzYXWBGQNzRU4= Date: Mon, 31 Jul 2023 09:42:10 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v2] build: update DPDK to use C11 standard Message-ID: <20230731164210.GA19638@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731155802.2732981-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230731155802.2732981-1-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 04:58:02PM +0100, Bruce Richardson wrote: > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup > > --- > V2: > * Resubmit now that 23.11-rc0 patch applied > * Add _POSIX_C_SOURCE macro to eal_common_errno.c to get POSIX > definition of strerror_r() with c11 standard. > --- > doc/guides/linux_gsg/sys_reqs.rst | 3 ++- > doc/guides/rel_notes/deprecation.rst | 18 ------------------ > doc/guides/rel_notes/release_23_11.rst | 17 +++++++++++++++++ > lib/eal/common/eal_common_errno.c | 1 + > meson.build | 1 + > 5 files changed, 21 insertions(+), 19 deletions(-) > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > index dfeaf4e1c5..13be715933 100644 > --- a/doc/guides/linux_gsg/sys_reqs.rst > +++ b/doc/guides/linux_gsg/sys_reqs.rst > @@ -27,7 +27,8 @@ Compilation of the DPDK > The setup commands and installed packages needed on various systems may be different. > For details on Linux distributions and the versions tested, please consult the DPDK Release Notes. > > -* General development tools including a supported C compiler such as gcc (version 4.9+) or clang (version 3.4+), > +* General development tools including a C compiler supporting the C11 standard, > + including standard atomics, for example: GCC (version 5.0+) or Clang (version 3.6+), > and ``pkg-config`` or ``pkgconf`` to be used when building end-user binaries against DPDK. > > * For RHEL/Fedora systems these can be installed using ``dnf groupinstall "Development Tools"`` > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 494b401cda..cc939d3c67 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -17,24 +17,6 @@ Other API and ABI deprecation notices are to be posted below. > Deprecation Notices > ------------------- > > -* C Compiler: From DPDK 23.11 onwards, > - building DPDK will require a C compiler which supports the C11 standard, > - including support for C11 standard atomics. > - > - More specifically, the requirements will be: > - > - * Support for flag "-std=c11" (or similar) > - * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag > - > - Please note: > - > - * C11, including standard atomics, is supported from GCC version 5 onwards, > - and is the default language version in that release > - (Ref: https://gcc.gnu.org/gcc-5/changes.html) > - * C11 is the default compilation mode in Clang from version 3.6, > - which also added support for standard atomics > - (Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html) > - > * build: Enabling deprecated libraries (``flow_classify``, ``kni``) > won't be possible anymore through the use of the ``disable_libs`` build option. > A new build option for deprecated libraries will be introduced instead. > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst > index 6b4dd21fd0..c8b9ed456c 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -20,6 +20,23 @@ DPDK Release 23.11 > ninja -C build doc > xdg-open build/doc/guides/html/rel_notes/release_23_11.html > > +* Build Requirements: From DPDK 23.11 onwards, > + building DPDK will require a C compiler which supports the C11 standard, > + including support for C11 standard atomics. > + > + More specifically, the requirements will be: > + > + * Support for flag "-std=c11" (or similar) > + * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag > + > + Please note: > + > + * C11, including standard atomics, is supported from GCC version 5 onwards, > + and is the default language version in that release > + (Ref: https://gcc.gnu.org/gcc-5/changes.html) > + * C11 is the default compilation mode in Clang from version 3.6, > + which also added support for standard atomics > + (Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html) > > New Features > ------------ > diff --git a/lib/eal/common/eal_common_errno.c b/lib/eal/common/eal_common_errno.c > index ef8f782abb..b30e2f0ad4 100644 > --- a/lib/eal/common/eal_common_errno.c > +++ b/lib/eal/common/eal_common_errno.c > @@ -4,6 +4,7 @@ > > /* Use XSI-compliant portable version of strerror_r() */ > #undef _GNU_SOURCE > +#define _POSIX_C_SOURCE 200809L > > #include > #include > diff --git a/meson.build b/meson.build > index 39cb73846d..70b54f0c98 100644 > --- a/meson.build > +++ b/meson.build > @@ -9,6 +9,7 @@ project('DPDK', 'c', > license: 'BSD', > default_options: [ > 'buildtype=release', > + 'c_std=c11', > 'default_library=static', > 'warning_level=2', > ], > -- oh I acked v2 (and you can maintain that ack) but one additional removal of forced -std=gnu99 is maybe necessary? drivers/net/failsafe/meson.build probably should remove cflags += '-std=gnu99' if we remove it we inherit the -std=c11 from meson project configuration and define a _POSIX_C_SOURCE narrowly where necessary (if it is needed).