From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1304D42F9A; Tue, 1 Aug 2023 17:18:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9317B40F16; Tue, 1 Aug 2023 17:18:27 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id ED8CC40A89 for ; Tue, 1 Aug 2023 17:18:25 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-267ffa7e441so4092746a91.1 for ; Tue, 01 Aug 2023 08:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1690903104; x=1691507904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=eKrhJ6JCpC5K7/zXN7AbzdDuVjWDCOKRUHe1Ti/+16g=; b=IoWU1AzHInwnUFxfwyJ8auFUUPKluYracJ8Yc4iSpLWEy/8TVM3Zwo5SddE1hrrVYK ItoBy+BCA7XnVQtHePZPMPevlqOWEMr17r8zaM3NX8AtvpAGylWrzbCx5aybMoQz0Nt0 TNnaB70sAk7GBmh1irpNeLv1/g5ixIeoZVfYtyQRrAEtbWBH7w9jN6rdvSSO44biHYT1 89T13JSP3/q7Z9MVFDuTVoFsPRYJRBErMk6xW6wCxck6islJ9NR23ywpbLexWIG3w+w9 F+K4fx9aFVSKPut1Nyns0gLM5qt5roQ/0sSsAzpolZB725Z1ZBJOVDW5odrMPdMysX/z Jlbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690903104; x=1691507904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eKrhJ6JCpC5K7/zXN7AbzdDuVjWDCOKRUHe1Ti/+16g=; b=Bp82MCmTJJW/pd6tmleRiYpk2IZ/6R+VLCfI/xU6qOkvzMaCOeubIYMJ1nv5o+XAY/ D7t9bFDfD3mKBVd3/f8bbsSHIxK4bI4Bw7d3EiYMP4dpHn2NaPxbHEt5OgGnaz87TZnO p4MsmJjGBj5MXAp19ODrZQMHdCVK48E5nRKYYPDyLp34SMZdyLmwjU/Vt/VMUYjRQ+A3 EJljfs3vt4zxOBgqc3UsP8ymnRXrnxMHS/5FJEyRcQamAkK0iBzIEfoeD2Rj7t5vF6LO AGwRKSBUm6idLY0rOyoj8oqaAIrkRFdDLYWbJM+Q/bzsMNfqt0AzX8SxjOi6aPI41TpY usow== X-Gm-Message-State: ABy/qLb6WdR3m9BOuIm6Zd3oYBvi+Y2qd00vIMOq372tgcnTVJl96EIw 8gKEa8mQdZ8nVzVKjacuE/8CIw== X-Google-Smtp-Source: APBJJlHdeBZLDLx6If9BP6uBhww9a5orJdMJw3UED8wZr6f/74uhkYvpOYxIU0/1eYlM+Lc8sLURIw== X-Received: by 2002:a17:90b:4a0c:b0:268:a5f6:2a97 with SMTP id kk12-20020a17090b4a0c00b00268a5f62a97mr9725954pjb.1.1690903103919; Tue, 01 Aug 2023 08:18:23 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id x4-20020a1709027c0400b001bbcf43e120sm10652096pll.95.2023.08.01.08.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 08:18:23 -0700 (PDT) Date: Tue, 1 Aug 2023 08:18:21 -0700 From: Stephen Hemminger To: Dengdui Huang Cc: , , , , , Subject: Re: [PATCH] app/testpmd: add flush multicast MAC address command Message-ID: <20230801081821.0fcbf4d1@hermes.local> In-Reply-To: <20230801024304.2187484-1-huangdengdui@huawei.com> References: <20230801024304.2187484-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 1 Aug 2023 10:43:04 +0800 Dengdui Huang wrote: > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 0d0723f659..2d9d925776 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result, > "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n" > " Remove a MAC address from port_id.\n\n" > > + "mcast_addr flush (port_id)\n" > + " To flush the set of multicast addresses.\n\n" > + > "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n" > " Set the default MAC address for port_id.\n\n" Why out this in middle of the mac_addr commands? better to be in logical or alpha order.