From: Stephen Hemminger <stephen@networkplumber.org>
To: Kaiyu Zhang <squirrel.prog@gmail.com>
Cc: thomas@monjalon.net, ferruh.yigit@amd.com,
andrew.rybchenko@oktetlabs.ru, dev@dpdk.org
Subject: Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation
Date: Tue, 1 Aug 2023 09:19:42 -0700 [thread overview]
Message-ID: <20230801091942.1727e6bb@hermes.local> (raw)
In-Reply-To: <20230711011809.96677-1-squirrel.prog@gmail.com>
On Tue, 11 Jul 2023 01:18:09 +0000
Kaiyu Zhang <squirrel.prog@gmail.com> wrote:
> sanity check is performed after a rte_eth_dev object is allocated.
> The object is not freed if the check fails, though in the current
> reality this never happens, but it's better programming paradigm
> to move the quick check up front to the start of
> rte_eth_dev_pci_generic_probe.
>
> Signed-off-by: Kaiyu Zhang <squirrel.prog@gmail.com>
The term sanity check is on the non-inclusive naming word list.
Please don't use that term in DPDK.
There is an outstanding patchset to remove all use of the term.
prev parent reply other threads:[~2023-08-01 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 1:18 Kaiyu Zhang
2023-07-11 1:48 ` fengchengwen
2023-07-11 13:37 ` Ferruh Yigit
2023-08-01 16:19 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801091942.1727e6bb@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=squirrel.prog@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).