From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9868B42FB8;
	Wed,  2 Aug 2023 18:11:55 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 23AE240DDB;
	Wed,  2 Aug 2023 18:11:55 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 60F944021D
 for <dev@dpdk.org>; Wed,  2 Aug 2023 18:11:53 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id B2143238C42C; Wed,  2 Aug 2023 09:11:52 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B2143238C42C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1690992712;
 bh=4LKrymwUJOIG4WcjpCvc5KJ8L+J6FA2JJ2PziRj9xTI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=UMMqSM5xZz5yYeOx34xQwfKzsGa6yNca91SFyhq2WGh8YgQPkXGEt2k+8RIyB1tHt
 vRFgm3jLZGpXpE3DjxF5/MhrDQJ9A3yUQVx1mgnqKknbCU0RlEYV9n1X1T4S7USjF7
 ERii2iar5QAnuDD9cFu352rmhD2NtaSPXvYCD4xY=
Date: Wed, 2 Aug 2023 09:11:52 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
 Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH v2] build: check drivers class dependencies early
Message-ID: <20230802161152.GA25359@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230801085253.2447095-1-david.marchand@redhat.com>
 <20230801134133.2860104-1-david.marchand@redhat.com>
 <ZMkQOxUtl7AO/x8A@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZMkQOxUtl7AO/x8A@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Aug 01, 2023 at 03:01:31PM +0100, Bruce Richardson wrote:
> On Tue, Aug 01, 2023 at 03:41:33PM +0200, David Marchand wrote:
> > Drivers implementing a class of devices (for example, drivers/event)
> > depend on the associated abstraction library (lib/eventdev).
> > This dependency is expressed in the top level meson.build for this class
> > (drivers/event/meson.build).
> > 
> > As we are making more libraries optional, custom constructs referencing
> > the class dependencies in some drivers meson.build (event/dlb2) may break.
> > 
> > It would be possible to add more checks in those drivers meson.build but
> > it is more straightforward to not even consider a driver meson.build when
> > the class dependencies are not met.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>