From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 849B542FBA; Wed, 2 Aug 2023 23:12:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51BC2410F1; Wed, 2 Aug 2023 23:12:21 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) by mails.dpdk.org (Postfix) with ESMTP id 27827410DC for ; Wed, 2 Aug 2023 23:12:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4m0Cr2jcOyypkXlrFB74dT9kaNpKXssQaoQDw0Yfw9fBSgbZqxKGpXzr2jpHd2hEv7cd0ooz8gLn1GBGpt3JERfsMGunj9j73Ob39XhiefePtDfY6B6lnT6e70zitOTcbLJHisiam/gqjqTAlxxPQ4rM/UBwjmRxrw9SXONMrkd4GlhSai7+iFnWHbgcWpFxCuns4CRIeBjybzHldhaHCV5UxQl5JD63nCpEnQT3YREISlhD3riaeCR+4l8jvbtMqjgodkZ6/LW9LqQNK2Oh0x4Swn4Zrgaxj5zsfA6PxxyiNJmFoCZPEwZR38qSlA8ZpqjLODGUML1l4axN2BlCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dLmlMGI2V8k3Bf9JBCtjOklHEMh1+7mxdPZedJac58Q=; b=mHV+54JmI1HfOub7q71wa+BMEKdUyaIcJNrnMx2brmgL8zUKIZcs0M0ns1N4YxranD9ydHKMvoI47aaSyKEpdZ51PuxHvgTXNmpiJdT9FnZBO1OptZt5Joo1CPoxpcpgJa4qGwd6gct6L1PiSIy31h5JrHOWM0n5EG6evjEJIAxnNeNsVglWabeV6ews/86kT0HxlmEM88grZlB6YxkG42IIKmS16t7CXOQIB4kXnnC3WZNZvMh6UOea/qWkVJ1r2AnwaNfvi4P8BQhvlbQoGiAne5xSNu4QHx6wqjKMqSzrTwEFcLKYC84hu0NMqaUJncn3YBsVVieX0pNlYQlQ2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLmlMGI2V8k3Bf9JBCtjOklHEMh1+7mxdPZedJac58Q=; b=CBYlEK1rAi/I1nzcAR9eY6eA/o9zA649vnPWNUl+KB9ClyOuG5szeC7vgh62pxo7v9zSS0GLh/wApwJ9V7pY0PSq7Pz8a/HHVrjKzpQ0UFVQ7QEyMrwhs6/Zazd+o7/+A6oHcwi6SHXwY9/GENA8FhPRdnIctyZ7lHvoyHeWsWU= Received: from MW4PR04CA0171.namprd04.prod.outlook.com (2603:10b6:303:85::26) by CH2PR12MB5019.namprd12.prod.outlook.com (2603:10b6:610:6a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Wed, 2 Aug 2023 21:12:10 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:303:85:cafe::d3) by MW4PR04CA0171.outlook.office365.com (2603:10b6:303:85::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 21:12:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Wed, 2 Aug 2023 21:12:10 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 16:12:08 -0500 From: Sivaprasad Tummala To: , , , , , CC: Subject: [PATCH 1/2] eal: remove RTE_CPUFLAG_NUMFLAGS Date: Wed, 2 Aug 2023 14:11:49 -0700 Message-ID: <20230802211150.939121-1-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|CH2PR12MB5019:EE_ X-MS-Office365-Filtering-Correlation-Id: a3980b47-b15e-463e-c6ce-08db939d22c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Aa3R7gXQR8p9Oe3GEAoDyBCBU9b/3ymSz7Z5V1koLYIyYaw/Bm28rRuT3q2UNMHarQK5kwB0nF5mBeJzA0dVujvZVRdykqhwNIYR3SG6ipnZLWq+RXz3PxnNdcewikZPV0idgyCkBOHNOAaJUUDvHAVrczQwWXlIs7YrJjwch8u3ifncpwcaPqFU4y5TStkJEmW8sdSz8mAsuIBrxpl6o+evwFhoo+UEfiDHBsneX/sGfsXQzQ61mc12NpOvmIz0L0sTg1nsMIiJJbk5rVJN52+oPmAeg3sDxRYm+mCUvIZIBZeOlglDTtixItxVjf6AXVjJdQActf2FvuFG41w+GM6u/Y/fzESVgyLloBitVoka57PjGrX15OloaQOrcx7UXjy6m+z2b9iyLaPKCo7MTD1q8O7R6tPWz0HI1/vecyaZVnlPY9dz7zmwJn64pNn0uRlmKBMGTEOHjFpTo0VTuSGr8g/qULv//bI0pM0xKHISf+WD0FczSAwbAhZgA3F7zZ812ajDgXvTP+8dDTuvIQUAo4tTOaco1/rzcCORWsbDkHAFaP62HEYrHIGRs/Hjm6gQMqgptDeLkUI0Moc+dmoPp/63zpQYmm/beVNe0TpefNGoiWNVplAH4n4WM36Kx8hKCgaXivTheCfBaOO8p0b5q0s8myF+rb6/v/uSrrLHcXinURkKV0qkEaF/FeZajy3pypYWUCh6okrRaIBiYw2tWDpqkCrm0WqRzWq/4nph+kq6Vj55OIAh5hKAJojdYK6xwPFFeQgH8UJyLYNEZQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(82310400008)(451199021)(40470700004)(36840700001)(46966006)(2906002)(86362001)(8936002)(8676002)(44832011)(36756003)(40460700003)(40480700001)(83380400001)(26005)(36860700001)(16526019)(81166007)(47076005)(356005)(1076003)(336012)(186003)(426003)(2616005)(7696005)(6666004)(41300700001)(5660300002)(316002)(478600001)(110136005)(70586007)(82740400003)(4326008)(70206006)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 21:12:10.4135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3980b47-b15e-463e-c6ce-08db939d22c9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5019 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU features without breaking ABI each time. Signed-off-by: Sivaprasad Tummala --- lib/eal/arm/include/rte_cpuflags_32.h | 1 - lib/eal/arm/include/rte_cpuflags_64.h | 1 - lib/eal/arm/rte_cpuflags.c | 7 +++++-- lib/eal/loongarch/include/rte_cpuflags.h | 1 - lib/eal/loongarch/rte_cpuflags.c | 7 +++++-- lib/eal/ppc/include/rte_cpuflags.h | 1 - lib/eal/ppc/rte_cpuflags.c | 7 +++++-- lib/eal/riscv/include/rte_cpuflags.h | 1 - lib/eal/riscv/rte_cpuflags.c | 7 +++++-- lib/eal/x86/include/rte_cpuflags.h | 1 - lib/eal/x86/rte_cpuflags.c | 7 +++++-- 11 files changed, 25 insertions(+), 16 deletions(-) diff --git a/lib/eal/arm/include/rte_cpuflags_32.h b/lib/eal/arm/include/rte_cpuflags_32.h index 4e254428a2..41ab0d5f21 100644 --- a/lib/eal/arm/include/rte_cpuflags_32.h +++ b/lib/eal/arm/include/rte_cpuflags_32.h @@ -43,7 +43,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_V7L, RTE_CPUFLAG_V8L, /* The last item */ - RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/arm/include/rte_cpuflags_64.h b/lib/eal/arm/include/rte_cpuflags_64.h index aa7a56d491..ea5193e510 100644 --- a/lib/eal/arm/include/rte_cpuflags_64.h +++ b/lib/eal/arm/include/rte_cpuflags_64.h @@ -37,7 +37,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_SVEBF16, RTE_CPUFLAG_AARCH64, /* The last item */ - RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/arm/rte_cpuflags.c b/lib/eal/arm/rte_cpuflags.c index 56e7b2e689..447a8d9f9f 100644 --- a/lib/eal/arm/rte_cpuflags.c +++ b/lib/eal/arm/rte_cpuflags.c @@ -139,8 +139,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) { const struct feature_entry *feat; hwcap_registers_t regs = {0}; + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); - if (feature >= RTE_CPUFLAG_NUMFLAGS) + if (feature >= num_flags) return -ENOENT; feat = &rte_cpu_feature_table[feature]; @@ -154,7 +155,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const char * rte_cpu_get_flag_name(enum rte_cpu_flag_t feature) { - if (feature >= RTE_CPUFLAG_NUMFLAGS) + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); + + if (feature >= num_flags) return NULL; return rte_cpu_feature_table[feature].name; } diff --git a/lib/eal/loongarch/include/rte_cpuflags.h b/lib/eal/loongarch/include/rte_cpuflags.h index 1c80779262..9ff8baaa3c 100644 --- a/lib/eal/loongarch/include/rte_cpuflags.h +++ b/lib/eal/loongarch/include/rte_cpuflags.h @@ -27,7 +27,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_LBT_ARM, RTE_CPUFLAG_LBT_MIPS, /* The last item */ - RTE_CPUFLAG_NUMFLAGS /**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/loongarch/rte_cpuflags.c b/lib/eal/loongarch/rte_cpuflags.c index 0a75ca58d4..642eb42509 100644 --- a/lib/eal/loongarch/rte_cpuflags.c +++ b/lib/eal/loongarch/rte_cpuflags.c @@ -66,8 +66,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) { const struct feature_entry *feat; hwcap_registers_t regs = {0}; + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); - if (feature >= RTE_CPUFLAG_NUMFLAGS) + if (feature >= num_flags) return -ENOENT; feat = &rte_cpu_feature_table[feature]; @@ -81,7 +82,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const char * rte_cpu_get_flag_name(enum rte_cpu_flag_t feature) { - if (feature >= RTE_CPUFLAG_NUMFLAGS) + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); + + if (feature >= num_flags) return NULL; return rte_cpu_feature_table[feature].name; } diff --git a/lib/eal/ppc/include/rte_cpuflags.h b/lib/eal/ppc/include/rte_cpuflags.h index a88355d170..b74e7a73ee 100644 --- a/lib/eal/ppc/include/rte_cpuflags.h +++ b/lib/eal/ppc/include/rte_cpuflags.h @@ -49,7 +49,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_HTM, RTE_CPUFLAG_ARCH_2_07, /* The last item */ - RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/ppc/rte_cpuflags.c b/lib/eal/ppc/rte_cpuflags.c index 61db5c216d..3a639ef45a 100644 --- a/lib/eal/ppc/rte_cpuflags.c +++ b/lib/eal/ppc/rte_cpuflags.c @@ -90,8 +90,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) { const struct feature_entry *feat; hwcap_registers_t regs = {0}; + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); - if (feature >= RTE_CPUFLAG_NUMFLAGS) + if (feature >= num_flags) return -ENOENT; feat = &rte_cpu_feature_table[feature]; @@ -105,7 +106,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const char * rte_cpu_get_flag_name(enum rte_cpu_flag_t feature) { - if (feature >= RTE_CPUFLAG_NUMFLAGS) + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); + + if (feature >= num_flags) return NULL; return rte_cpu_feature_table[feature].name; } diff --git a/lib/eal/riscv/include/rte_cpuflags.h b/lib/eal/riscv/include/rte_cpuflags.h index 66e787f898..803c3655ae 100644 --- a/lib/eal/riscv/include/rte_cpuflags.h +++ b/lib/eal/riscv/include/rte_cpuflags.h @@ -43,7 +43,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_RISCV_ISA_Y, /* Reserved */ RTE_CPUFLAG_RISCV_ISA_Z, /* Reserved */ /* The last item */ - RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/riscv/rte_cpuflags.c b/lib/eal/riscv/rte_cpuflags.c index 4f6d29b947..a452261188 100644 --- a/lib/eal/riscv/rte_cpuflags.c +++ b/lib/eal/riscv/rte_cpuflags.c @@ -95,8 +95,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) { const struct feature_entry *feat; hwcap_registers_t regs = {0}; + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); - if (feature >= RTE_CPUFLAG_NUMFLAGS) + if (feature >= num_flags) return -ENOENT; feat = &rte_cpu_feature_table[feature]; @@ -110,7 +111,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const char * rte_cpu_get_flag_name(enum rte_cpu_flag_t feature) { - if (feature >= RTE_CPUFLAG_NUMFLAGS) + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); + + if (feature >= num_flags) return NULL; return rte_cpu_feature_table[feature].name; } diff --git a/lib/eal/x86/include/rte_cpuflags.h b/lib/eal/x86/include/rte_cpuflags.h index 92e90fb6e0..7fc6117243 100644 --- a/lib/eal/x86/include/rte_cpuflags.h +++ b/lib/eal/x86/include/rte_cpuflags.h @@ -135,7 +135,6 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_WAITPKG, /**< UMONITOR/UMWAIT/TPAUSE */ /* The last item */ - RTE_CPUFLAG_NUMFLAGS, /**< This should always be the last! */ }; #include "generic/rte_cpuflags.h" diff --git a/lib/eal/x86/rte_cpuflags.c b/lib/eal/x86/rte_cpuflags.c index d6b518251b..00d17c7515 100644 --- a/lib/eal/x86/rte_cpuflags.c +++ b/lib/eal/x86/rte_cpuflags.c @@ -149,8 +149,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const struct feature_entry *feat; cpuid_registers_t regs; unsigned int maxleaf; + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); - if (feature >= RTE_CPUFLAG_NUMFLAGS) + if (feature >= num_flags) /* Flag does not match anything in the feature tables */ return -ENOENT; @@ -176,7 +177,9 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature) const char * rte_cpu_get_flag_name(enum rte_cpu_flag_t feature) { - if (feature >= RTE_CPUFLAG_NUMFLAGS) + unsigned int num_flags = RTE_DIM(rte_cpu_feature_table); + + if (feature >= num_flags) return NULL; return rte_cpu_feature_table[feature].name; } -- 2.34.1