From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id ABE6F42FBB;
	Thu,  3 Aug 2023 02:30:11 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3ABB4406BA;
	Thu,  3 Aug 2023 02:30:11 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id BD6E6406B8
 for <dev@dpdk.org>; Thu,  3 Aug 2023 02:30:09 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id F2B83238C42F; Wed,  2 Aug 2023 17:30:08 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F2B83238C42F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1691022609;
 bh=JOT373CeeGlmZzh/jj/VF5XkkED646ynewj0lvaCg9Y=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=jfp98j3kbu/Ga8ZXNAW5YR8EA0yobn7u00dCNeSu9TCEJVUvfmvYIQ79Sj5GMWm+8
 khZ5D2GHi0fsJS2aGaUphOXo3bOMf8jCPfq1QsQCnJp0PdiBTH15UT2x6U/lQcEcsw
 omJnWJjJrghHg5A2/Lv1pJXOuA/8jJTe3k8sDXjc=
Date: Wed, 2 Aug 2023 17:30:08 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal/windows: resolve conversion and truncation warnings
Message-ID: <20230803003008.GB19745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com>
 <20230803012900.57b9cb78@sovereign>
 <20230802224130.GA19745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20230803024445.282a1bf4@sovereign>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230803024445.282a1bf4@sovereign>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Aug 03, 2023 at 02:44:45AM +0300, Dmitry Kozlyuk wrote:
> 2023-08-02 15:41 (UTC-0700), Tyler Retzlaff:
> > one thing that confuses me a little and this change won't break how the
> > code already works (just makes the cast redundant) is that for mingw
> > sizeof(long) is being reported as 8 bytes.
> > 
> > this is in spec relative to the C standard but it does leave me somewhat
> > concerned if struct timespec as defined in the windows headers crosses
> > an abi boundary.
> 
> MinGW-w64 shows sizeof(long) == 4 in my tests, both native and cross build.
> Which MinGW setup reports sizeof(long) == 8 on Windows target?

it must have been a dream, i just checked and i get the results you do.

ignore me i'm tired, thanks for checking though.