From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DC0D42FBA; Thu, 3 Aug 2023 01:44:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BE76406BA; Thu, 3 Aug 2023 01:44:49 +0200 (CEST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id 9E3B2406B8 for ; Thu, 3 Aug 2023 01:44:47 +0200 (CEST) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4fe1b00fce2so573953e87.3 for ; Wed, 02 Aug 2023 16:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691019887; x=1691624687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OqF8934QHMIFd1gJM4By0mQvsAvnXsI1OmipTsOjCUY=; b=Hz9Ca40CG0KVQi+p7Xtm+cmeVNVNEhMiVy8nbJK6Mkl9qnYqatfcvmE7dLpZMkH2Lz 0H09MCXpVKlSYTnj5ixvHYkeKUqZbLGZieWxUs6yERW+EWOIY2dAlqxsHDlfAI1txE7g DZIAJ2h+bma23BP4UzN54UaL5wrsXl38kiN63b9un4ZGX1sfVPay+ZwuvcLlKJIdz1gh S1imXY9TnaOtUvQeDLSYt+FqqaPfURrS3CTcJErSxoKy8gh0OsoOMz30QnmOzuP9kdbJ 362HtBxkDKTCMy5zGX2M6czOH9kwMrFGLRqk6e8k0y0XNSWgd0feCP2rZ5XWaMYRxJsi JuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691019887; x=1691624687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OqF8934QHMIFd1gJM4By0mQvsAvnXsI1OmipTsOjCUY=; b=TIbwBcgmL7dFaZIuiStJjYoVY7Yfv1j+SdvptFvGTKNVIDqbbcB/08Z6uTbVrzcqHG XvS0AOg/P5S6Bs2yW/uvWviLJhEdwd+3xOCIK8dypkN6ftLPsuIyAUtMe47c1L8jGLIU M1qzvUjdkbeZGL2nPrPjLnevPUzFJCOMsAXCY4lQbVugcuYAbfvcyT6WGzPpxyt3SPeM mm7OKWdMHEDUw6qNeY443R5m0BqAKpo1D5Wl5IYRGTUfz3rM54LkIfL0JLVwHgVNRFjE P/XN15QruJ6Po27nHmkX5Ngu5y1BK8pQD+DMQptSVDc+nIHy2AOEK3j6bMjCckqixleo 66YA== X-Gm-Message-State: ABy/qLYB5OOV52mIWQDqunUFA/KTRGLgz8eKzkAz/vYkY+UcKlsNbz+f Qm8c+yVl65ernQnkNQGO8v0= X-Google-Smtp-Source: APBJJlHZNNhhar/fwOv2T9MBp5CC3iTACN93Vk8BN5aaw9uV1rZNTJQ18MlC7Ozk+UzrNdVVDkUDXA== X-Received: by 2002:a05:6512:3ee:b0:4fe:3a57:7c90 with SMTP id n14-20020a05651203ee00b004fe3a577c90mr5416646lfq.19.1691019886730; Wed, 02 Aug 2023 16:44:46 -0700 (PDT) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id c5-20020ac244a5000000b004fad16596fasm3135686lfm.21.2023.08.02.16.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 16:44:46 -0700 (PDT) Date: Thu, 3 Aug 2023 02:44:45 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: dev@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: resolve conversion and truncation warnings Message-ID: <20230803024445.282a1bf4@sovereign> In-Reply-To: <20230802224130.GA19745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com> <20230803012900.57b9cb78@sovereign> <20230802224130.GA19745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2023-08-02 15:41 (UTC-0700), Tyler Retzlaff: > one thing that confuses me a little and this change won't break how the > code already works (just makes the cast redundant) is that for mingw > sizeof(long) is being reported as 8 bytes. > > this is in spec relative to the C standard but it does leave me somewhat > concerned if struct timespec as defined in the windows headers crosses > an abi boundary. MinGW-w64 shows sizeof(long) == 4 in my tests, both native and cross build. Which MinGW setup reports sizeof(long) == 8 on Windows target?