From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C57542FD6; Fri, 4 Aug 2023 18:16:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4800B40EF1; Fri, 4 Aug 2023 18:16:17 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id EB8E540EE1 for ; Fri, 4 Aug 2023 18:16:15 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1b8ad8383faso19901525ad.0 for ; Fri, 04 Aug 2023 09:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691165775; x=1691770575; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0FYeDt/4POSf/R0UGhzPlBVKshhMhYZuUcnvyZp2j/E=; b=2DUwzagMtF2U/+ZVRGevE3bWT4tH6pymmDC0soTIckVqdwpfqSqpdCoNk4+4x0tM3R A0PAaFnqDoqf0BJWSmAeUO0YefDQMyicgYfMlPiXcqTm/oqf0hpqWtZnN7QvZaPApbTN EsN0v7FW+PlV1PRNQZYOEbQZnsIT5gV0oNy8LdA6m8GFSzvZnv5oDluKjHUbaLf6ZnjO nbNrGMRgru6VuvXYTohLSAztt9izFf+G3bk98AadZsVWo7SdLV2JVXPynA3SH8WwvxGq 5yVRGcAt6OgO774m7/JWaufNoPFUayD1Ygu58lynoAhQyFq3E5juylFDF5iFAeS/X7A/ 29+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691165775; x=1691770575; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0FYeDt/4POSf/R0UGhzPlBVKshhMhYZuUcnvyZp2j/E=; b=T+Nzc2RtmFdJKh6Ly0LryQfB8FuYUwymj6vrocq9gyEE3/wHZuSHYu/mi/rhGeUZLV GT1SOpkeCFdHbEAKBzsvsojTQOBVOPhSZoBlQoQbq4JXkzVn2QqeUzBawUGoFvjaVc7G 1PS+NxuWFXQrS7XyVuiDIDr8mwp/SM8gYvgTmUv/1bwkwgP5cBWgNoFJhLAH4TAK0zX5 XKn74RofJvN66xWyvVOB3Mrby6ZmPsX1TnBphwU9pG4s5PrtJem5gZSwmOMEFlEVyM29 +epHKtnjOCWv42gr9/K8AGfrFp5VI9eGNLLINEP/Jyz08rDbYASllOxdv07MbEJh2HmN lLBw== X-Gm-Message-State: AOJu0YzTH+MNhDYwdG/MqAJWbwWTvGZ0rtA8armRJoUxZwe9GaOtiY4q ZcG9ObhTOy5TiAo7wc/cDbPkIXRaOpm8W2BvVPkzBw== X-Google-Smtp-Source: AGHT+IF/d1wCS/a/uCzXTmy8z9geM98UdFImZV0ppvmbrdwhhhv4ewuXTz5PU5PSJvDsz/+dtjdqdA== X-Received: by 2002:a17:903:1cc:b0:1b8:a19e:a3d3 with SMTP id e12-20020a17090301cc00b001b8a19ea3d3mr2002370plh.52.1691165774794; Fri, 04 Aug 2023 09:16:14 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id jk21-20020a170903331500b001bbb7d8fff2sm1959743plb.116.2023.08.04.09.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 09:16:14 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH] dumpcap: fix mbuf pool ring type Date: Fri, 4 Aug 2023 09:16:04 -0700 Message-Id: <20230804161604.61050-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The ring used to store mbufs needs to be multiple producer, multiple consumer because multiple queues might on multiple cores might be allocating and same time (consume) and in case of ring full, the mbufs will be returned (multiple producer). Bugzilla ID: 1271 Fixes: cb2440fd77af ("dumpcap: fix mbuf pool ring type") Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 64294bbfb3e6..991174e95022 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -691,10 +691,9 @@ static struct rte_mempool *create_mempool(void) data_size = mbuf_size; } - mp = rte_pktmbuf_pool_create_by_ops(pool_name, num_mbufs, - MBUF_POOL_CACHE_SIZE, 0, - data_size, - rte_socket_id(), "ring_mp_sc"); + mp = rte_pktmbuf_pool_create(pool_name, num_mbufs, + MBUF_POOL_CACHE_SIZE, 0, + data_size, rte_socket_id()); if (mp == NULL) rte_exit(EXIT_FAILURE, "Mempool (%s) creation failed: %s\n", pool_name, -- 2.39.2