From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] app/proc-info: remove unnecessary rte_malloc
Date: Mon, 7 Aug 2023 13:43:10 -0700 [thread overview]
Message-ID: <20230807204310.117986-1-stephen@networkplumber.org> (raw)
Better to use malloc() which is faster and has more error
checking, as is done already for statistics.
Fixes: 077c546704da ("app/proc_info: add metrics displaying")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/proc-info/main.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 88cee0ca487b..7bc43b8c793e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -19,7 +19,6 @@
#include <rte_common.h>
#include <rte_debug.h>
#include <rte_ethdev.h>
-#include <rte_malloc.h>
#include <rte_memory.h>
#include <rte_memzone.h>
#include <rte_launch.h>
@@ -909,24 +908,23 @@ metrics_display(int port_id)
return;
}
- metrics = rte_malloc("proc_info_metrics",
- sizeof(struct rte_metric_value) * len, 0);
+ metrics = malloc(sizeof(struct rte_metric_value) * len);
if (metrics == NULL) {
printf("Cannot allocate memory for metrics\n");
return;
}
- names = rte_malloc(NULL, sizeof(struct rte_metric_name) * len, 0);
+ names = malloc(sizeof(struct rte_metric_name) * len);
if (names == NULL) {
printf("Cannot allocate memory for metrics names\n");
- rte_free(metrics);
+ free(metrics);
return;
}
if (len != rte_metrics_get_names(names, len)) {
printf("Cannot get metrics names\n");
- rte_free(metrics);
- rte_free(names);
+ free(metrics);
+ free(names);
return;
}
@@ -938,8 +936,8 @@ metrics_display(int port_id)
ret = rte_metrics_get_values(port_id, metrics, len);
if (ret < 0 || ret > len) {
printf("Cannot get metrics values\n");
- rte_free(metrics);
- rte_free(names);
+ free(metrics);
+ free(names);
return;
}
@@ -948,8 +946,8 @@ metrics_display(int port_id)
printf("%s: %"PRIu64"\n", names[i].name, metrics[i].value);
printf("%s############################\n", nic_stats_border);
- rte_free(metrics);
- rte_free(names);
+ free(metrics);
+ free(names);
}
#endif
--
2.39.2
next reply other threads:[~2023-08-07 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 20:43 Stephen Hemminger [this message]
2023-08-08 1:11 ` fengchengwen
2023-10-17 19:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807204310.117986-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).