From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A92643010; Wed, 9 Aug 2023 01:23:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B4BD40DDB; Wed, 9 Aug 2023 01:23:46 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 82E4E400D6 for ; Wed, 9 Aug 2023 01:23:44 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id D170720FC0D2; Tue, 8 Aug 2023 16:23:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D170720FC0D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1691537023; bh=gjVIE1Ftptu9BN31Fevc1bXIU7yR34mE6v4Y1rz5mlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RaQHz3zmBf6YsztCT0XgfxebIH2mpN4AeCBSwqyEdTxAKC64vOIzV+AHatu8jVM3v 7t/jgAmLYmX6uW/Tb3IEG+vcR2R7xF09j8vLGIOGP6RddgwcN9FL9/YOC803uqO4fo GrkaUmlZaAOQnrb41atuK7sexmwTKJVIJ9yCp/wc= Date: Tue, 8 Aug 2023 16:23:43 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH 00/20] remove experimental flag from some API's Message-ID: <20230808232343.GA27786@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230808173527.186042-1-stephen@networkplumber.org> <20230808181912.GA16722@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230808143352.79e8370e@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808143352.79e8370e@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 08, 2023 at 02:33:52PM -0700, Stephen Hemminger wrote: > On Tue, 8 Aug 2023 11:19:12 -0700 > Tyler Retzlaff wrote: > > > On Tue, Aug 08, 2023 at 10:35:07AM -0700, Stephen Hemminger wrote: > > > Since 23.11 is an LTS release it is time to remove the experimental > > > bandaid off many API's. There are about 850 API's marked with experimental > > > on current main branch. This addresses the easy to remove ones and > > > gets it down to about 690 places. > > > > > > The rule is any API that has been in since 22.11 needs to have > > > experimental removed (or deleted). The experimental flag is not a > > > "get out of ABI stability for free" card. > > > > For the libraries here that are enabled for Windows are the APIs being > > marked stable have real implementations or just stubs on Windows? > > > > If they are just stubs then i think more review is necessary for the > > stubbed APIs to understand that they *can* be implemented on Windows. > > > > I would prefer not to have to encounter this later and have to go > > through the overhead of deprecation like with rte_thread_ctrl_create > > again. > > > > This obviously doesn't apply to libraries that are not currently enabled > > for Windows. If the implementations aren't stubs then that's okay too. > > I don't see any stubs when looking. > > bpf: not built on Windows. Needs some libelf. > pdump: not built on Windows. Needs bpf for filtering > rte_tm: ok > rte_mtr: ok > cmdline: ok > pcapng: ok > net: ok > rcu: ok > lpm: ok > mbuf: ok > hash: ok > timer: ok > dmadev: ok > meter: ok > power: not on windows, probably need special API's > kvargs: ok > ip_frag: ok > member: not build on windows, not sure why > security: ok > vhost: not build on windows, not sure why > regexdev: not build on windows, not sure why > node: not build on windows, not sure why > > Changes to eal need to be more selective. Thanks Stephen I appreciate you checking it out it helps a lot. Series-acked-by: Tyler Retzlaff > >