From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84D6A43011; Wed, 9 Aug 2023 03:34:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAF8543266; Wed, 9 Aug 2023 03:33:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 161CB43268 for ; Wed, 9 Aug 2023 03:33:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691544818; x=1723080818; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QjtOLp0Oz/MvKJhJXxoDnTHTgfqnm+PZV+iY8fqEDCw=; b=JL0HbOW6/ueWeFI+Y+m+GtfOBQACwjQpmEnNoekhgXh7s9zF8YpQVcBt b0vn+x2LTjstec2pP1qHU18oEM5pN987uR0KlwjVPW6nSZfG1GEnVgztw H1VNmgwNSUWgxG5mqt47zdJYxvDutozZJtiZF8Db4izjvBOmwtlcLIZV9 U/ZJ/QdRwpbQO0CDYEKcdBWv3y3vBjzddQkkyLK9Qie1ZB3v18Z2No+pb VYSKDTkjPSuvP8aSqWCp62c3yfQWOW51D9hmtmYFbfLWADQWDWVOZlmoO EcZuKOBxjtsFW4wp3+t64MOxqeRE9PYpjs9lvTFf7OWO4zRF7bVXNvOk3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="374704479" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="374704479" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 18:33:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="845735104" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="845735104" Received: from dpdk-wenjing-02.sh.intel.com ([10.67.119.75]) by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2023 18:33:35 -0700 From: Wenjing Qiao To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Julianx Grajkowski Subject: [PATCH 06/14] common/idpf/base: add necessary check Date: Wed, 9 Aug 2023 01:33:00 +0000 Message-Id: <20230809013308.1449103-7-wenjing.qiao@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230809013308.1449103-1-wenjing.qiao@intel.com> References: <20230809013308.1449103-1-wenjing.qiao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Simei Su Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 3879b5a33f..7400692544 100644 --- a/.mailmap +++ b/.mailmap @@ -1643,3 +1643,4 @@ Zhenning Xiao Josh Hay Madhu Chittim Shailendra Bhatnagar +Julianx Grajkowski diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c index fbf71416fd..9610916aa9 100644 --- a/drivers/common/idpf/base/idpf_common.c +++ b/drivers/common/idpf/base/idpf_common.c @@ -239,8 +239,10 @@ int idpf_clean_arq_element(struct idpf_hw *hw, e->desc.ret_val = msg.status; e->desc.datalen = msg.data_len; if (msg.data_len > 0) { - if (!msg.ctx.indirect.payload) - return -EINVAL; + if (!msg.ctx.indirect.payload || !msg.ctx.indirect.payload->va || + !e->msg_buf) { + return -EFAULT; + } e->buf_len = msg.data_len; msg_data_len = msg.data_len; idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len, -- 2.34.1