From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EACD44301A; Wed, 9 Aug 2023 19:55:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EF1B40DDB; Wed, 9 Aug 2023 19:55:32 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 3EBA5400D6 for ; Wed, 9 Aug 2023 19:55:31 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 963B520FC4C7; Wed, 9 Aug 2023 10:55:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 963B520FC4C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1691603730; bh=6F0ZO07d7P+OGJgL2A5eXiQQvlsLzLaNQp0hf/xFmWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GwKj+cSxkDeY+QpUMyoiITDo56eAZy78yx9zzwfYxgbeNXrXQSAR1mlTy7II4vx0R IijtqEix1qOKBj17wusIbcsuawXYDIryDoXo/xBeU6WcWCPrTLK+ClrBOrEQyCk/qA L8C+IQWrQ5iv8PF14Wev1K6MqJ1XNj3q7eYE3jfA= Date: Wed, 9 Aug 2023 10:55:30 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH 14/15] eal: mark rte_eal_vfio_get_token stable Message-ID: <20230809175530.GD22800@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230809164312.308093-1-stephen@networkplumber.org> <20230809164312.308093-15-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809164312.308093-15-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 09, 2023 at 09:43:06AM -0700, Stephen Hemminger wrote: > This API was added in 20.08 release. > > Signed-off-by: Stephen Hemminger > --- there is driver work going on for similar functionality to vfio on windows. it's possible that this api could be exposed for windows but in the current form may not be suitable. *not blocking* just wanted to make you aware, i don't have a firm enough schedule to derail this process. > lib/eal/include/rte_eal.h | 4 ---- > lib/eal/version.map | 4 +--- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h > index 53c4a5519e61..aac57665e6c2 100644 > --- a/lib/eal/include/rte_eal.h > +++ b/lib/eal/include/rte_eal.h > @@ -412,16 +412,12 @@ int rte_eal_create_uio_dev(void); > enum rte_intr_mode rte_eal_vfio_intr_mode(void); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Copy the user-configured vfio VF token. > * > * @param vf_token > * vfio VF token configured with the command line is copied > * into this parameter, zero uuid by default. > */ > -__rte_experimental > void rte_eal_vfio_get_vf_token(rte_uuid_t vf_token); > > /** > diff --git a/lib/eal/version.map b/lib/eal/version.map > index 3b42d6e0e4c1..65435ae48696 100644 > --- a/lib/eal/version.map > +++ b/lib/eal/version.map > @@ -89,6 +89,7 @@ DPDK_24 { > rte_eal_tailq_lookup; > rte_eal_tailq_register; > rte_eal_using_phys_addrs; > + rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT > rte_eal_vfio_intr_mode; # WINDOWS_NO_EXPORT > rte_eal_wait_lcore; > rte_epoll_ctl; > @@ -396,9 +397,6 @@ EXPERIMENTAL { > rte_trace_regexp; # WINDOWS_NO_EXPORT > rte_trace_save; # WINDOWS_NO_EXPORT > > - # added in 20.08 > - rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT > - > # added in 20.11 > __rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT > rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT > -- > 2.39.2