From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0B6B43037;
	Fri, 11 Aug 2023 20:26:45 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AC4C340F17;
	Fri, 11 Aug 2023 20:26:45 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0D9BB40E03
 for <dev@dpdk.org>; Fri, 11 Aug 2023 20:26:44 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3984520FCD5D; Fri, 11 Aug 2023 11:26:43 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3984520FCD5D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1691778403;
 bh=NG9qex0jHxHNBDKceniYQL5TFHVE5lHM37XgXAPmsEs=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=ExFK84UkVxas7iYevGrRoNsD0ZHpG49ngLcXGV/UEIqQ64IZ0Pc8aSw6KOCN3SkBm
 y39ZoIB35zr8u9toGoMXKVIVnyptU95dYDDInRnpB3ekA4cWaZ+Cvs7nSkHkSCy/Va
 XMxsxmzKKrAi4yfKxg+9Uf9G5Ec3BkcCZIbS5xbk=
Date: Fri, 11 Aug 2023 11:26:43 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 david.marchand@redhat.com, thomas@monjalon.net
Subject: Re: [PATCH v4 3/4] build: limit what is built when using MSVC compiler
Message-ID: <20230811182643.GF20040@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com>
 <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com>
 <1691778287-15746-4-git-send-email-roretzla@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1691778287-15746-4-git-send-email-roretzla@linux.microsoft.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Aug 11, 2023 at 11:24:46AM -0700, Tyler Retzlaff wrote:
> Build only kvargs and telemetry when is_ms_compiler.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/meson.build       | 6 ++++--
>  drivers/meson.build   | 4 ++++
>  lib/meson.build       | 8 ++++++++
>  usertools/meson.build | 4 ++++
>  4 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index 4fc1a83..23a9d2e 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -1,6 +1,10 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017-2019 Intel Corporation
>  
> +if is_ms_compiler
> +    subdir_done()
> +endif
> +
>  disable_apps = ',' + get_option('disable_apps')
>  disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split()
>  
> @@ -38,8 +42,6 @@ if get_option('default_library') == 'static' and not is_windows
>      default_ldflags += ['-Wl,--export-dynamic']
>  endif
>  
> -enabled_apps = [] # used to print summary at the end
> -

oops, i shouldn't have removed this since David's patch removes it
already. please ignore this removal when reviewing.