From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD3BE43060; Mon, 14 Aug 2023 11:07:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FABE40A7F; Mon, 14 Aug 2023 11:07:39 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 707374021F for ; Mon, 14 Aug 2023 11:07:37 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4fe2d152f62so6579805e87.0 for ; Mon, 14 Aug 2023 02:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692004057; x=1692608857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dRB1ziCzWY69JAFv8JIoweGZOVtg2Pj+wTt7mf+bh8U=; b=RrjB1WmwJajXfpRmM8p6afhmI1Mw05BUhDP/EwjTbmI/+h5okOzS7cKveL2GmQFY1Y cvTeEmmdvRui8zOadIhj534NEREhIh8KsUlone5D7tWpyPx44CoqWV3Ux7uEkWqZX2Hl 9kT776ecfLCkb68hxxP4snAFAzDyCkOIJLgtaFYM89iuB5Tz2fH5FRa/hAMXSEvgKpXm BwfTlXAXJe/2aqj/bd9EpI8zb+t4AkhF40oFf0N8S6iSSx9dv9S9MGR6OCiPKaqcfSbP rt1j91cYlw3SDSjXJEsi47cmqL5slIkomPMlPggahYyjQcWBy2LZdm+qLy/uTXNp/ZjZ Z8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692004057; x=1692608857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRB1ziCzWY69JAFv8JIoweGZOVtg2Pj+wTt7mf+bh8U=; b=FlgISfvWdtwmDWj/JjkZ9Uoi6bmLMR75cBg8g8yaSlev22V+TG35TDxANU/gG11QzE 6FC7slSQK6RnRZOUO68Zr7rsSlX20pwSMQs8+LPtEv+xxgpvmVCDKHJzs+XvtXwKn43T JFlpVjShTtBj3WoDGc177N0tzkbVnXF+zeuhbIQFFz8QgTa45UUGvbdUUY9/PdkatBHJ VpAqsYaUmOVM/TW69ctHZYpYktR1CiXGJvbLNzXEB3nHN76zmutOwXal3PDlIxZqdCSl qJxoya+tb//Bbb94fyjRfj0yiNTGjVCw6mV1EzXPvv5cAi8C6fGty3nBLR7MHfYK1vWd Cj8g== X-Gm-Message-State: AOJu0Yyx58YvjVh1myV0uaPbH/kFqOvx2oSgzyDo9VM47tFwBRNwKzQH 8+mGLhIlulMn4MvXeMWht7o= X-Google-Smtp-Source: AGHT+IEr5aK4Pye/y7swgx4DSBnpMafvN0ckS+EUJ5cXSojnmdQ+mT1MmJuw4ER49YjYhNhVTYcqvQ== X-Received: by 2002:a19:f609:0:b0:4f4:b783:8556 with SMTP id x9-20020a19f609000000b004f4b7838556mr5114022lfe.66.1692004056645; Mon, 14 Aug 2023 02:07:36 -0700 (PDT) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id d10-20020ac241ca000000b004f4b42e2d7dsm1867281lfi.230.2023.08.14.02.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 02:07:36 -0700 (PDT) Date: Mon, 14 Aug 2023 12:07:34 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Tyler Retzlaff , , Konstantin Ananyev , , Subject: Re: [PATCH v4 1/4] build: unblock the use of the MSVC compiler Message-ID: <20230814120734.568741b4@sovereign> In-Reply-To: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2023-08-14 09:27 (UTC+0100), Bruce Richardson: > On Fri, Aug 11, 2023 at 11:24:44AM -0700, Tyler Retzlaff wrote: > > Detect when MSVC toolset is available and tweak toolchain arguments > > where the meson build system offers no abstraction. > > > > Signed-off-by: Tyler Retzlaff > > Acked-by: Bruce Richardson > > --- > > config/meson.build | 23 +++++++++++++++-------- > > config/x86/meson.build | 10 ++++++---- > > lib/meson.build | 13 ++++++++++--- > > 3 files changed, 31 insertions(+), 15 deletions(-) > > > > diff --git a/config/meson.build b/config/meson.build > > index d822371..b6c7d48 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -16,7 +16,8 @@ endforeach > > > > # MS linker requires special treatment. > > # TODO: use cc.get_linker_id() with Meson >= 0.54 > > -is_ms_linker = is_windows and (cc.get_id() == 'clang') > > +is_ms_compiler = is_windows and (cc.get_id() == 'msvc') > > +is_ms_linker = is_windows and (cc.get_id() == 'clang' or is_ms_compiler) > > Question out of interest, what other linker option do we have on windows? > When is the second part of this conditional false? MinGW: GCC + GNU ld (the second conditional is false) Clang: clang + link.exe MSVC: cl.exe + link.exe