From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 22A9E43064;
	Mon, 14 Aug 2023 18:10:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0D4E6410F1;
	Mon, 14 Aug 2023 18:10:56 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id E9A8140A7F
 for <dev@dpdk.org>; Mon, 14 Aug 2023 18:10:53 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1CED52106700; Mon, 14 Aug 2023 09:10:53 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1CED52106700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1692029453;
 bh=Qn/vYYDyWLaOdiNJZVU7G16Mguq/NNpxG5+UpJc0OD8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=DBqeEewDHPevsSUiYok7+eGt9fHoYpVzcTB7DiqVnsPKw5esu9FS1e6QPHQuNvJje
 qTjELnGa2eB9J2Iie2K/B0oD/59H2xIUV3/OY33TtIuAVhiHvaO21TlhEWwIvIKfnc
 1AgoJ6VciQ8yl5toPEHGOcWRjP12vrmKSwg01hZY=
Date: Mon, 14 Aug 2023 09:10:53 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 david.marchand@redhat.com, thomas@monjalon.net
Subject: Re: [PATCH v4 4/4] build: enable MSVC specific compiler options
Message-ID: <20230814161053.GA10752@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com>
 <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com>
 <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com>
 <ZNnmHH2kCxkruTkT@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNnmHH2kCxkruTkT@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Aug 14, 2023 at 09:30:20AM +0100, Bruce Richardson wrote:
> On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff wrote:
> > * Enable optional use of C11 atomics support.
> > * Enable use of C23 typeof operator.
> > * Explicitly force intrinsics when building with MSVC.
> > * Disable MSVC C runtime checks.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> If there is going to be a lot of this type of special handling for MSVC, we
> could look to add a separate config/msvc (and config/gcc-like) directory
> with separate meson.build files for the different toolchains. Might help
> centralize all such definitions in one place rather than having
> conditionals everywhere.

i think that would probably be a good idea. it would untangle the
toolchain detail from the flow of the build files.

i don't propose introducing it in this series but when this is merged
i would like to reach out and get your thoughts on how to properly set
up a config/toolchain-xxx. in addition to the compiler flags and
definitions below it would be good to suppress (for now) warnings until
i have an opportunity to evaluate and address the code raising them.