From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 197B24309A; Fri, 18 Aug 2023 18:10:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3C2640ED9; Fri, 18 Aug 2023 18:10:56 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 33C8E40395 for ; Fri, 18 Aug 2023 18:10:55 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1bc8a2f71eeso8464015ad.0 for ; Fri, 18 Aug 2023 09:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692375054; x=1692979854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6qkMxBoABM8TahCW7TzQWTJO+7zM9v54dRMoKCAig/w=; b=YlF8jnYA2/a6mvM+8hFwYgdZ1bJ1bXfjsqjVuPg+me25oVtVweebTQ6U1iWV0DhLmH 1vdG9wvkg6OWeS0/czO316bKCm/2vYIHdn8tY7dqar/6vmSqAQQmQYFyBGOm4AwXAZt0 lfHSabS5Gs71JfWU1OW+BmdLArq/AkVmI4zffblTisEwuQtcf7gRcXDRCMByFWmjP34D nlDONU3sx7mTi6zbYYFE2gUl1pQ314ZBIpaKqDiktaV7Eua5RG9jCrHg9EyWQUD/3A5W pmbbER/wFV7AeIaxdcP3sVLe2b48ErM8Ja2Va/IJLt82Gk7kIrJGSNPvXHWMsyf7AIt9 zsGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692375054; x=1692979854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qkMxBoABM8TahCW7TzQWTJO+7zM9v54dRMoKCAig/w=; b=U7peqRBf6xrRn0XyT7MHkkFjhGFeu/EM5WB3sxPBYeoV/ryW4pmT+bQreaD0dgRzth 4gIUo9zyqdfcOuk55Un5vOwXY+BanSLKLu0MmjRWFTA/uV3I7Yjr7UAC4ZU4akQLhBUq DL9zpAZDvVq6OO06l86ue+XrlN0tvicZvpdi/CYXoXehAn8I465E1xLpz9nmszdDsVSf SA1McGjW+oPgwdur3bkfetb/dVjaMB9ZuVjJeDbjf8f2CZKNqcvqu4PSpKCn1XHzhSdA Hna8wt5y5acqoasdU8pWH0dlCHPBBOSaep/i6B32Uljj/PWJw6io8YNpmumHPTpyKJA0 Tqjg== X-Gm-Message-State: AOJu0Yys99Lj7gx8Cm05AdArFw1NA435rbQaIimnPtZE1bYAV1lOT1GJ 6Idfxt8JP+e01yTrPwEhIS8aaA== X-Google-Smtp-Source: AGHT+IHAqD732tt9lEiBpK4uf/eGA8NcIcx4EEXC1d0IzOk1uT8q837zLR7yVAzD0pXYX0/Sqo912A== X-Received: by 2002:a17:903:32cb:b0:1bc:921c:eb48 with SMTP id i11-20020a17090332cb00b001bc921ceb48mr3297333plr.34.1692375054137; Fri, 18 Aug 2023 09:10:54 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id x4-20020a1709029a4400b001bde877a7casm1938804plv.264.2023.08.18.09.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 09:10:53 -0700 (PDT) Date: Fri, 18 Aug 2023 09:10:51 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Subject: Re: [PATCH 01/14] jobstats: change jobstats_abort to jobstats_cancel Message-ID: <20230818091051.3f2b95d1@hermes.local> In-Reply-To: References: <20230818025249.33994-1-stephen@networkplumber.org> <20230818025249.33994-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Aug 2023 10:08:58 +0100 Bruce Richardson wrote: > On Thu, Aug 17, 2023 at 07:52:36PM -0700, Stephen Hemminger wrote: > > The term abort is on the "Replace now" list of words. > > Use cancel instead. > > > I see cancel generally being used as a replacement throughout this > patchset, but I wonder if the use of th term could be confusing as it > doesn't strictly match the term "abort" at least to my mind. > > When an operation is aborted, (to me anyway) it generally means that the > operation is just stopped at whatever point it is at, and nothing more is > done. However, when an operation is cancelled, that would imply to me that > the operation is not only stopped, but whatever tasks were already done by > that operation are undone. Would others share this understanding? If so, we > should make the rollback/no-rollback behaviour clear. > > /Bruce It seemed like the best of the alternatives proposed here: https://inclusivenaming.org/word-lists/tier-1/abort/ Recommended Replacements User-Initiated Termination Force quit Cancel System-Initiated Termination Fail Close (app, program, connection) End Halt Hard stop Stop (something you triggered) I don't think the rollback semantics are implied by either word. They should be spelled out more though.