From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD899430C3; Mon, 21 Aug 2023 18:09:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 305ED42BC9; Mon, 21 Aug 2023 18:09:35 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id CD1F042B8B for ; Mon, 21 Aug 2023 18:09:33 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1bdcb800594so20317085ad.1 for ; Mon, 21 Aug 2023 09:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692634172; x=1693238972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a1bd7k8ZCfJuVL6R0KJfIW6E2XlWOLD2J4mfa1dq7bA=; b=MOQuRidp0KPXI+Dnq4OtLR/09j8+WtrdfTzkRaP7+zpFSG0TmZBrpKkM0OB8ve4dzA 8w19QF7t4qqp0+5tW9MYBpiYw2ch+Zj/nXxXruAElGAa9AF96x6IPXayABSzKehf+pu+ 8OTyMuNf+6BdXwiBJKezRj83QRLQZwW6fsrPOl7oTonn20V8CREELKAkHPoWgO2djXYR hVnLlC59hwgW2+r66AOcX/2a92lSxJHjzplP8lEYiz8vystqaavkfIQBmdecJBX9Xfg7 dGe571FsWvFgnN4GBtfwe6ZtSFceP+wMbrA3+pn1YOR94FnO7Swy0CfD2LES2GXOWZuN Apiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692634172; x=1693238972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a1bd7k8ZCfJuVL6R0KJfIW6E2XlWOLD2J4mfa1dq7bA=; b=kj0qkAjUiu1BTWOapdHYnyba3iK19brKdDYBeggk7z8cC8UlsyMWSn8pA8DrjpDtGd Jp5OkoHaX23zq0gVEzdfq4IXJeuDo6Fow/dNCmTgdzqSgq4ZYuEeN1W5Q94rnbufqXS3 eRpQPHo5eAOnU0N/lbZH2ITk+6pGTlnJog+UbW2GNAN/p50aYbvi2lMrLu8ORWwYxZAI /VnFOWgEPlqB+JnpOsTg3sB4CRzyVIchR3FtOk8MxVyv5S9GmaZSJ5wtR98JVgnBQKIq LnaXaWAnMIMou7HPo7TsjQFRXv1HgcmhZ3awX3+7WdDy75O5F6HpT5TCwAln4KP4C3t+ 4bGA== X-Gm-Message-State: AOJu0YzYr5/ksTcjPlinbMHIV5fpzZNTrt/oIQWJemZiRNT2iZrmdy2Y vF09U8zqEU1LEfEfPojExfA0ZXhQgtVKWt2+t7xmVv0M X-Google-Smtp-Source: AGHT+IFBKulWUuDAUCi1Sh0F/VwZhEhIAAUQ0w1f+7pIgoGzCVbZUei+7c8tVydLdCFLG38MnWvCCA== X-Received: by 2002:a17:903:2346:b0:1bb:a941:d940 with SMTP id c6-20020a170903234600b001bba941d940mr5302762plh.15.1692634172273; Mon, 21 Aug 2023 09:09:32 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id i1-20020a17090332c100b001bf2dcfe352sm7208159plr.234.2023.08.21.09.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 09:09:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v13 00/21] Convert static log types in libraries to dynamic types Date: Mon, 21 Aug 2023 09:09:00 -0700 Message-Id: <20230821160921.383832-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230329234049.11071-1-stephen@networkplumber.org> References: <20230329234049.11071-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset removes most of the uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there is no guarantee in current DPDK policies that says they can't be removed. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v13 - rebase because log now moved. v12 - rebase and add table and pipeline libraries v11 - fix include check on arm cross build v10 - add necessary rte_compat.h in thash_gfni stub for arm v9 - fix handling of crc32 alg in lib/hash. make it an internal global variable. fix gfni stubs for case where they are not used. Stephen Hemminger (21): gso: don't log message on non TCP/UDP eal: drop no longer used GSO logtype log: drop unused RTE_LOGTYPE_TIMER efd: convert RTE_LOGTYPE_EFD to dynamic type mbuf: convert RTE_LOGTYPE_MBUF to dynamic type acl: convert RTE_LOGTYPE_ACL to dynamic type examples/power: replace use of RTE_LOGTYPE_POWER examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER power: convert RTE_LOGTYPE_POWER to dynamic type ring: convert RTE_LOGTYPE_RING to dynamic type mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type lpm: convert RTE_LOGTYPE_LPM to dynamic types sched: convert RTE_LOGTYPE_SCHED to dynamic type examples/ipsec-secgw: replace RTE_LOGTYPE_PORT port: convert RTE_LOGTYPE_PORT to dynamic type hash: move rte_thash_gfni stubs out of header file hash: move rte_hash_set_alg out header hash: convert RTE_LOGTYPE_HASH to dynamic type table: convert RTE_LOGTYPE_TABLE to dynamic type app/test: remove use of RTE_LOGTYPE_PIPELINE pipeline: convert RTE_LOGTYPE_PIPELINE to dynamic type app/test/test_acl.c | 2 +- app/test/test_table_acl.c | 50 +++++++++++------------- app/test/test_table_pipeline.c | 40 +++++++++---------- examples/distributor/main.c | 2 +- examples/ipsec-secgw/sa.c | 6 +-- examples/l3fwd-power/main.c | 17 +++++---- lib/acl/acl.h | 1 + lib/acl/acl_bld.c | 3 ++ lib/acl/acl_gen.c | 1 + lib/acl/acl_log.h | 6 +++ lib/acl/rte_acl.c | 3 ++ lib/acl/tb_mem.c | 3 +- lib/efd/rte_efd.c | 4 ++ lib/fib/fib_log.h | 4 ++ lib/fib/rte_fib.c | 3 ++ lib/fib/rte_fib6.c | 2 + lib/gso/rte_gso.c | 4 +- lib/gso/rte_gso.h | 1 + lib/hash/meson.build | 9 ++++- lib/hash/rte_crc_arm64.h | 8 ++-- lib/hash/rte_crc_x86.h | 10 ++--- lib/hash/rte_cuckoo_hash.c | 5 +++ lib/hash/rte_fbk_hash.c | 5 +++ lib/hash/rte_hash_crc.c | 68 +++++++++++++++++++++++++++++++++ lib/hash/rte_hash_crc.h | 48 ++--------------------- lib/hash/rte_thash.c | 3 ++ lib/hash/rte_thash_gfni.c | 50 ++++++++++++++++++++++++ lib/hash/rte_thash_gfni.h | 30 +++++---------- lib/hash/version.map | 11 ++++++ lib/log/log.c | 16 -------- lib/log/rte_log.h | 32 ++++++++-------- lib/lpm/lpm_log.h | 4 ++ lib/lpm/rte_lpm.c | 3 ++ lib/lpm/rte_lpm6.c | 1 + lib/mbuf/mbuf_log.h | 4 ++ lib/mbuf/rte_mbuf.c | 4 ++ lib/mbuf/rte_mbuf_dyn.c | 2 + lib/mbuf/rte_mbuf_pool_ops.c | 2 + lib/mempool/rte_mempool.c | 2 + lib/mempool/rte_mempool.h | 8 ++++ lib/mempool/version.map | 3 ++ lib/pipeline/rte_pipeline.c | 2 + lib/pipeline/rte_pipeline.h | 5 +++ lib/port/rte_port_ethdev.c | 3 ++ lib/port/rte_port_eventdev.c | 4 ++ lib/port/rte_port_fd.c | 3 ++ lib/port/rte_port_frag.c | 3 ++ lib/port/rte_port_ras.c | 3 ++ lib/port/rte_port_ring.c | 3 ++ lib/port/rte_port_sched.c | 3 ++ lib/port/rte_port_source_sink.c | 3 ++ lib/port/rte_port_sym_crypto.c | 3 ++ lib/power/guest_channel.c | 3 +- lib/power/power_common.c | 2 + lib/power/power_common.h | 2 + lib/power/power_kvm_vm.c | 1 + lib/power/rte_power.c | 1 + lib/rib/rib_log.h | 4 ++ lib/rib/rte_rib.c | 3 ++ lib/rib/rte_rib6.c | 3 ++ lib/ring/rte_ring.c | 3 ++ lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 +++ lib/sched/rte_sched_log.h | 4 ++ lib/table/meson.build | 1 + lib/table/rte_table.c | 8 ++++ lib/table/rte_table.h | 4 ++ 67 files changed, 387 insertions(+), 173 deletions(-) create mode 100644 lib/acl/acl_log.h create mode 100644 lib/fib/fib_log.h create mode 100644 lib/hash/rte_hash_crc.c create mode 100644 lib/hash/rte_thash_gfni.c create mode 100644 lib/lpm/lpm_log.h create mode 100644 lib/mbuf/mbuf_log.h create mode 100644 lib/rib/rib_log.h create mode 100644 lib/sched/rte_sched_log.h create mode 100644 lib/table/rte_table.c -- 2.39.2