From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
viacheslavo@nvidia.com, Matan Azrad <matan@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>
Subject: [PATCH v3] common/mlx5: replace use of PMD logtype
Date: Mon, 21 Aug 2023 09:16:25 -0700 [thread overview]
Message-ID: <20230821161625.413827-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20230223174127.189231-1-stephen@networkplumber.org>
The goal to eliminate the generic PMD logtype.
One place it is used unnecessarily is in the mlx5 common code.
Change the one RTE_LOG() call here to use the same macro
as other log messages in same file.
Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
Cc: viacheslavo@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v3 - also address use in glue code
drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c
index 2ebb8ac8b6e5..7260c1a19fd3 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.c
+++ b/drivers/common/mlx5/linux/mlx5_common_os.c
@@ -266,7 +266,7 @@ mlx5_glue_path(char *buf, size_t size)
goto error;
return buf;
error:
- RTE_LOG(ERR, PMD, "unable to append \"-glue\" to last component of"
+ DRV_LOG(ERR, "unable to append \"-glue\" to last component of"
" RTE_EAL_PMD_PATH (\"" RTE_EAL_PMD_PATH "\"), please"
" re-configure DPDK");
return NULL;
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 66a77159a031..9db0b2ac8983 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
- RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities");
+ DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
vdpa_attr->valid = 0;
} else {
vdpa_attr->valid = 1;
--
2.39.2
next prev parent reply other threads:[~2023-08-21 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 17:41 [PATCH] " Stephen Hemminger
2023-03-06 13:19 ` Slava Ovsiienko
2023-06-13 14:18 ` David Marchand
2023-08-21 14:32 ` [PATCH v2] " Stephen Hemminger
2023-08-21 16:16 ` Stephen Hemminger [this message]
2023-08-21 16:25 ` [PATCH v3] " Tyler Retzlaff
2023-09-25 7:17 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821161625.413827-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).