* [PATCH] build: add pdcp to optional libs
@ 2023-08-25 14:18 Bruce Richardson
2023-08-25 16:05 ` Tyler Retzlaff
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-08-25 14:18 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
The pdcp library is disabled when its dependent library "reorder" is not
being built.
../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
As such, it is not a mandatory library, and can be marked as safe to
disable.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/meson.build b/lib/meson.build
index 53155be8e9..c1602e818a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -96,6 +96,7 @@ optional_libs = [
'mldev',
'node',
'pcapng',
+ 'pdcp',
'pdump',
'pipeline',
'port',
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] build: add pdcp to optional libs
2023-08-25 14:18 [PATCH] build: add pdcp to optional libs Bruce Richardson
@ 2023-08-25 16:05 ` Tyler Retzlaff
2023-08-28 9:31 ` David Marchand
2023-08-29 8:03 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2023-08-25 16:05 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Fri, Aug 25, 2023 at 03:18:54PM +0100, Bruce Richardson wrote:
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: add pdcp to optional libs
2023-08-25 14:18 [PATCH] build: add pdcp to optional libs Bruce Richardson
2023-08-25 16:05 ` Tyler Retzlaff
@ 2023-08-28 9:31 ` David Marchand
2023-08-29 8:03 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-08-28 9:31 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: add pdcp to optional libs
2023-08-25 14:18 [PATCH] build: add pdcp to optional libs Bruce Richardson
2023-08-25 16:05 ` Tyler Retzlaff
2023-08-28 9:31 ` David Marchand
@ 2023-08-29 8:03 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-08-29 8:03 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Tyler Retzlaff, David Marchand
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-29 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-25 14:18 [PATCH] build: add pdcp to optional libs Bruce Richardson
2023-08-25 16:05 ` Tyler Retzlaff
2023-08-28 9:31 ` David Marchand
2023-08-29 8:03 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).