From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3FAFD43102;
	Fri, 25 Aug 2023 18:14:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0774E40A7A;
	Fri, 25 Aug 2023 18:14:32 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id CB310400D5
 for <dev@dpdk.org>; Fri, 25 Aug 2023 18:14:29 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 248482127C94; Fri, 25 Aug 2023 09:14:29 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 248482127C94
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1692980069;
 bh=qFunsHtE3N/ZIn+u2QABHj8M0kVevB3nayXoEuOCf+A=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=KKwz6HDHatgJuQy0VNgHHQXHxb6qowyjZ9qV8hGVgUG8Hk7TIcVmyBdV8C41iFW32
 IGpCb4PVQZHRQzyavW4veXo5ZLVqiogXtFZDQfi5Sk93gY33iOrUiZoRl4vcTmeBtn
 Qw6NCuLTGNdMFlB3y1TVGFbFYzUtyAzRjIctAv+I=
Date: Fri, 25 Aug 2023 09:14:29 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Ruifeng Wang <ruifeng.wang@arm.com>,
 David Christensen <drc@linux.vnet.ibm.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] remove wrappers for GCC < 4.8
Message-ID: <20230825161429.GB18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230824083034.806773-1-david.marchand@redhat.com>
 <CAJFAV8xY+2Fv3kViAGLw_5uzGDMhH1TSXaOR9i4DfQcDVNZS3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8xY+2Fv3kViAGLw_5uzGDMhH1TSXaOR9i4DfQcDVNZS3A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Aug 24, 2023 at 10:52:04AM +0200, David Marchand wrote:
> Hello Tyler,
> 
> On Thu, Aug 24, 2023 at 10:30 AM David Marchand
> <david.marchand@redhat.com> wrote:
> > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h
> > index 2c4b94a7c9..74593cd4d4 100644
> > --- a/lib/eal/include/rte_debug.h
> > +++ b/lib/eal/include/rte_debug.h
> > @@ -60,11 +60,7 @@ void rte_dump_stack(void);
> >   * documentation.
> >   */
> >  void __rte_panic(const char *funcname , const char *format, ...)
> > -#ifdef __GNUC__
> > -#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2))
> >         __rte_cold
> > -#endif
> > -#endif
> 
> I don't see some wrapping around __rte_cold for MSVC in your series.
> Would this patch break MSVC buidlds?

If it gets expanded on MSVC probably. But don't let it stop you from
applying this series. You can just expand it empty if you want.

Until the atomics series is merged msvc still won't build so I'll supply
minor fixes as these things pop up.

Once everything is staged I'll work with UNH to get a basic build CI
going to reduce the overhead of worrying about this kind of change being
breaking.

> 
> >         __rte_noreturn
> >         __rte_format_printf(2, 3);
> >
> 
> 
> -- 
> David Marchand