From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE3B743102; Fri, 25 Aug 2023 18:35:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 887A440A7A; Fri, 25 Aug 2023 18:35:38 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A158C400D5 for ; Fri, 25 Aug 2023 18:35:36 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id CE41A2127C94; Fri, 25 Aug 2023 09:35:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CE41A2127C94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1692981335; bh=B6Lbq/uI1bA1VOxBarn6DBfYqqgru62eoRw926U8ilw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RO2sKXj0O39KmGoPll3cDiQJM+QXP3a7MGHnMu28g0bTFw9es2OzRxg4z4cvyLmA0 3ncPugGZ8+xHY3uGTJkF5k5kt2cS6WYAt6NJRsOAw4xlwkEs5cEz4qGZIkdRAcinEr tN0BFjrf0rycfVHlGy8MGtQE+eH8F+7haGUYKc3w= Date: Fri, 25 Aug 2023 09:35:35 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, Reshma Pattan , Vladimir Medvedkin , Cristian Dumitrescu , Aman Singh , Yuying Zhang , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Beilei Xing , Kai Ji , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Timothy McDaniel , Harry van Haaren , Srikanth Yalavarthi , Somnath Kotur , Rahul Lakkireddy , Qi Zhang , Xiao Wang , Dongdong Liu , Yisen Zhuang , David Christensen , Qiming Yang , Ruifeng Wang , Wenjun Wu , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Liron Himi , Long Li , Maxime Coquelin , Chenbo Xia , Nicolas Chautru , Brian Dooley , Gowrishankar Muthukrishnan , Chengwen Feng , Kevin Laatz , Anatoly Burakov , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Yipeng Wang , Sameh Gobriel Subject: Re: [PATCH 1/2] use abstracted bit count functions Message-ID: <20230825163535.GC18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230825101812.2396339-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825101812.2396339-1-david.marchand@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 25, 2023 at 12:18:10PM +0200, David Marchand wrote: > Now that DPDK provides such bit count functions, make use of them. > > This patch was prepared with a "brutal" commandline: > > $ old=__builtin_clzll; new=rte_clz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_clz; new=rte_clz32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > $ old=__builtin_ctzll; new=rte_ctz64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_ctz; new=rte_ctz32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > $ old=__builtin_popcountll; new=rte_popcount64; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > $ old=__builtin_popcount; new=rte_popcount32; > git grep -lw $old :^lib/eal/include/rte_bitops.h | > xargs sed -i -e "s#\<$old\>#$new#g" > > Then inclusion of rte_bitops.h was added were necessary. > > Signed-off-by: David Marchand > --- These kinds of patches always make me dizzy, I did a pass I cannot see any replacement problems so lgtm. Acked-by: Tyler Retzlaff