DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Artemy Kovalyov <artemyko@nvidia.com>
Cc: dev@dpdk.org, "Thomas Monjalon" <thomas@monjalon.net>,
	"Ophir Munk" <ophirmu@nvidia.com>,
	stable@dpdk.org, "Anatoly Burakov" <anatoly.burakov@intel.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] eal: fix memory initialization deadlock
Date: Wed, 30 Aug 2023 22:13:26 +0300	[thread overview]
Message-ID: <20230830221326.7b9f1289@sovereign> (raw)
In-Reply-To: <20230830103303.2428995-1-artemyko@nvidia.com>

2023-08-30 13:33 (UTC+0300), Artemy Kovalyov:
> Following these changes, the RW-lock no longer supports
> recursion, implying that a single thread shouldn't obtain a read lock if
> it already possesses one. The problem arises during initialization: the
> rte_eal_init() function acquires the memory_hotplug_lock, and later on,
> the sequence of calls rte_eal_memory_init() -> eal_memalloc_init() ->
> rte_memseg_list_walk() acquires it again without releasing it. This
> scenario introduces the risk of a potential deadlock when concurrent
> write locks are applied to the same memory_hotplug_lock. To address this
> we resolved the issue by replacing rte_memseg_list_walk() with
> rte_memseg_list_walk_thread_unsafe().

There is another call to rte_memseg_list_walk() during initialization:
from eal_dynmem_hugepage_init(), please address it too.

  reply	other threads:[~2023-08-30 19:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 10:33 Artemy Kovalyov
2023-08-30 19:13 ` Dmitry Kozlyuk [this message]
2023-09-04  8:24 ` [PATCH v2] " Artemy Kovalyov
2023-09-05  7:05   ` Dmitry Kozlyuk
2023-09-05  9:05     ` Artemy Kovalyov
2023-09-05 10:15       ` David Marchand
2023-09-06  9:52 ` [PATCH v3] " Artemy Kovalyov
2023-09-06 12:52   ` David Marchand
2023-09-08 13:17 ` [PATCH v4 0/2] " Artemy Kovalyov
2023-09-08 13:17   ` [PATCH v4 1/2] eal: " Artemy Kovalyov
2023-09-08 13:17   ` [PATCH v4 2/2] eal: annotate rte_memseg_list_walk() Artemy Kovalyov
2023-10-06 10:12     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230830221326.7b9f1289@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=artemyko@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=ophirmu@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).