From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8EC742217; Fri, 1 Sep 2023 01:06:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7944940298; Fri, 1 Sep 2023 01:06:55 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 90D6A4014F for ; Fri, 1 Sep 2023 01:06:53 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 8AD22212A78D; Thu, 31 Aug 2023 16:06:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8AD22212A78D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1693523212; bh=oWuaL4aDWCwO8ZvpWsNSdvmN/6fr9mKYQPebEL8N6r0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L4NwokighgJ3cKkCb5SfXnC5HtEbjkQDtYLnQem7CDONWqagD5Wbq0eI2EuCnc9ce TGx5euinZPWbH0MAwOv4ki6sVZCo53/NDTEk6dttWEfwEFvWrbIOcfVzkXGQDptPLL QJ5RjRYrs8RbcOB8jf1zQ3LrMUjwx7l1b1Mr9rqw= Date: Thu, 31 Aug 2023 16:06:52 -0700 From: Tyler Retzlaff To: Ali Alnubani Cc: David Marchand , "dev@dpdk.org" , Bruce Richardson , Konstantin Ananyev , Ciara Power , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "mb@smartsharesystems.com" Subject: Re: [PATCH v11 01/16] eal: use rdtsc intrinsic Message-ID: <20230831230652.GA31504@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1691781658-32520-1-git-send-email-roretzla@linux.microsoft.com> <1691781658-32520-2-git-send-email-roretzla@linux.microsoft.com> <20230829161628.GB19416@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 30, 2023 at 04:29:07PM +0000, Ali Alnubani wrote: > > -----Original Message----- > > From: Ali Alnubani > > Sent: Wednesday, August 30, 2023 6:49 PM > > To: 'Tyler Retzlaff' > > Cc: 'David Marchand' ; 'dev@dpdk.org' > > ; 'Bruce Richardson' ; > > 'Konstantin Ananyev' ; 'Ciara Power' > > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; 'mb@smartsharesystems.com' > > > > Subject: RE: [PATCH v11 01/16] eal: use rdtsc intrinsic > > > > > -----Original Message----- > > > From: Ali Alnubani > > > Sent: Wednesday, August 30, 2023 4:38 PM > > > To: Tyler Retzlaff > > > Cc: David Marchand ; dev@dpdk.org; Bruce > > > Richardson ; Konstantin Ananyev > > > ; Ciara Power ; > > > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > > > mb@smartsharesystems.com > > > Subject: RE: [PATCH v11 01/16] eal: use rdtsc intrinsic > > > > > > > -----Original Message----- > > > > From: Tyler Retzlaff > > > > Sent: Tuesday, August 29, 2023 7:16 PM > > > > To: Ali Alnubani > > > > Cc: David Marchand ; dev@dpdk.org; > > Bruce > > > > Richardson ; Konstantin Ananyev > > > > ; Ciara Power > > ; > > > > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > > > > mb@smartsharesystems.com > > > > Subject: Re: [PATCH v11 01/16] eal: use rdtsc intrinsic > > > > > > > > On Sat, Aug 26, 2023 at 02:38:26PM +0000, Ali Alnubani wrote: > > > > > > -----Original Message----- > > > > > > From: Tyler Retzlaff > > > > > > Sent: Friday, August 11, 2023 10:21 PM > > > > > > To: dev@dpdk.org > > > > > > Cc: Bruce Richardson ; Konstantin > > > Ananyev > > > > > > ; Ciara Power > > > > ; > > > > > > NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; > > > > > > david.marchand@redhat.com; mb@smartsharesystems.com; Tyler > > > > Retzlaff > > > > > > > > > > > > Subject: [PATCH v11 01/16] eal: use rdtsc intrinsic > > > > > > > > > > > > Inline assembly is not supported for MSVC x64. Convert code to use > > > > > > __rdtsc intrinsic. > > > > > > > > > > > > Signed-off-by: Tyler Retzlaff > > > > > > Acked-by: Konstantin Ananyev > > > > > > Acked-by: Morten Brørup > > > > > > --- > > > > > > > > > > Hello, > > > > > > > > > > This patch is causing a build failure in Windows with Clang 11: > > > > > > > > Hi Ali, > > > > > > > > while we don't currently document a minimum clang version required to > > > > build the windows port i'm starting to consider establishing policy that > > > > in effect says we may bump the required compiler version on any dpdk > > > > release (not just long term servicing releases). but before doing that > > > > it would be nice to understand if that would cause undue pain on the > > > > port users. > > > > > > > > So is there a reason you can't use LLVM 16? > > > > > > No specific reason. I reported this because compilation was passing with > > Clang > > > 11 prior to this patch. > > > > > > > Building with clang version 16.0.6 fails for me with: > > > > [..] > > [405/803] Linking target lib/rte_eal-24.dll > > FAILED: lib/rte_eal-24.dll > > "clang" @lib/rte_eal-24.dll.rsp > > clang: error: no such file or directory: 'librte_log.lib' > > clang: error: no such file or directory: 'librte_kvargs.lib' > > [406/803] Compiling C object > > lib/librte_mempool.a.p/mempool_rte_mempool_ops_default.c.obj > > [..] > > This build failure was actually caused by upgrading Meson from 0.54.3 to 1.2.1 earlier on the environment. > The build passes with Meson 0.54.3 and Clang 16.0.6. yes, the windows build is very sensitive to meson version. i only test with 0.57.0 i have not had time to investigate why newer versions do not work.