From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F308442217;
	Fri,  1 Sep 2023 01:08:15 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DFE2740298;
	Fri,  1 Sep 2023 01:08:15 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id ACD4A4014F
 for <dev@dpdk.org>; Fri,  1 Sep 2023 01:08:13 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 0A6EB212A78D; Thu, 31 Aug 2023 16:08:13 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0A6EB212A78D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1693523293;
 bh=OucpH5Eh01DoixZD4DggVj0mP+vwjnhrGCWMJvJY/z8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Ah4haFBmhhSNlYknDkok/HV+XDipKEiFcciAIJfYNjoIAHmftYkJD5EGxHPrjY2QH
 uMK4IxXESApGdu23sc1x9qcuGRPXg8g3JYP54tqgTK3d+QzNuQm2Fs7olhfWMHB6CL
 J6RhfDAdFem0CbQlZZQv/i+fxKQpsDAfSuQ3dxQ0=
Date: Thu, 31 Aug 2023 16:08:13 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
 Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] eal: provide per lcore macros for MSVC
Message-ID: <20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1689024585-17303-1-git-send-email-roretzla@linux.microsoft.com>
 <1689090747-5331-1-git-send-email-roretzla@linux.microsoft.com>
 <1689090747-5331-2-git-send-email-roretzla@linux.microsoft.com>
 <2619168.k3LOHGUjKi@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2619168.k3LOHGUjKi@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Aug 31, 2023 at 01:57:36PM +0200, Thomas Monjalon wrote:
> 11/07/2023 17:52, Tyler Retzlaff:
> > +#ifdef RTE_TOOLCHAIN_MSVC
> >  /**
> >   * Macro to define a per lcore variable "var" of type "type", don't
> >   * use keywords like "static" or "volatile" in type, just prefix the
> >   * whole macro.
> >   */
> >  #define RTE_DEFINE_PER_LCORE(type, name)			\
> > -	__thread __typeof__(type) per_lcore_##name
> > +	__declspec(thread) typeof(type) per_lcore_##name
> >  
> >  /**
> >   * Macro to declare an extern per lcore variable "var" of type "type"
> >   */
> >  #define RTE_DECLARE_PER_LCORE(type, name)			\
> > +	extern __declspec(thread) typeof(type) per_lcore_##name
> > +#else
> > +#define RTE_DEFINE_PER_LCORE(type, name)			\
> > +	__thread __typeof__(type) per_lcore_##name
> > +
> > +#define RTE_DECLARE_PER_LCORE(type, name)			\
> >  	extern __thread __typeof__(type) per_lcore_##name
> > +#endif
> 
> I'm afraid you damaged the doxygen document here.
> Please check what happens when generating doxygen.
> I suppose it does not take the RTE_TOOLCHAIN_MSVC path,
> so it does not find any comment.

Thanks Thomas i will look into fixing it.

> 
>