From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0C544253E; Fri, 8 Sep 2023 06:26:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB33940285; Fri, 8 Sep 2023 06:26:30 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8523E40042 for ; Fri, 8 Sep 2023 06:26:28 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id DC719212B5D2; Thu, 7 Sep 2023 21:26:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DC719212B5D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1694147187; bh=9UUIQ9mgI5lQgHBc7Kp/E69JpbDAbNpDsCQH2alInLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQpzMEy3BIK8NFBVfvhoFDa1oqLgXAWHKYjLdXszE4eFVdTj8g3+eRMdAGbkorsOJ B47W10cbhhxrfB4Hzn0YrLbubTDbXTuOattz/S3uOr8zv6LRPzENLRRmbKfbgfN9k1 nTgT2VqJEVfsuk5w/iNV7F3tEfYA4kBeEvd3DqAI= Date: Thu, 7 Sep 2023 21:26:27 -0700 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: Thomas Monjalon , dev@dpdk.org, David Marchand , Ferruh Yigit Subject: Re: [PATCH 00/11] rework thread management Message-ID: <20230908042627.GH7692@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230906162226.1618088-1-thomas@monjalon.net> <98CBD80474FA8B44BF855DF32C47DC35D87B81@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B81@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 07, 2023 at 10:30:59AM +0200, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, 6 September 2023 18.12 > > > > The main effect of this patch series is to > > remove calls to pthread functions except for pthread_cancel and locks. > > > > The function rte_thread_create_control() does not take attributes anymore > > as it looks a useless complication of the API. > > Note for other reviewers: The "args" parameter, passed to the thread function, is still there. > > > Then the rte_thread API is made stable, > > so we can remove the old deprecated functions > > rte_thread_setname() and rte_ctrl_thread_create(). > > > > Some new internal functions are added in rte_thread to make sure > > all internal thread names are prefixed with "dpdk-". > > > > Few other cleanups are done. > > > > Future work about pthread portability are about: > > - cancel > > - mutex > > > > > > Thomas Monjalon (11): > > devtools: warn when adding some pthread calls > > eal: rename thread name length definition > > eal: remove attributes from control thread creation > > eal: promote thread API as stable > > eal: force prefix for internal threads > > lib: convert to internal control threads > > drivers: convert to internal control threads > > examples: convert to normal control threads > > test: convert threads creation > > eal: remove deprecated thread functions > > lib: remove pthread.h from includes > > Thank you for cleaning all this up, Thomas. > > Series-acked-by: Morten Brørup +1 thank you very much, this has been on my todo list it's really appreciated! Series-acked-by: Tyler Retzlaff