From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3650C4254B; Fri, 8 Sep 2023 22:58:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BABF24028A; Fri, 8 Sep 2023 22:58:14 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 0D29E40285 for ; Fri, 8 Sep 2023 22:58:13 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1c1e3a4a06fso19830315ad.3 for ; Fri, 08 Sep 2023 13:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694206692; x=1694811492; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TtVqGmnhoohhqAdL5W8nqocYXzzf0ZI/Lqp20WngvJ8=; b=CLjPSW5M0wdst2oOxGJvagWThw/O9rSaxaV6HWi16O8uZs93fMqWe59YvY8iGDmgjC MXN0GG6Pr890NNmZ3oN43AutJjww8ioRLUkIW8Q+MZdooQSuZSm8x+6M/Bldu5Mvm9Pt /uJRNG3lXh8ijzCVmu+uYlyb/j9OVN0S3gAFSuzRYFrvwIu7viaV5KCzwvNkOffaWXPk gMlyDJR0LZIvfG5BTQpbFVSmX/cvw+7jKrmRJkXndOz/p7xVUJxDy/s0EMJniZVhbDTJ SOiYUnjjsfgx43g1GwfJHZVnyEyrjDdRu+p4xL4z2cxFsFLmKTJkCxG/AwIpe26smDiU DMXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694206692; x=1694811492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TtVqGmnhoohhqAdL5W8nqocYXzzf0ZI/Lqp20WngvJ8=; b=bzJVVFuaQ4wT6y4FtfWLGc6U10we+WLZO1bTu1IqlYqDGYtlEWNjH2mmikU0jY+sb0 9kerX4jXx0GKPUoIUq+Evth+rrVJYFyLOkqO4NLn6FySCBAxTepOi8CEFN/YtlQsPpr+ PcAGU+T8u5Z5RxU8z5UbrVhSgkFtPrYnG71uuGUQmcmg++8ZDzfibW76mReqkIMZQSTf lgdbMF3aasDLGMtJ4IgcwRPSuSi+d0T5aBi1JRKzk1VNB0meWlnmRYhlIVFAGkXl9u+9 qQASMDX9kttiuqHb8T7Gr16fCGSoEIVmGXvHt99uJma3QlJnoUuTUU1UDsks/Aj1i4eQ x15A== X-Gm-Message-State: AOJu0Yyynmm3AGKoCrN8MTbW3+IBAnnntreSHZYvIVSU4fSEaDJr5Ekp ExcfqfmfLIGKVINKF3mnWOfF4g== X-Google-Smtp-Source: AGHT+IFtaynJ8rd7Ly8wEOMk9lLgHtgr1mEobaf4SwQcYSzpH4IG4YuAzsa4K5BUSty6VovySuigow== X-Received: by 2002:a17:902:b494:b0:1c0:ecbb:1831 with SMTP id y20-20020a170902b49400b001c0ecbb1831mr3338734plr.16.1694206692185; Fri, 08 Sep 2023 13:58:12 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id b4-20020a170902d30400b001bc5dc0cd75sm1973908plc.180.2023.09.08.13.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 13:58:12 -0700 (PDT) Date: Fri, 8 Sep 2023 13:58:10 -0700 From: Stephen Hemminger To: Jie Hai Cc: , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm Message-ID: <20230908135810.71588a74@hermes.local> In-Reply-To: <90d47caa-5e45-67c2-a2b8-05ac57bdb618@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230826074607.16771-1-haijie1@huawei.com> <20230826074607.16771-2-haijie1@huawei.com> <20230906081017.5d490c53@hermes.local> <90d47caa-5e45-67c2-a2b8-05ac57bdb618@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Sep 2023 17:28:08 +0800 Jie Hai wrote: > Hi, Stephen Hemminger > > On 2023/9/6 23:10, Stephen Hemminger wrote: > > On Sat, 26 Aug 2023 15:46:03 +0800 > > Jie Hai wrote: > > > >> Currently, rte_eth_rss_conf supports configuring and querying > >> rss hash functions, rss key and it's length, but not rss hash > >> algorithm. > >> > >> The structure ``rte_eth_rss_conf`` is extended by adding a new > >> field "func". This represents the RSS algorithms to apply. The > >> following API is affected: > >> - rte_eth_dev_configure > >> - rte_eth_dev_rss_hash_update > >> - rte_eth_dev_rss_hash_conf_get > >> > >> If the value of "func" used for configuration is a gibberish > >> value, report the error and return. Do the same for > >> rte_eth_dev_rss_hash_update and rte_eth_dev_configure. > >> > >> To check whether the drivers report the "func" field, it is set > >> to default value before querying. > >> > >> Signed-off-by: Jie Hai > >> Signed-off-by: Dongdong Liu > > > > This is unannounced API/ABI change. > Thanks for pointing that. I'm sorry I didn't pay attention to this before. > What should I do with this set of patches? > Is it feasible to send annouce now? Since this API/ABI breaking release, I am ok taking it. But will need a release note. Also you should treat 0 as "no change" case to allow for code that does hash_update without setting the value.