From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3AA2425E5; Tue, 19 Sep 2023 05:19:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69DB540278; Tue, 19 Sep 2023 05:19:21 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 16C6E4003C for ; Tue, 19 Sep 2023 05:19:19 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-690c6f4f6a5so104137b3a.2 for ; Mon, 18 Sep 2023 20:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695093559; x=1695698359; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pcs8x3bSVoxzYfSNsPrlGnQsZWNQOBMYwpLhrMKPYfY=; b=zA0MmtDg2DHfiDuWT3+wNVVO6y1VD3mQ5ZqKV2pjzuDA+z3d4zw5CHU3r4vqOWs3e1 r9UvTlQ+b6iTJXTnoE5tk9ZZejDPwMhKapwvqd4nPSsZtiuEAjtlLAEAJfre0KYxICwc OlMDe1VNEkhjSwktqRz1sIHaYek4zW58dS/6Gie3YFRc4sQTk3DDxXiuj1nT0zxCFR99 Pw6ZfpE2L+YA2KBO1fJ3KPNTx6l567OOHjcTse3EoyMeqXmuTBbOwV7HV8WcSaKb95xY /4vy6DUO4oscxv4rJxcHvzCm8fpMEDavgtpGAZ+JWHKOscT2YJDPvd0OpcADB93Bdgbi ZhEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695093559; x=1695698359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pcs8x3bSVoxzYfSNsPrlGnQsZWNQOBMYwpLhrMKPYfY=; b=nHZQgqM79Jk1uLb9WGiUi1xpVjQzww7e2F2a0FmjISK8Mc2/O25Isfka/rRac+jcic Esg/gJFcirnfMMPyJrwZKkhxNGNAkkEGts1nLoAXWxZjOSwNQHdiuEq7gxs17Si2QkQG LlenF6UtevSbW9jS2oqG2a3wGL1wPzYzYO8UbWTrXZ06VMOq5Q2oIMwn1Pu/efqmGg9P Qpsz0bOkbwW7Tcws4aeDVgUv+itdkqy9BWau1eWi2P7yJkwXkYCh/eyGKEmMstqBePvT CXBSpYelUBV3uep5kBC49cLRPCEBwUux5jxhJH3jO6q5TriK23wTOkiRrk3AzFNXCTj9 BuIQ== X-Gm-Message-State: AOJu0Yx0MBJjf1hIDbgNBbNR8wU4R3mwKO/01KjFLNfd7sPF5oHrxsjP ZOyAqahz8vF8rgqc6m7r/zzn2g== X-Google-Smtp-Source: AGHT+IGKNW0JL16p0NZCd+6ibimseksnORy8s94BbDenTMLFCHIT7A3tznyOs8y29K41Isd43BBsAw== X-Received: by 2002:a05:6a00:23c8:b0:68e:3eb6:d45 with SMTP id g8-20020a056a0023c800b0068e3eb60d45mr10689277pfc.30.1695093559004; Mon, 18 Sep 2023 20:19:19 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id a23-20020a62bd17000000b006901f2f25c5sm7654554pff.220.2023.09.18.20.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 20:19:18 -0700 (PDT) Date: Mon, 18 Sep 2023 20:19:16 -0700 From: Stephen Hemminger To: Cc: , Subject: Re: [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters Message-ID: <20230918201916.4ecbe34a@hermes.local> In-Reply-To: <20230904045658.238185-1-wanry@3snic.com> References: <20230904045658.238185-1-wanry@3snic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 4 Sep 2023 12:56:26 +0800 wrote: > From: Renyong Wan > > The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support > for 3SNIC 9x0 serials family of Ethernet adapters. > > Supported NICs are: > > - 3S910 Dual Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port QSFP28 100GbE Ethernet adapter > > Features of sssnic PMD are: > > - Link status > - Link status event > - Queue start/stop > - Rx interrupt > - Scattered Rx > - TSO > - LRO > - Promiscuous mode > - Allmulticast mode > - Unicast MAC filter > - Multicast MAC filte > - RSS hash > - RSS key update > - RSS reta update > - Inner RSS > - VLAN filter > - VLAN offload > - L3 checksum offload > - L4 checksum offload > - Inner L3 checksum > - Inner L4 checksum > - Basic stats > - Extended stats > - Stats per queue > - Flow control > - FW version > - Generic flow API > > --- > v2: > * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst. > * Removed error.h from including files. > * Fixed variable 'cmd_len' is uninitialized when used. > * Fixed 'EINVAL' undeclared. > * Fixed wrong format of printing uint64_t. > * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'. > > v3: > * Fixed dereferencing type-punned pointer in base/sssnic_mbox.c. > > v4: > * Fixed dereferencing type-punned pointer in base/sssnic_eventq.c. > * Fixed coding style issue of COMPLEX_MACRO. > * Fixed coding style issue of REPEATED_WORD. > > v5: > * Fixed rebase mistake. > * Fixed incorrect path in MAINTAINERS file. > --- > > Renyong Wan (32): > net/sssnic: add build and doc infrastructure > net/sssnic: add log type and log macros > net/sssnic: support probe and remove > net/sssnic: initialize hardware base > net/sssnic: add event queue > net/sssnic/base: add message definition and utility > net/sssnic/base: add mailbox support > net/sssnic/base: add work queue > net/sssnic/base: add control queue > net/sssnic: add dev configure and infos get > net/sssnic: add dev MAC ops > net/sssnic: support dev link status > net/sssnic: support link status event > net/sssnic: support Rx queue setup and release > net/sssnic: support Tx queue setup and release > net/sssnic: support Rx queue start and stop > net/sssnic: support Tx queue start and stop > net/sssnic: add Rx interrupt support > net/sssnic: support dev start and stop > net/sssnic: support dev close and reset > net/sssnic: add allmulticast and promiscuous ops > net/sssnic: add basic and extended stats ops > net/sssnic: support Rx packet burst > net/sssnic: support Tx packet burst > net/sssnic: add RSS support > net/sssnic: support dev MTU set > net/sssnic: support dev queue info get > net/sssnic: support dev firmware version get > net/sssnic: add dev flow control ops > net/sssnic: support VLAN offload and filter > net/sssnic: add generic flow ops > net/sssnic: add VF dev support > > .mailmap | 2 + > MAINTAINERS | 7 + > doc/guides/nics/features/sssnic.ini | 47 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/sssnic.rst | 73 + > drivers/net/meson.build | 1 + > drivers/net/sssnic/base/meson.build | 20 + > drivers/net/sssnic/base/sssnic_api.c | 1943 ++++++++++++++++++++ > drivers/net/sssnic/base/sssnic_api.h | 498 +++++ > drivers/net/sssnic/base/sssnic_cmd.h | 514 ++++++ > drivers/net/sssnic/base/sssnic_ctrlq.c | 521 ++++++ > drivers/net/sssnic/base/sssnic_ctrlq.h | 58 + > drivers/net/sssnic/base/sssnic_eventq.c | 461 +++++ > drivers/net/sssnic/base/sssnic_eventq.h | 84 + > drivers/net/sssnic/base/sssnic_exception.c | 116 ++ > drivers/net/sssnic/base/sssnic_exception.h | 10 + > drivers/net/sssnic/base/sssnic_hw.c | 486 +++++ > drivers/net/sssnic/base/sssnic_hw.h | 117 ++ > drivers/net/sssnic/base/sssnic_mbox.c | 615 +++++++ > drivers/net/sssnic/base/sssnic_mbox.h | 45 + > drivers/net/sssnic/base/sssnic_misc.h | 52 + > drivers/net/sssnic/base/sssnic_msg.c | 254 +++ > drivers/net/sssnic/base/sssnic_msg.h | 166 ++ > drivers/net/sssnic/base/sssnic_reg.h | 267 +++ > drivers/net/sssnic/base/sssnic_workq.c | 141 ++ > drivers/net/sssnic/base/sssnic_workq.h | 108 ++ > drivers/net/sssnic/meson.build | 28 + > drivers/net/sssnic/sssnic_ethdev.c | 1139 ++++++++++++ > drivers/net/sssnic/sssnic_ethdev.h | 102 + > drivers/net/sssnic/sssnic_ethdev_fdir.c | 1017 ++++++++++ > drivers/net/sssnic/sssnic_ethdev_fdir.h | 332 ++++ > drivers/net/sssnic/sssnic_ethdev_flow.c | 981 ++++++++++ > drivers/net/sssnic/sssnic_ethdev_flow.h | 11 + > drivers/net/sssnic/sssnic_ethdev_link.c | 209 +++ > drivers/net/sssnic/sssnic_ethdev_link.h | 14 + > drivers/net/sssnic/sssnic_ethdev_rss.c | 377 ++++ > drivers/net/sssnic/sssnic_ethdev_rss.h | 20 + > drivers/net/sssnic/sssnic_ethdev_rx.c | 1396 ++++++++++++++ > drivers/net/sssnic/sssnic_ethdev_rx.h | 50 + > drivers/net/sssnic/sssnic_ethdev_stats.c | 414 +++++ > drivers/net/sssnic/sssnic_ethdev_stats.h | 18 + > drivers/net/sssnic/sssnic_ethdev_tx.c | 1123 +++++++++++ > drivers/net/sssnic/sssnic_ethdev_tx.h | 45 + > drivers/net/sssnic/sssnic_log.h | 51 + > 44 files changed, 13934 insertions(+) > create mode 100644 doc/guides/nics/features/sssnic.ini > create mode 100644 doc/guides/nics/sssnic.rst > create mode 100644 drivers/net/sssnic/base/meson.build > create mode 100644 drivers/net/sssnic/base/sssnic_api.c > create mode 100644 drivers/net/sssnic/base/sssnic_api.h > create mode 100644 drivers/net/sssnic/base/sssnic_cmd.h > create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.c > create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.h > create mode 100644 drivers/net/sssnic/base/sssnic_eventq.c > create mode 100644 drivers/net/sssnic/base/sssnic_eventq.h > create mode 100644 drivers/net/sssnic/base/sssnic_exception.c > create mode 100644 drivers/net/sssnic/base/sssnic_exception.h > create mode 100644 drivers/net/sssnic/base/sssnic_hw.c > create mode 100644 drivers/net/sssnic/base/sssnic_hw.h > create mode 100644 drivers/net/sssnic/base/sssnic_mbox.c > create mode 100644 drivers/net/sssnic/base/sssnic_mbox.h > create mode 100644 drivers/net/sssnic/base/sssnic_misc.h > create mode 100644 drivers/net/sssnic/base/sssnic_msg.c > create mode 100644 drivers/net/sssnic/base/sssnic_msg.h > create mode 100644 drivers/net/sssnic/base/sssnic_reg.h > create mode 100644 drivers/net/sssnic/base/sssnic_workq.c > create mode 100644 drivers/net/sssnic/base/sssnic_workq.h > create mode 100644 drivers/net/sssnic/meson.build > create mode 100644 drivers/net/sssnic/sssnic_ethdev.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.h > create mode 100644 drivers/net/sssnic/sssnic_log.h > There seem to be a leftover stub, after all merged together. static int sssnic_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) { RTE_SET_USED(pci_drv); <<< this is wrong, you do use it by passing to generic probe PMD_INIT_FUNC_TRACE(); return rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct sssnic_netdev), sssnic_ethdev_init); } It is simpler to used __rte_unused here. int sssnic_ethdev_flow_ops_get(struct rte_eth_dev *ethdev, const struct rte_flow_ops **ops) { RTE_SET_USED(ethdev); *ops = &sssnic_ethdev_flow_ops; return 0; }