From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22C72425F7; Tue, 19 Sep 2023 05:23:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95A3C40278; Tue, 19 Sep 2023 05:23:51 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 3FF3C4003C for ; Tue, 19 Sep 2023 05:23:50 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1c0c6d4d650so47037035ad.0 for ; Mon, 18 Sep 2023 20:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695093829; x=1695698629; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QnyT3KE9mTxUWc+BmfMqDdbSC2YadRfG6+d+fFMRZ9c=; b=2V0lXFgkaOfhULufOkdm/PFtRlgK/WiEtSNKAN3xP1kkrTFf+kd6OkjP6TvBWP/lPE Tgwv6OBXCcB7i2iK1r4QHZi+7R3EWgtNpmXpBHXwgg8Di/Q9UIemj0j9FE450BBnyatZ e9VDuFk8G4TNJm6HsmAtVNR3g4KuitVRc3Rq9duL15O1kYXzjB/rCIkHhGcb+oPuCITK g8H/mbSzmNH6FqDk5tNxIL3niKf7q5lYTAvEJ7qLHCQ8vRv6xxaHV0y1dzRhaXbRkYk7 IjXjt227r64hvqvBoZcxbO76IWivsUomLos07BNlErn6GiqwBE933fzXZn0MPyTlTfwY OFfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695093829; x=1695698629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QnyT3KE9mTxUWc+BmfMqDdbSC2YadRfG6+d+fFMRZ9c=; b=PH4ll3TR+hfEfCh2QIpWVVnVhIrrf+rmMLhDkslg/PiYTB34qbJGYP6WEKeN+fIR6w N6+6nO5GbdTpQ+HzN2eASg3Iy6RgRMXJiITIuN8G8DaaPmHyJIbQAxVIaEvxN0qezt3p nx8TI0iADrim8YywgiqdRf5pqFLImjaS7xeg9kSWqQmTosqePMQqaq7RQ0bDCwKX3f3Z 10uXM4hOJtU/B4dznl+EKrpjSlSYY2GQ1i7tYiZuevGjieILaedO0ky9gCkcCJyXD3KU DeisHaXXZEcOUJKNd10TfEG+fSCKnRZEDzsFzLZI/a1y39z90xTkYhrjrFJ65XZAHSzi qtIg== X-Gm-Message-State: AOJu0YzVktZQA00/3F68IXluKUlidJsof//pAI2n6TCrdq581+SMx2kJ 1cXuiFps9vgG+8f0jpQ1r4aZlg== X-Google-Smtp-Source: AGHT+IFuEDTp6UEF0lXX4FzJflXVGCGFkvy7aYY+uQcZ4T/bTDQB4P1TW4PquJc5qk2z/Lc/vIYd1g== X-Received: by 2002:a17:902:d488:b0:1c3:d9ed:a410 with SMTP id c8-20020a170902d48800b001c3d9eda410mr13778449plg.59.1695093829409; Mon, 18 Sep 2023 20:23:49 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id n12-20020a170902d2cc00b001a5fccab02dsm3866743plc.177.2023.09.18.20.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 20:23:49 -0700 (PDT) Date: Mon, 18 Sep 2023 20:23:47 -0700 From: Stephen Hemminger To: Cc: , Subject: Re: [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters Message-ID: <20230918202347.0f2ed15f@hermes.local> In-Reply-To: <20230904045658.238185-1-wanry@3snic.com> References: <20230904045658.238185-1-wanry@3snic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 4 Sep 2023 12:56:26 +0800 wrote: > From: Renyong Wan > > The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support > for 3SNIC 9x0 serials family of Ethernet adapters. > > Supported NICs are: > > - 3S910 Dual Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port SFP28 10/25GbE Ethernet adapter > - 3S920 Quad Port QSFP28 100GbE Ethernet adapter > > Features of sssnic PMD are: > > - Link status > - Link status event > - Queue start/stop > - Rx interrupt > - Scattered Rx > - TSO > - LRO > - Promiscuous mode > - Allmulticast mode > - Unicast MAC filter > - Multicast MAC filte > - RSS hash > - RSS key update > - RSS reta update > - Inner RSS > - VLAN filter > - VLAN offload > - L3 checksum offload > - L4 checksum offload > - Inner L3 checksum > - Inner L4 checksum > - Basic stats > - Extended stats > - Stats per queue > - Flow control > - FW version > - Generic flow API > > --- > v2: > * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst. > * Removed error.h from including files. > * Fixed variable 'cmd_len' is uninitialized when used. > * Fixed 'EINVAL' undeclared. > * Fixed wrong format of printing uint64_t. > * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'. > > v3: > * Fixed dereferencing type-punned pointer in base/sssnic_mbox.c. > > v4: > * Fixed dereferencing type-punned pointer in base/sssnic_eventq.c. > * Fixed coding style issue of COMPLEX_MACRO. > * Fixed coding style issue of REPEATED_WORD. > > v5: > * Fixed rebase mistake. > * Fixed incorrect path in MAINTAINERS file. > --- > > Renyong Wan (32): > net/sssnic: add build and doc infrastructure > net/sssnic: add log type and log macros > net/sssnic: support probe and remove > net/sssnic: initialize hardware base > net/sssnic: add event queue > net/sssnic/base: add message definition and utility > net/sssnic/base: add mailbox support > net/sssnic/base: add work queue > net/sssnic/base: add control queue > net/sssnic: add dev configure and infos get > net/sssnic: add dev MAC ops > net/sssnic: support dev link status > net/sssnic: support link status event > net/sssnic: support Rx queue setup and release > net/sssnic: support Tx queue setup and release > net/sssnic: support Rx queue start and stop > net/sssnic: support Tx queue start and stop > net/sssnic: add Rx interrupt support > net/sssnic: support dev start and stop > net/sssnic: support dev close and reset > net/sssnic: add allmulticast and promiscuous ops > net/sssnic: add basic and extended stats ops > net/sssnic: support Rx packet burst > net/sssnic: support Tx packet burst > net/sssnic: add RSS support > net/sssnic: support dev MTU set > net/sssnic: support dev queue info get > net/sssnic: support dev firmware version get > net/sssnic: add dev flow control ops > net/sssnic: support VLAN offload and filter > net/sssnic: add generic flow ops > net/sssnic: add VF dev support > > .mailmap | 2 + > MAINTAINERS | 7 + > doc/guides/nics/features/sssnic.ini | 47 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/sssnic.rst | 73 + > drivers/net/meson.build | 1 + > drivers/net/sssnic/base/meson.build | 20 + > drivers/net/sssnic/base/sssnic_api.c | 1943 ++++++++++++++++++++ > drivers/net/sssnic/base/sssnic_api.h | 498 +++++ > drivers/net/sssnic/base/sssnic_cmd.h | 514 ++++++ > drivers/net/sssnic/base/sssnic_ctrlq.c | 521 ++++++ > drivers/net/sssnic/base/sssnic_ctrlq.h | 58 + > drivers/net/sssnic/base/sssnic_eventq.c | 461 +++++ > drivers/net/sssnic/base/sssnic_eventq.h | 84 + > drivers/net/sssnic/base/sssnic_exception.c | 116 ++ > drivers/net/sssnic/base/sssnic_exception.h | 10 + > drivers/net/sssnic/base/sssnic_hw.c | 486 +++++ > drivers/net/sssnic/base/sssnic_hw.h | 117 ++ > drivers/net/sssnic/base/sssnic_mbox.c | 615 +++++++ > drivers/net/sssnic/base/sssnic_mbox.h | 45 + > drivers/net/sssnic/base/sssnic_misc.h | 52 + > drivers/net/sssnic/base/sssnic_msg.c | 254 +++ > drivers/net/sssnic/base/sssnic_msg.h | 166 ++ > drivers/net/sssnic/base/sssnic_reg.h | 267 +++ > drivers/net/sssnic/base/sssnic_workq.c | 141 ++ > drivers/net/sssnic/base/sssnic_workq.h | 108 ++ > drivers/net/sssnic/meson.build | 28 + > drivers/net/sssnic/sssnic_ethdev.c | 1139 ++++++++++++ > drivers/net/sssnic/sssnic_ethdev.h | 102 + > drivers/net/sssnic/sssnic_ethdev_fdir.c | 1017 ++++++++++ > drivers/net/sssnic/sssnic_ethdev_fdir.h | 332 ++++ > drivers/net/sssnic/sssnic_ethdev_flow.c | 981 ++++++++++ > drivers/net/sssnic/sssnic_ethdev_flow.h | 11 + > drivers/net/sssnic/sssnic_ethdev_link.c | 209 +++ > drivers/net/sssnic/sssnic_ethdev_link.h | 14 + > drivers/net/sssnic/sssnic_ethdev_rss.c | 377 ++++ > drivers/net/sssnic/sssnic_ethdev_rss.h | 20 + > drivers/net/sssnic/sssnic_ethdev_rx.c | 1396 ++++++++++++++ > drivers/net/sssnic/sssnic_ethdev_rx.h | 50 + > drivers/net/sssnic/sssnic_ethdev_stats.c | 414 +++++ > drivers/net/sssnic/sssnic_ethdev_stats.h | 18 + > drivers/net/sssnic/sssnic_ethdev_tx.c | 1123 +++++++++++ > drivers/net/sssnic/sssnic_ethdev_tx.h | 45 + > drivers/net/sssnic/sssnic_log.h | 51 + > 44 files changed, 13934 insertions(+) > create mode 100644 doc/guides/nics/features/sssnic.ini > create mode 100644 doc/guides/nics/sssnic.rst > create mode 100644 drivers/net/sssnic/base/meson.build > create mode 100644 drivers/net/sssnic/base/sssnic_api.c > create mode 100644 drivers/net/sssnic/base/sssnic_api.h > create mode 100644 drivers/net/sssnic/base/sssnic_cmd.h > create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.c > create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.h > create mode 100644 drivers/net/sssnic/base/sssnic_eventq.c > create mode 100644 drivers/net/sssnic/base/sssnic_eventq.h > create mode 100644 drivers/net/sssnic/base/sssnic_exception.c > create mode 100644 drivers/net/sssnic/base/sssnic_exception.h > create mode 100644 drivers/net/sssnic/base/sssnic_hw.c > create mode 100644 drivers/net/sssnic/base/sssnic_hw.h > create mode 100644 drivers/net/sssnic/base/sssnic_mbox.c > create mode 100644 drivers/net/sssnic/base/sssnic_mbox.h > create mode 100644 drivers/net/sssnic/base/sssnic_misc.h > create mode 100644 drivers/net/sssnic/base/sssnic_msg.c > create mode 100644 drivers/net/sssnic/base/sssnic_msg.h > create mode 100644 drivers/net/sssnic/base/sssnic_reg.h > create mode 100644 drivers/net/sssnic/base/sssnic_workq.c > create mode 100644 drivers/net/sssnic/base/sssnic_workq.h > create mode 100644 drivers/net/sssnic/meson.build > create mode 100644 drivers/net/sssnic/sssnic_ethdev.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.h > create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.c > create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.h > create mode 100644 drivers/net/sssnic/sssnic_log.h Since secondary process is not supported... static int sssnic_ethdev_init(struct rte_eth_dev *ethdev) { int ret; struct sssnic_hw *hw; struct sssnic_netdev *netdev; struct rte_pci_device *pci_dev; PMD_INIT_FUNC_TRACE(); if (rte_eal_process_type() != RTE_PROC_PRIMARY) return 0; Should be something like: if (rte_eal_process_type() != RTE_PROC_PRIMARY) { PMD_DRV_LOG(ERR, "Secondary process not supported"); return -ENOTSUP; }