From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D278242607;
	Thu, 21 Sep 2023 17:45:04 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BE53F4013F;
	Thu, 21 Sep 2023 17:45:04 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 84ABF4013F
 for <dev@dpdk.org>; Thu, 21 Sep 2023 17:45:03 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D6317212C5BB; Thu, 21 Sep 2023 08:45:02 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D6317212C5BB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1695311102;
 bh=NkjHVOYKjJOwGVfzakOgdFCjjz55EwpMvkH2kiw3aIM=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=lyhTB2bzRVczxHeC+UP2kurQv8ftv1ZWhKwr3m2un/rxZyCK9cBP83HpL1w9pscHK
 OxB5fBlWCGx2gnPr2YGsNeWYS/CRn8LYhtbsAx0vDUE9HBEGy1sJJeRIjrTFsEQruV
 jBNdiCQmZolwZYykUhGtV0iJwnGnigsWNFVWwGHA=
Date: Thu, 21 Sep 2023 08:45:02 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
 Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] eal: provide per lcore macros for MSVC
Message-ID: <20230921154502.GA13576@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1689024585-17303-1-git-send-email-roretzla@linux.microsoft.com>
 <2619168.k3LOHGUjKi@thomas>
 <20230831230812.GA31929@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <4582312.iZASKD2KPV@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4582312.iZASKD2KPV@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Sep 21, 2023 at 11:36:32AM +0200, Thomas Monjalon wrote:
> 01/09/2023 01:08, Tyler Retzlaff:
> > On Thu, Aug 31, 2023 at 01:57:36PM +0200, Thomas Monjalon wrote:
> > > 11/07/2023 17:52, Tyler Retzlaff:
> > > > +#ifdef RTE_TOOLCHAIN_MSVC
> > > >  /**
> > > >   * Macro to define a per lcore variable "var" of type "type", don't
> > > >   * use keywords like "static" or "volatile" in type, just prefix the
> > > >   * whole macro.
> > > >   */
> > > >  #define RTE_DEFINE_PER_LCORE(type, name)			\
> > > > -	__thread __typeof__(type) per_lcore_##name
> > > > +	__declspec(thread) typeof(type) per_lcore_##name
> > > >  
> > > >  /**
> > > >   * Macro to declare an extern per lcore variable "var" of type "type"
> > > >   */
> > > >  #define RTE_DECLARE_PER_LCORE(type, name)			\
> > > > +	extern __declspec(thread) typeof(type) per_lcore_##name
> > > > +#else
> > > > +#define RTE_DEFINE_PER_LCORE(type, name)			\
> > > > +	__thread __typeof__(type) per_lcore_##name
> > > > +
> > > > +#define RTE_DECLARE_PER_LCORE(type, name)			\
> > > >  	extern __thread __typeof__(type) per_lcore_##name
> > > > +#endif
> > > 
> > > I'm afraid you damaged the doxygen document here.
> > > Please check what happens when generating doxygen.
> > > I suppose it does not take the RTE_TOOLCHAIN_MSVC path,
> > > so it does not find any comment.
> > 
> > Thanks Thomas i will look into fixing it.
> 
> Please can you send the fix?
> 

Sure, do you want me to just move the documentation to the non MSVC path
or do you have another prefered solution in mind?