* [PATCH 0/2] Add eventdev tests to test suites @ 2023-09-28 15:14 Bruce Richardson 2023-09-28 15:14 ` [PATCH 1/2] event/sw: add self tests to fast tests Bruce Richardson ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Bruce Richardson @ 2023-09-28 15:14 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson The eventdev library includes a selftest API which can be used by drivers for testing. Add the relevant automated self-test commands into meson test suites as appropriate. Bruce Richardson (2): event/sw: add self tests to fast tests event/*: add driver selftests to driver-tests suite app/test/test_eventdev.c | 10 +++++----- drivers/event/sw/sw_evdev_selftest.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.39.2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] event/sw: add self tests to fast tests 2023-09-28 15:14 [PATCH 0/2] Add eventdev tests to test suites Bruce Richardson @ 2023-09-28 15:14 ` Bruce Richardson 2023-10-03 6:23 ` Jerin Jacob 2023-09-28 15:14 ` [PATCH 2/2] event/*: add driver selftests to driver-tests suite Bruce Richardson 2023-09-29 14:22 ` [PATCH 0/2] Add eventdev tests to test suites David Marchand 2 siblings, 1 reply; 7+ messages in thread From: Bruce Richardson @ 2023-09-28 15:14 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson By reducing the iterations for the final stage of the self-test, the SW eventdev tests can be fast enough for consideration in the fast-tests suite. This enables them to be run as part of the regular patch CI tests, and therefore increases the chances of catching any errors in patches that may affect this component. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- app/test/test_eventdev.c | 2 +- drivers/event/sw/sw_evdev_selftest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index c51c93bdbd..c94c15bef1 100644 --- a/app/test/test_eventdev.c +++ b/app/test/test_eventdev.c @@ -1259,7 +1259,7 @@ test_eventdev_selftest_cn10k(void) REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common); #ifndef RTE_EXEC_ENV_WINDOWS -REGISTER_DRIVER_TEST(eventdev_selftest_sw, test_eventdev_selftest_sw); +REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw); REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx); REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2); REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2); diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c index 3aa8d76ca8..3f0d9806f2 100644 --- a/drivers/event/sw/sw_evdev_selftest.c +++ b/drivers/event/sw/sw_evdev_selftest.c @@ -28,7 +28,7 @@ #define MAX_PORTS 16 #define MAX_QIDS 16 -#define NUM_PACKETS (1<<18) +#define NUM_PACKETS (1 << 17) #define DEQUEUE_DEPTH 128 static int evdev; -- 2.39.2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] event/sw: add self tests to fast tests 2023-09-28 15:14 ` [PATCH 1/2] event/sw: add self tests to fast tests Bruce Richardson @ 2023-10-03 6:23 ` Jerin Jacob 2023-10-03 8:26 ` Van Haaren, Harry 0 siblings, 1 reply; 7+ messages in thread From: Jerin Jacob @ 2023-10-03 6:23 UTC (permalink / raw) To: Bruce Richardson, Van Haaren, Harry; +Cc: dev On Thu, Sep 28, 2023 at 9:01 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > By reducing the iterations for the final stage of the self-test, the SW > eventdev tests can be fast enough for consideration in the fast-tests > suite. This enables them to be run as part of the regular patch CI > tests, and therefore increases the chances of catching any errors in > patches that may affect this component. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Looks like --to-cmd ./scripts/get_maintainer.pl not used in sending patches. @Van Haaren, Harry Could you review and Ack it to merge? > --- > app/test/test_eventdev.c | 2 +- > drivers/event/sw/sw_evdev_selftest.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c > index c51c93bdbd..c94c15bef1 100644 > --- a/app/test/test_eventdev.c > +++ b/app/test/test_eventdev.c > @@ -1259,7 +1259,7 @@ test_eventdev_selftest_cn10k(void) > REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common); > > #ifndef RTE_EXEC_ENV_WINDOWS > -REGISTER_DRIVER_TEST(eventdev_selftest_sw, test_eventdev_selftest_sw); > +REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw); > REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx); > REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2); > REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2); > diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c > index 3aa8d76ca8..3f0d9806f2 100644 > --- a/drivers/event/sw/sw_evdev_selftest.c > +++ b/drivers/event/sw/sw_evdev_selftest.c > @@ -28,7 +28,7 @@ > > #define MAX_PORTS 16 > #define MAX_QIDS 16 > -#define NUM_PACKETS (1<<18) > +#define NUM_PACKETS (1 << 17) > #define DEQUEUE_DEPTH 128 > > static int evdev; > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] event/sw: add self tests to fast tests 2023-10-03 6:23 ` Jerin Jacob @ 2023-10-03 8:26 ` Van Haaren, Harry 0 siblings, 0 replies; 7+ messages in thread From: Van Haaren, Harry @ 2023-10-03 8:26 UTC (permalink / raw) To: Jerin Jacob, Richardson, Bruce; +Cc: dev > -----Original Message----- > From: Jerin Jacob <jerinjacobk@gmail.com> > Sent: Tuesday, October 3, 2023 7:23 AM > To: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry > <harry.van.haaren@intel.com> > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] event/sw: add self tests to fast tests > > On Thu, Sep 28, 2023 at 9:01 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > By reducing the iterations for the final stage of the self-test, the SW > > eventdev tests can be fast enough for consideration in the fast-tests > > suite. This enables them to be run as part of the regular patch CI > > tests, and therefore increases the chances of catching any errors in > > patches that may affect this component. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > Looks like --to-cmd ./scripts/get_maintainer.pl not used in sending patches. > @Van Haaren, Harry Could you review and Ack it to merge? Thanks for the loop-in Jerin, Acked-by: Harry van Haaren <harry.van.haaren@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] event/*: add driver selftests to driver-tests suite 2023-09-28 15:14 [PATCH 0/2] Add eventdev tests to test suites Bruce Richardson 2023-09-28 15:14 ` [PATCH 1/2] event/sw: add self tests to fast tests Bruce Richardson @ 2023-09-28 15:14 ` Bruce Richardson 2023-09-29 14:22 ` [PATCH 0/2] Add eventdev tests to test suites David Marchand 2 siblings, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2023-09-28 15:14 UTC (permalink / raw) To: dev; +Cc: Bruce Richardson The octeontx eventdev test was in the "driver-tests" suite, but none of the other HW eventdev selftests were in any test suite. Add them to the drivers suite for completeness. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- app/test/test_eventdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index c94c15bef1..af4d7b3288 100644 --- a/app/test/test_eventdev.c +++ b/app/test/test_eventdev.c @@ -1261,9 +1261,9 @@ REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common); #ifndef RTE_EXEC_ENV_WINDOWS REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw); REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx); -REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2); -REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2); -REGISTER_TEST_COMMAND(eventdev_selftest_cn9k, test_eventdev_selftest_cn9k); -REGISTER_TEST_COMMAND(eventdev_selftest_cn10k, test_eventdev_selftest_cn10k); +REGISTER_DRIVER_TEST(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2); +REGISTER_DRIVER_TEST(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2); +REGISTER_DRIVER_TEST(eventdev_selftest_cn9k, test_eventdev_selftest_cn9k); +REGISTER_DRIVER_TEST(eventdev_selftest_cn10k, test_eventdev_selftest_cn10k); #endif /* !RTE_EXEC_ENV_WINDOWS */ -- 2.39.2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Add eventdev tests to test suites 2023-09-28 15:14 [PATCH 0/2] Add eventdev tests to test suites Bruce Richardson 2023-09-28 15:14 ` [PATCH 1/2] event/sw: add self tests to fast tests Bruce Richardson 2023-09-28 15:14 ` [PATCH 2/2] event/*: add driver selftests to driver-tests suite Bruce Richardson @ 2023-09-29 14:22 ` David Marchand 2023-10-03 10:02 ` Jerin Jacob 2 siblings, 1 reply; 7+ messages in thread From: David Marchand @ 2023-09-29 14:22 UTC (permalink / raw) To: Bruce Richardson, Jerin Jacob Kollanukkaran; +Cc: dev, Aaron Conole On Thu, Sep 28, 2023 at 5:14 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > The eventdev library includes a selftest API which can be used by > drivers for testing. Add the relevant automated self-test commands > into meson test suites as appropriate. > > Bruce Richardson (2): > event/sw: add self tests to fast tests > event/*: add driver selftests to driver-tests suite > > app/test/test_eventdev.c | 10 +++++----- > drivers/event/sw/sw_evdev_selftest.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > On the principle, the series lgtm. Acked-by: David Marchand <david.marchand@redhat.com> -- David Marchand ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Add eventdev tests to test suites 2023-09-29 14:22 ` [PATCH 0/2] Add eventdev tests to test suites David Marchand @ 2023-10-03 10:02 ` Jerin Jacob 0 siblings, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2023-10-03 10:02 UTC (permalink / raw) To: David Marchand Cc: Bruce Richardson, Jerin Jacob Kollanukkaran, dev, Aaron Conole On Sat, Sep 30, 2023 at 6:31 AM David Marchand <david.marchand@redhat.com> wrote: > > On Thu, Sep 28, 2023 at 5:14 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > The eventdev library includes a selftest API which can be used by > > drivers for testing. Add the relevant automated self-test commands > > into meson test suites as appropriate. > > > > Bruce Richardson (2): > > event/sw: add self tests to fast tests > > event/*: add driver selftests to driver-tests suite > > > > app/test/test_eventdev.c | 10 +++++----- > > drivers/event/sw/sw_evdev_selftest.c | 2 +- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > On the principle, the series lgtm. > Acked-by: David Marchand <david.marchand@redhat.com> Changed second patch subject to test/event: add driver selftests to driver-tests suite Series applied to dpdk-next-net-eventdev/for-main. Thanks > > > -- > David Marchand > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-03 10:03 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-09-28 15:14 [PATCH 0/2] Add eventdev tests to test suites Bruce Richardson 2023-09-28 15:14 ` [PATCH 1/2] event/sw: add self tests to fast tests Bruce Richardson 2023-10-03 6:23 ` Jerin Jacob 2023-10-03 8:26 ` Van Haaren, Harry 2023-09-28 15:14 ` [PATCH 2/2] event/*: add driver selftests to driver-tests suite Bruce Richardson 2023-09-29 14:22 ` [PATCH 0/2] Add eventdev tests to test suites David Marchand 2023-10-03 10:02 ` Jerin Jacob
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).