[PATCH 0/2] Add eventdev tests to test suites

[PATCH 0/2] Add eventdev tests to test suites

[Bruce Richardson]

The eventdev library includes a selftest API which can be used by
drivers for testing. Add the relevant automated self-test commands
into meson test suites as appropriate.

Bruce Richardson (2):
  event/sw: add self tests to fast tests
  event/*: add driver selftests to driver-tests suite

 app/test/test_eventdev.c             | 10 +++++-----
 drivers/event/sw/sw_evdev_selftest.c |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.39.2

[PATCH 1/2] event/sw: add self tests to fast tests

[Bruce Richardson]

By reducing the iterations for the final stage of the self-test, the SW
eventdev tests can be fast enough for consideration in the fast-tests
suite. This enables them to be run as part of the regular patch CI
tests, and therefore increases the chances of catching any errors in
patches that may affect this component.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_eventdev.c             | 2 +-
 drivers/event/sw/sw_evdev_selftest.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
index c51c93bdbd..c94c15bef1 100644
--- a/app/test/test_eventdev.c
+++ b/app/test/test_eventdev.c
@@ -1259,7 +1259,7 @@ test_eventdev_selftest_cn10k(void)
 REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common);
 
 #ifndef RTE_EXEC_ENV_WINDOWS
-REGISTER_DRIVER_TEST(eventdev_selftest_sw, test_eventdev_selftest_sw);
+REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw);
 REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx);
 REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2);
 REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2);
diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c
index 3aa8d76ca8..3f0d9806f2 100644
--- a/drivers/event/sw/sw_evdev_selftest.c
+++ b/drivers/event/sw/sw_evdev_selftest.c
@@ -28,7 +28,7 @@
 
 #define MAX_PORTS 16
 #define MAX_QIDS 16
-#define NUM_PACKETS (1<<18)
+#define NUM_PACKETS (1 << 17)
 #define DEQUEUE_DEPTH 128
 
 static int evdev;
-- 
2.39.2

Re: [PATCH 1/2] event/sw: add self tests to fast tests

[Jerin Jacob]

On Thu, Sep 28, 2023 at 9:01 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> By reducing the iterations for the final stage of the self-test, the SW
> eventdev tests can be fast enough for consideration in the fast-tests
> suite. This enables them to be run as part of the regular patch CI
> tests, and therefore increases the chances of catching any errors in
> patches that may affect this component.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Looks like  --to-cmd ./scripts/get_maintainer.pl not used in sending patches.
@Van Haaren, Harry  Could you review and Ack it to merge?


> ---
>  app/test/test_eventdev.c             | 2 +-
>  drivers/event/sw/sw_evdev_selftest.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index c51c93bdbd..c94c15bef1 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -1259,7 +1259,7 @@ test_eventdev_selftest_cn10k(void)
>  REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common);
>
>  #ifndef RTE_EXEC_ENV_WINDOWS
> -REGISTER_DRIVER_TEST(eventdev_selftest_sw, test_eventdev_selftest_sw);
> +REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw);
>  REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx);
>  REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2);
>  REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2);
> diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c
> index 3aa8d76ca8..3f0d9806f2 100644
> --- a/drivers/event/sw/sw_evdev_selftest.c
> +++ b/drivers/event/sw/sw_evdev_selftest.c
> @@ -28,7 +28,7 @@
>
>  #define MAX_PORTS 16
>  #define MAX_QIDS 16
> -#define NUM_PACKETS (1<<18)
> +#define NUM_PACKETS (1 << 17)
>  #define DEQUEUE_DEPTH 128
>
>  static int evdev;
> --
> 2.39.2
>

RE: [PATCH 1/2] event/sw: add self tests to fast tests

[Van Haaren, Harry]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Tuesday, October 3, 2023 7:23 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/2] event/sw: add self tests to fast tests
> 
> On Thu, Sep 28, 2023 at 9:01 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > By reducing the iterations for the final stage of the self-test, the SW
> > eventdev tests can be fast enough for consideration in the fast-tests
> > suite. This enables them to be run as part of the regular patch CI
> > tests, and therefore increases the chances of catching any errors in
> > patches that may affect this component.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Looks like  --to-cmd ./scripts/get_maintainer.pl not used in sending patches.
> @Van Haaren, Harry  Could you review and Ack it to merge?

Thanks for the loop-in Jerin,

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

[PATCH 2/2] event/*: add driver selftests to driver-tests suite

[Bruce Richardson]

The octeontx eventdev test was in the "driver-tests" suite, but none of
the other HW eventdev selftests were in any test suite. Add them to the
drivers suite for completeness.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_eventdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
index c94c15bef1..af4d7b3288 100644
--- a/app/test/test_eventdev.c
+++ b/app/test/test_eventdev.c
@@ -1261,9 +1261,9 @@ REGISTER_FAST_TEST(eventdev_common_autotest, true, true, test_eventdev_common);
 #ifndef RTE_EXEC_ENV_WINDOWS
 REGISTER_FAST_TEST(eventdev_selftest_sw, true, true, test_eventdev_selftest_sw);
 REGISTER_DRIVER_TEST(eventdev_selftest_octeontx, test_eventdev_selftest_octeontx);
-REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2);
-REGISTER_TEST_COMMAND(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2);
-REGISTER_TEST_COMMAND(eventdev_selftest_cn9k, test_eventdev_selftest_cn9k);
-REGISTER_TEST_COMMAND(eventdev_selftest_cn10k, test_eventdev_selftest_cn10k);
+REGISTER_DRIVER_TEST(eventdev_selftest_dpaa2, test_eventdev_selftest_dpaa2);
+REGISTER_DRIVER_TEST(eventdev_selftest_dlb2, test_eventdev_selftest_dlb2);
+REGISTER_DRIVER_TEST(eventdev_selftest_cn9k, test_eventdev_selftest_cn9k);
+REGISTER_DRIVER_TEST(eventdev_selftest_cn10k, test_eventdev_selftest_cn10k);
 
 #endif /* !RTE_EXEC_ENV_WINDOWS */
-- 
2.39.2

Re: [PATCH 0/2] Add eventdev tests to test suites

[David Marchand]

On Thu, Sep 28, 2023 at 5:14 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The eventdev library includes a selftest API which can be used by
> drivers for testing. Add the relevant automated self-test commands
> into meson test suites as appropriate.
>
> Bruce Richardson (2):
>   event/sw: add self tests to fast tests
>   event/*: add driver selftests to driver-tests suite
>
>  app/test/test_eventdev.c             | 10 +++++-----
>  drivers/event/sw/sw_evdev_selftest.c |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
>

On the principle, the series lgtm.
Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [PATCH 0/2] Add eventdev tests to test suites

[Jerin Jacob]

On Sat, Sep 30, 2023 at 6:31 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Sep 28, 2023 at 5:14 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The eventdev library includes a selftest API which can be used by
> > drivers for testing. Add the relevant automated self-test commands
> > into meson test suites as appropriate.
> >
> > Bruce Richardson (2):
> >   event/sw: add self tests to fast tests
> >   event/*: add driver selftests to driver-tests suite
> >
> >  app/test/test_eventdev.c             | 10 +++++-----
> >  drivers/event/sw/sw_evdev_selftest.c |  2 +-
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
>
> On the principle, the series lgtm.
> Acked-by: David Marchand <david.marchand@redhat.com>

Changed second patch subject to  test/event: add driver selftests to
driver-tests suite

Series applied to dpdk-next-net-eventdev/for-main. Thanks


>
>
> --
> David Marchand
>