From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBFB3426A4; Mon, 2 Oct 2023 18:11:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9B8940294; Mon, 2 Oct 2023 18:11:01 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 026C24003C for ; Mon, 2 Oct 2023 18:11:00 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-565334377d0so13014081a12.2 for ; Mon, 02 Oct 2023 09:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696263059; x=1696867859; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FQsY0Z3uoJoA9Md+yimrMKlg8UZu6kBZqBa5M0b+dVc=; b=AbKmV/3XeUYzrnbHt3zgzqeWdXKk/VDLYEX7FVBMEYI4UrhI9e7/dSqzWcJs1gIVrk MJdQs8ubGBUs8L2xd4Ysz23vgLtHZPxELM4+FWuuYuiQjjP8GkNA137lMfkB7b2XL0fM W3DtO6/Dlsrv9XIxJM6AamaI1saGW+upHKHcfqU9D+YQyKNl/rK2xJFXCMSGL1lveNLz 5HbMFEM9eV7lOI9cph6pq6Mlm+qToBMtIvIfoFg016XhWez9yVdITBjm7PCq3sLRXqIX TDh0Y8YtXAQ84gDwZRkM73wIn0Lzc2RVtHK4UMNSRM2xDC4hdlzKNPqOvc7i3PQrZeYp kq2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696263059; x=1696867859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FQsY0Z3uoJoA9Md+yimrMKlg8UZu6kBZqBa5M0b+dVc=; b=wCKt6nYQRzpm1QCR5YPBSIBtRKhFYE8z/boiw7UnOFStCFb/b0xVe7PDjaIYi6byAB EHWuSBYqlYyKPXU9L5lbmEf+3LRCvTIQjCeGuole+KMdv3ocXn79rHFwCblbmbRgvSYC b1jklVyKlYoQCjg9HzJA8dqobhesn8c6/CeEfUAcTA12x3asJDo270PQRjwffA0qaaG0 84c00ySDP/DGpb58ekfT9GMZN9E8FXXPTPdE9kthbtHvLg9joiZu0YOeCh33tRR81o4k 9vtbB18xG2+Ih9Zh3NOFCM+eUWz+iKfMgKRP/CumKhQj9dM+WnHkLubyD+pjTr4jVVz8 m2lg== X-Gm-Message-State: AOJu0YyEitJwYsMzF3LJhnepsfWpc82DSfHhLbxdqoZ7g27X8Kll5jvy vzf9w2gXWdRr48Lr1GGAS2MSJCEAZqdtB2r2B1M= X-Google-Smtp-Source: AGHT+IGMUyrCD7wom4DDS7aayEeAy7HxMCrYLPzg+82jRPbrbKSXBJ/oka+7i1ZxPB6Or5a1stVbjQ== X-Received: by 2002:a05:6a20:3259:b0:15e:b281:a33c with SMTP id hm25-20020a056a20325900b0015eb281a33cmr10696270pzc.56.1696263058955; Mon, 02 Oct 2023 09:10:58 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id z14-20020aa785ce000000b006933ea28070sm8994582pfn.12.2023.10.02.09.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 09:10:58 -0700 (PDT) Date: Mon, 2 Oct 2023 09:10:57 -0700 From: Stephen Hemminger To: dev@dpdk.org Cc: Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Bruce Richardson Subject: Re: [PATCH v2 2/2] random: make rte_rand() thread safe for non-EAL threads Message-ID: <20231002091057.60a5da5c@hermes.local> In-Reply-To: <20230907152456.20570-3-stephen@networkplumber.org> References: <20230906155302.82749-1-stephen@networkplumber.org> <20230907152456.20570-1-stephen@networkplumber.org> <20230907152456.20570-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Sep 2023 08:24:56 -0700 Stephen Hemminger wrote: > Add missing locking so that if two non-EAL threads call rte_rand() > they will not corrupt the per-thread state. > > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR") > Signed-off-by: Stephen Hemminger Drop this patch in favor of fixing the documentation and leaving any thread issues up to application to sort out.