* [PATCH] eventdev: fix port link and unlink
@ 2023-10-03 15:01 pbhagavatula
2023-10-03 15:08 ` [PATCH v2] " pbhagavatula
0 siblings, 1 reply; 2+ messages in thread
From: pbhagavatula @ 2023-10-03 15:01 UTC (permalink / raw)
To: jerinj, bruce.richardson; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Port link and unlink rely on info get API to validate max
supported profiles, the default max profiles is initialized
in ``rte_dev_info_get`` API, use it instead of invoking
driver callback.
Fixes: 162aa4e1b479 ("eventdev: introduce link profiles")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
- Please Squash
lib/eventdev/rte_eventdev.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 5ee8bd665b..27b819d605 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -995,10 +995,10 @@ rte_event_port_profile_links_set(uint8_t dev_id, uint8_t port_id, const uint8_t
RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0);
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
@@ -1083,10 +1083,10 @@ rte_event_port_profile_unlink(uint8_t dev_id, uint8_t port_id, uint8_t queues[],
RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0);
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
@@ -1223,12 +1223,12 @@ rte_event_port_profile_links_get(uint8_t dev_id, uint8_t port_id, uint8_t queues
int i, count = 0;
RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
-
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
+
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2] eventdev: fix port link and unlink
2023-10-03 15:01 [PATCH] eventdev: fix port link and unlink pbhagavatula
@ 2023-10-03 15:08 ` pbhagavatula
0 siblings, 0 replies; 2+ messages in thread
From: pbhagavatula @ 2023-10-03 15:08 UTC (permalink / raw)
To: jerinj, bruce.richardson; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Port link and unlink rely on info get API to validate max
supported profiles, the default max profiles is initialized
in ``rte_dev_info_get`` API, use it instead of invoking
driver callback.
Fixes: 162aa4e1b479 ("eventdev: introduce link profiles")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/eventdev/rte_eventdev.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 5ee8bd665b..64fd5a70ae 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -995,10 +995,10 @@ rte_event_port_profile_links_set(uint8_t dev_id, uint8_t port_id, const uint8_t
RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0);
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
@@ -1083,10 +1083,10 @@ rte_event_port_profile_unlink(uint8_t dev_id, uint8_t port_id, uint8_t queues[],
RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0);
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
@@ -1219,16 +1219,16 @@ rte_event_port_profile_links_get(uint8_t dev_id, uint8_t port_id, uint8_t queues
{
struct rte_event_dev_info info;
struct rte_eventdev *dev;
+ int i, diag, count = 0;
uint16_t *links_map;
- int i, count = 0;
RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
-
dev = &rte_eventdevs[dev_id];
- if (*dev->dev_ops->dev_infos_get == NULL)
- return -ENOTSUP;
- (*dev->dev_ops->dev_infos_get)(dev, &info);
+ diag = rte_event_dev_info_get(dev_id, &info);
+ if (diag < 0)
+ return diag;
+
if (profile_id >= RTE_EVENT_MAX_PROFILES_PER_PORT ||
profile_id >= info.max_profiles_per_port) {
RTE_EDEV_LOG_ERR("Invalid profile_id=%" PRIu8, profile_id);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-03 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-03 15:01 [PATCH] eventdev: fix port link and unlink pbhagavatula
2023-10-03 15:08 ` [PATCH v2] " pbhagavatula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).