From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 064BB42681; Wed, 4 Oct 2023 00:26:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE08C40289; Wed, 4 Oct 2023 00:26:17 +0200 (CEST) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id A55F64027A for ; Wed, 4 Oct 2023 00:26:16 +0200 (CEST) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-57bbb38d5d4so797731eaf.2 for ; Tue, 03 Oct 2023 15:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696371976; x=1696976776; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aQ+c5Bmmh1MJb8wBHKNCIL0SZPi/35537IdnY5Q4fZo=; b=IqTfoHRT8A71FfjE85K5biReK8Cuok3b9cGHMENMw/LaLLOdSgqJbEmP5COEoiF9bQ yyYFXJnRwWH5UUVaHhlT+99nTD3pSqyQCEHv639Uqkitr+WYSYuxa5vn3NTA3nyZVLZj /ZiUWH2XDPZs8gzQUSJR6PHBUKRfQ8jH6GTiAQXuckiCkc9zoyf1IhUr2YCk/fWFCP0g kMKk7T+ozu2vM/UtnXGedjOv9TDD0wk/xG8WmYmHLT+3vOWn1FrZQSzFBAnOy3Vfz7eo gKIAC8vF2tWS7BXEnkGUEvBq998hNpjVDGqeQ2tvvqXShkPlxJ3j9BTIiVvir+KDzo7D JfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696371976; x=1696976776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aQ+c5Bmmh1MJb8wBHKNCIL0SZPi/35537IdnY5Q4fZo=; b=bBy1HJDsNqzlxNlHEkZ7h05zTcVQaMmPiWy+wwJTZNda/JAIjfKDs9Od+kuECrAFQm d5SozYcE5w5aVHHaX5lCrU6QuazkohpX5ZStePMrwHwoBt/jFqQe0giHJmrQea6rlhVl iy02qEYoz3AlIYo+o7QKD4Bj7nqTvU1w786skMCOEXvXjjTt8DnoNOYgUQamBdx5Ts6c cxQdXbpZfqyjaCGNVp0h54jtrrVyOhMfsKbLw7hYA2geqbJfvzQ3OVtGnVE8yLBzVXr/ zGimynaDwBllm4IgPpaj6DJMTarJk8z5hRd7izJZ5moq1V2q/Cn5uQt/rXOroKPg+2pP Rybw== X-Gm-Message-State: AOJu0Yx7JXRDAKOpVM9E/XQTXwDGZzKwciBdP1v880f1mmSNa0NrOmdt H/cYLD56gfWaH/xfunFjJnRqcw== X-Google-Smtp-Source: AGHT+IEOJHCEconH3TG7QWXLfyoDGMFwF7uCSgrDf7ICjg3ZsP29O3lG5bPvVmoey5zeUBEGaXKGZQ== X-Received: by 2002:a05:6358:591c:b0:143:7d73:6e63 with SMTP id g28-20020a056358591c00b001437d736e63mr874079rwf.2.1696371975688; Tue, 03 Oct 2023 15:26:15 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id nk17-20020a17090b195100b00276d039aecasm91442pjb.13.2023.10.03.15.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 15:26:15 -0700 (PDT) Date: Tue, 3 Oct 2023 15:26:12 -0700 From: Stephen Hemminger To: Tomasz Duszynski Cc: , Jakub Palider , , Subject: Re: [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines Message-ID: <20231003152612.6b0b3e20@hermes.local> In-Reply-To: <20231003204603.3377509-2-tduszynski@marvell.com> References: <20231003204603.3377509-1-tduszynski@marvell.com> <20231003204603.3377509-2-tduszynski@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 3 Oct 2023 22:46:03 +0200 Tomasz Duszynski wrote: > Improve log output by adding some newlines. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob Kollanukkaran > Tested-by: Jerin Jacob Kollanukkaran > --- > drivers/raw/cnxk_gpio/cnxk_gpio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c > index dcd646397e..6c4e4f5eae 100644 > --- a/drivers/raw/cnxk_gpio/cnxk_gpio.c > +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c > @@ -713,7 +713,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) > cnxk_gpio_format_name(name, sizeof(name)); > rawdev = rte_rawdev_pmd_allocate(name, sizeof(*gpiochip), rte_socket_id()); > if (!rawdev) { > - RTE_LOG(ERR, PMD, "failed to allocate %s rawdev", name); > + RTE_LOG(ERR, PMD, "failed to allocate %s rawdev\n", name); > return -ENOMEM; > } > > @@ -753,7 +753,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) > snprintf(buf, sizeof(buf), "%s/gpiochip%d/base", CNXK_GPIO_CLASS_PATH, gpiochip->num); > ret = cnxk_gpio_read_attr_int(buf, &gpiochip->base); > if (ret) { > - RTE_LOG(ERR, PMD, "failed to read %s", buf); > + RTE_LOG(ERR, PMD, "failed to read %s\n", buf); > goto out; > } > > @@ -761,7 +761,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) > snprintf(buf, sizeof(buf), "%s/gpiochip%d/ngpio", CNXK_GPIO_CLASS_PATH, gpiochip->num); > ret = cnxk_gpio_read_attr_int(buf, &gpiochip->num_gpios); > if (ret) { > - RTE_LOG(ERR, PMD, "failed to read %s", buf); > + RTE_LOG(ERR, PMD, "failed to read %s\n", buf); > goto out; > } > gpiochip->num_queues = gpiochip->num_gpios; > @@ -774,7 +774,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) > > gpiochip->gpios = rte_calloc(NULL, gpiochip->num_gpios, sizeof(struct cnxk_gpio *), 0); > if (!gpiochip->gpios) { > - RTE_LOG(ERR, PMD, "failed to allocate gpios memory"); > + RTE_LOG(ERR, PMD, "failed to allocate gpios memory\n"); > ret = -ENOMEM; > goto out; > } No driver should be using the PMD logtype. It should always be using a dynamically allocated log type.