From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1768A426BB; Thu, 5 Oct 2023 04:41:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 485A840698; Thu, 5 Oct 2023 04:40:48 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2127.outbound.protection.outlook.com [40.107.220.127]) by mails.dpdk.org (Postfix) with ESMTP id A8FD6402D8 for ; Thu, 5 Oct 2023 04:40:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AalsVTTqO1WVTDbbiiTvwSAPchAdmIyzlmWXQPzudsnJnCA+2KA8TXcpBW5FOpmO1yxHm/sDpPS5Vvb6fhAEbD8yj62rjbz7VFcx4fmYHUtgPgdPk5Wl4TCgcFB0GeUJnS1ic+aTPxrFFnWPm+bJOgMnTcTZsaDnU8NztT4guBuEuuHtupxuVYXKXnhSGEcQBWy1Atk29D7ejCNCqcCgqJUHg95Q0wDki96WHBmNazac3K5wF9UyxaLS3aT2YMt20BvnLaXB/tMNBgsgBVatPBFQ8iTiyCE9DoYZmXab3udVDGcyK7oNELFL8z/9Rp90iI28nVnm2a81+F4XErKoFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLv62KYSeTJdWLfvUn3SGfp8vzepnddlcNxrnblvZlA=; b=KVGN4j6/TuTYa89LOFWYjH4+ziCYWTFK+R20ct/NEdEsDMZ2SsMzpzOG+X5Qz3nBrUrfNxVDbk2KZ3n6lZAL0F30iPpqclwoRoxK+jvaaw9qsUR06/zzx3dNqYtUioXA+5N0FSGT31Xb7UFUBo2iKeGHnhp7ym06VEoUVnmBdLZHHWcMH8k5/B36/SV0qYmVOl0Ek3wl6WlX/18i2/LfDEkQrNQ631Pm3QSqS9Cpjp9AXyzUorcTFdTTdAExZ7pcwKYoAO7DELi/LpT1l4mFFo1t6GKP+bKGRCfykth5yu7u0bfhyA+aLn/i9Wf0I34JqttrvjhMZ8viI0JlXe0lAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RLv62KYSeTJdWLfvUn3SGfp8vzepnddlcNxrnblvZlA=; b=lhSvrl4VrqC0ZnNroFHfaxolYJ2RYXnvTfTNmUz0zrmkehdd0VxNAngq7HRrXV+D6sZfuYXnv8ztaoMZKrT6FcDwrc9dQnPQTOZvJUNuDbc34efmEaH6eqKQQZg6GJyPDalSefPmWw7H5RHfUbE+2PLujZQfKmKi50r7MvnE9Yo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB4780.namprd13.prod.outlook.com (2603:10b6:510:79::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Thu, 5 Oct 2023 02:40:41 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314%4]) with mapi id 15.20.6813.027; Thu, 5 Oct 2023 02:40:40 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , James Hershaw , Chaoyong He Subject: [PATCH 3/8] net/bonding: modify interface comment format Date: Thu, 5 Oct 2023 10:40:07 +0800 Message-Id: <20231005024012.1279810-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231005024012.1279810-1-chaoyong.he@corigine.com> References: <20231005024012.1279810-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: PH0PR07CA0064.namprd07.prod.outlook.com (2603:10b6:510:f::9) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB4780:EE_ X-MS-Office365-Filtering-Correlation-Id: 04b155c6-f4e9-4a06-ab5c-08dbc54c7688 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kK4DlVmL41crVV+JWSMeeCTIkqxnhxr2cYT75EKjMjDsAp+CvMSq2Ie943LEsjLcEUGUcxzFdo37SKYGoPDCBQSHpInYX3a89WD/30WGafy2AZ/2mYOcTfOsCsUx+dxtTcMsrhKSBY3gdfrBYUJUibfK3LE7ja9FHFz26xQ+tuKv9l1b4hGyL/8ZEeBESIQekDrSX0MzjDbNBfJPnDC1Qj9LYfOYcyWpRH1qaHZG9YIw9J/cYSD3Ruwhwnkgvqwqbrx/NLab3GNfPhdKo2azoXtKBxvEboprrntTDVtdhER8ZrkGy/5o01eYML5dOSPKdY5TFpl92lhUi8RzyLl8nHWnJNnqYpIMy5zlfD7xqTEF4AgrlqFZJB9O3QiQcZO0CvdjL1dVzha4Z02IlLI7iueC4y5R0FZi0DU7RMAGtqqPW28yY3Zeyt9WYeMPNquzHqSPH34M5dtz7a49QYpF2/OGW+Rncf270mJGlSujavWm0xvK/9tEtZUJ9FW5/kZD1gC9naeC0RHPKrJlqHetSXrBd3vxhOPnNVDRSYheIoqWFz5hztr4gPpW+cVRy50uwzVa8OFxgr7e2A67UQhIykD0t+I27kPDTF/v/2qiijH/1pGw8V8ooocB4HdrtvyMprutfZ4GochbzksOPoKTWfWhKu44A8VGTaxatMH9/YM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(346002)(136003)(39830400003)(396003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(8676002)(107886003)(2616005)(66476007)(4326008)(38100700002)(54906003)(316002)(478600001)(8936002)(66556008)(66946007)(38350700002)(30864003)(2906002)(6916009)(86362001)(41300700001)(6486002)(6506007)(5660300002)(52116002)(83380400001)(6512007)(1076003)(6666004)(26005)(44832011)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m9nAJT3Z21AdwaDUlwaDzuc/aL1uP7+YwPBuDIP4Dd8/JnyftLPoIHmKFWc1?= =?us-ascii?Q?pAAeHtccsWi1p7Gbnqb5drcoWtN0l0mV0F5Alx4pgF2yNvTXdAIIFB0wTvvf?= =?us-ascii?Q?K75ohzF/DXvV1jEWtdWA1saischvXB8EI0CL7A7Vkc64NIg0HNgG0E4shM0r?= =?us-ascii?Q?TLHpMTD8RXwV5S0w11jqZu0NAR7edlda/zTByQxxRiFNhXPspCp11Et6B/iG?= =?us-ascii?Q?/9OQ3nciI1iZEs7JKo5ZlMQmpKxmIPLeIq4WbVJPcHcLjq5XyPd7gJ2pdKMd?= =?us-ascii?Q?t/V/SqFMtK5P73GfcO5ZE34TMAnyrvHfXue5FvK80LJhMhtsKAerg7VJ4HE3?= =?us-ascii?Q?FtmckUiCoR5fxvqmMIPYYwtTRj3oD2mgy5noHc0oaVdWmdGGw6wIQhTYFDtj?= =?us-ascii?Q?94xAJyfURa8OPjujZVS2EfOY7t7DcV/FrdOIzzcWCcbriIBDr7nEeYuLudTm?= =?us-ascii?Q?NSwITcJ8rykkQXtuKIJrc4BympBodT/D47R940HWAmaZKTVv7rqD5tKc8/NY?= =?us-ascii?Q?LjFqubzh60ehhUuF4cb8WYDagjTREq+eVNRZ6Z9psB+d3CG2sVhO9qW+wlS4?= =?us-ascii?Q?f/RS2m/9AtAcD7Qe2cNBRsT6SW7vIAuWBEEM9IxjG9OqIrhQj5NZpLnZNKYl?= =?us-ascii?Q?UBh/uaywyxqTxQd6B5k0ZXDXZDwsIx/6NaMxLojDqhx6B3SXF0nZZD2l9p9Y?= =?us-ascii?Q?xOGwySD+79y/GfJ6PzWzDgV2TN6T+nGRHQP8h2TDEiVkTuSqcZFvM+nIZ5YT?= =?us-ascii?Q?cJB2firmzTRCADF/zTLcT1Ui5vaenrRL3+qfTpuX53RV7EyPcL2xGUThM74q?= =?us-ascii?Q?rkxsN6VJAbeOAJlGJyhjNRZYgidQyRjX09TxEojeG5fl2MEQROd15CMhzVTR?= =?us-ascii?Q?sdLs6ZrHTGSLLx48nfJRI31+zx1TvZLTPIwANILYwOj7DUTAqKtwu0Kgf8Hj?= =?us-ascii?Q?duyo6etSBSgnZdJut2amAnQ9w5kR80VyKOA+9vGQbyTuhXxIa0iw7GQmxXJb?= =?us-ascii?Q?oDWV8/P0TMCaHpbt3Mk8Sdpm0RFso6pD/7GnCz3P9yrwb1o6z+QYtqe0+xp3?= =?us-ascii?Q?N67F9fQ7kfimEs5vKvubXl59q0WO8npxSTUWSPKCA5lhDRPlGIVOFjfidJsF?= =?us-ascii?Q?TlGpwrCRU/brEn4iTiid2V3xGuxMAAiN8BFNZImk2cnoKJsGPUytdZ/Wj54/?= =?us-ascii?Q?KLWpjvNYNtkFVXGL6VKg/wX99j39VuAfsrf+GVjLpmApORGRQzwhOmSslUUF?= =?us-ascii?Q?/ue+oXvqgKzX+kescwNEVlhUHetXAe386uQriY4LqlKQ/knyhZbsySgrrqNQ?= =?us-ascii?Q?RgsdZlt6WqJGAMLn5QPvqe58Tpn2b1BLMJ/MqcBzCSikgNfNZWcYQoOJcszG?= =?us-ascii?Q?hTOmZzwkUo7+ku41jUjvn0cLhVKDS4NtezhP8fMVn8Sxfa/aMewQr+RP3Jtn?= =?us-ascii?Q?FiMemjyOMVwW5EZkob0fq2O+trh0WMMrpfH5Q25KVU/5dK7d5Hz4WfNp7/02?= =?us-ascii?Q?/aWox9jkno80yEtcACqraS9zUv3EpTOMIs6Zfa2eRTxNHuByEBUHa3pB9RyL?= =?us-ascii?Q?+tKiDX2TjcNcVa58S3POgO+VEhgk1uoMkbGX9K+zpkBAUu6UUxFfsMDpfS0E?= =?us-ascii?Q?xA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04b155c6-f4e9-4a06-ab5c-08dbc54c7688 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 02:40:40.5708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lMBqo8YLSmRLruPXkgl00QVgp4u/hk7bZVDQbHsjzwB5u/+/y3oCiUezcBnlo6wjZGNRWiKio1nZcVO1GrocEdWzXI+kGG7NTSkext/WPCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4780 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu Most of the previous interface comment format does not meet the current standards and were not uniform. Modify them to meet current standards. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --- drivers/net/bonding/eth_bond_8023ad_private.h | 52 +++--- drivers/net/bonding/rte_eth_bond.h | 150 +++++++++++------- drivers/net/bonding/rte_eth_bond_8023ad.h | 76 ++++++--- drivers/net/bonding/rte_eth_bond_alb.h | 34 ++-- 4 files changed, 199 insertions(+), 113 deletions(-) diff --git a/drivers/net/bonding/eth_bond_8023ad_private.h b/drivers/net/bonding/eth_bond_8023ad_private.h index ab7d15f81a..29ee8700c3 100644 --- a/drivers/net/bonding/eth_bond_8023ad_private.h +++ b/drivers/net/bonding/eth_bond_8023ad_private.h @@ -196,10 +196,13 @@ struct bond_dev_private; * * Set mode 4 configuration of bonding interface. * - * @pre Bonding interface must be stopped. + * @pre + * Bonding interface must be stopped. * - * @param dev Bonding interface - * @param conf new configuration. If NULL set default configuration. + * @param dev + * Bonding interface + * @param conf + * new configuration. If NULL set default configuration. */ void bond_mode_8023ad_setup(struct rte_eth_dev *dev, @@ -210,9 +213,11 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev, * * Enables 802.1AX mode and all active members on bonding interface. * - * @param dev Bonding interface + * @param dev + * Bonding interface + * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int bond_mode_8023ad_enable(struct rte_eth_dev *dev); @@ -222,7 +227,8 @@ bond_mode_8023ad_enable(struct rte_eth_dev *dev); * * Disables 802.1AX mode of the bonding interface and members. * - * @param dev Bonding interface + * @param dev + * Bonding interface * @return * 0 on success, negative value otherwise. */ @@ -232,7 +238,8 @@ int bond_mode_8023ad_disable(struct rte_eth_dev *dev); * @internal * * Starts 802.3AX state machines management logic. - * @param dev Bonding interface + * @param dev + * Bonding interface * @return * 0 if machines was started, 1 if machines was already running, * negative value otherwise. @@ -244,7 +251,8 @@ bond_mode_8023ad_start(struct rte_eth_dev *dev); * @internal * * Stops 802.3AX state machines management logic. - * @param dev Bonding interface + * @param dev + * Bonding interface * @return * 0 if this call stopped state machines, -ENOENT if alarm was not set. */ @@ -255,9 +263,12 @@ bond_mode_8023ad_stop(struct rte_eth_dev *dev); * @internal * * Passes given slow packet to state machines management logic. - * @param internals Bonding device private data. - * @param member_id Member port id. - * @param slot_pkt Slow packet. + * @param internals + * Bonding device private data. + * @param member_id + * Member port id. + * @param slot_pkt + * Slow packet. */ void bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals, @@ -268,11 +279,13 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals, * * Appends given member used member * - * @param dev Bonding interface. - * @param port_id Member port ID to be added + * @param dev + * Bonding interface. + * @param port_id + * Member port ID to be added * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ void bond_mode_8023ad_activate_member(struct rte_eth_dev *dev, uint16_t port_id); @@ -282,18 +295,21 @@ bond_mode_8023ad_activate_member(struct rte_eth_dev *dev, uint16_t port_id); * * Denitializes and removes given member from 802.1AX mode. * - * @param dev Bonding interface. - * @param member_num Position of member in active_members array + * @param dev + * Bonding interface. + * @param member_num + * Position of member in active_members array * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int bond_mode_8023ad_deactivate_member(struct rte_eth_dev *dev, uint16_t member_pos); /** * Updates state when MAC was changed on bonding device or one of its members. - * @param bond_dev Bonding device + * @param bond_dev + * Bonding device */ void bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev); diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h index 6be5e46deb..28aa341d2f 100644 --- a/drivers/net/bonding/rte_eth_bond.h +++ b/drivers/net/bonding/rte_eth_bond.h @@ -95,12 +95,15 @@ extern "C" { /** * Create a bonding rte_eth_dev device * - * @param name Name of new link bonding device. - * @param mode Mode to initialize bonding device in. - * @param socket_id Socket Id on which to allocate eth_dev resources. + * @param name + * Name of new link bonding device. + * @param mode + * Mode to initialize bonding device in. + * @param socket_id + * Socket Id on which to allocate eth_dev resources. * * @return - * Port Id of created rte_eth_dev on success, negative value otherwise + * Port Id of created rte_eth_dev on success, negative value otherwise */ int rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id); @@ -108,10 +111,11 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id); /** * Free a bonding rte_eth_dev device * - * @param name Name of the link bonding device. + * @param name + * Name of the link bonding device. * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ int rte_eth_bond_free(const char *name); @@ -119,11 +123,13 @@ rte_eth_bond_free(const char *name); /** * Add a rte_eth_dev device as a member to the bonding device * - * @param bonding_port_id Port ID of bonding device. - * @param member_port_id Port ID of member device. + * @param bonding_port_id + * Port ID of bonding device. + * @param member_port_id + * Port ID of member device. * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ __rte_experimental int @@ -132,11 +138,13 @@ rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id); /** * Remove a member rte_eth_dev device from the bonding device * - * @param bonding_port_id Port ID of bonding device. - * @param member_port_id Port ID of member device. + * @param bonding_port_id + * Port ID of bonding device. + * @param member_port_id + * Port ID of member device. * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ __rte_experimental int @@ -145,11 +153,13 @@ rte_eth_bond_member_remove(uint16_t bonding_port_id, uint16_t member_port_id); /** * Set link bonding mode of bonding device * - * @param bonding_port_id Port ID of bonding device. - * @param mode Bonding mode to set + * @param bonding_port_id + * Port ID of bonding device. + * @param mode + * Bonding mode to set * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ int rte_eth_bond_mode_set(uint16_t bonding_port_id, uint8_t mode); @@ -157,10 +167,11 @@ rte_eth_bond_mode_set(uint16_t bonding_port_id, uint8_t mode); /** * Get link bonding mode of bonding device * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * link bonding mode on success, negative value otherwise + * link bonding mode on success, negative value otherwise */ int rte_eth_bond_mode_get(uint16_t bonding_port_id); @@ -168,11 +179,13 @@ rte_eth_bond_mode_get(uint16_t bonding_port_id); /** * Set member rte_eth_dev as primary member of bonding device * - * @param bonding_port_id Port ID of bonding device. - * @param member_port_id Port ID of member device. + * @param bonding_port_id + * Port ID of bonding device. + * @param member_port_id + * Port ID of member device. * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ int rte_eth_bond_primary_set(uint16_t bonding_port_id, uint16_t member_port_id); @@ -180,10 +193,11 @@ rte_eth_bond_primary_set(uint16_t bonding_port_id, uint16_t member_port_id); /** * Get primary member of bonding device * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * Port Id of primary member on success, -1 on failure + * Port Id of primary member on success, -1 on failure */ int rte_eth_bond_primary_get(uint16_t bonding_port_id); @@ -191,13 +205,16 @@ rte_eth_bond_primary_get(uint16_t bonding_port_id); /** * Populate an array with list of the members port id's of the bonding device * - * @param bonding_port_id Port ID of bonding eth_dev to interrogate - * @param members Array to be populated with the current active members - * @param len Length of members array + * @param bonding_port_id + * Port ID of bonding eth_dev to interrogate + * @param members + * Array to be populated with the current active members + * @param len + * Length of members array * * @return - * Number of members associated with bonding device on success, - * negative value otherwise + * Number of members associated with bonding device on success, + * negative value otherwise */ __rte_experimental int @@ -208,13 +225,16 @@ rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[], * Populate an array with list of the active members port id's of the bonding * device. * - * @param bonding_port_id Port ID of bonding eth_dev to interrogate - * @param members Array to be populated with the current active members - * @param len Length of members array + * @param bonding_port_id + * Port ID of bonding eth_dev to interrogate + * @param members + * Array to be populated with the current active members + * @param len + * Length of members array * * @return - * Number of active members associated with bonding device on success, - * negative value otherwise + * Number of active members associated with bonding device on success, + * negative value otherwise */ __rte_experimental int @@ -224,12 +244,13 @@ rte_eth_bond_active_members_get(uint16_t bonding_port_id, uint16_t members[], /** * Set explicit MAC address to use on bonding device and it's members. * - * @param bonding_port_id Port ID of bonding device. - * @param mac_addr MAC Address to use on bonding device overriding - * members MAC addresses + * @param bonding_port_id + * Port ID of bonding device. + * @param mac_addr + * MAC Address to use on bonding device overriding members MAC addresses * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ int rte_eth_bond_mac_address_set(uint16_t bonding_port_id, @@ -239,10 +260,11 @@ rte_eth_bond_mac_address_set(uint16_t bonding_port_id, * Reset bonding device to use MAC from primary member on bonding device and it's * members. * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * 0 on success, negative value otherwise + * 0 on success, negative value otherwise */ int rte_eth_bond_mac_address_reset(uint16_t bonding_port_id); @@ -252,11 +274,13 @@ rte_eth_bond_mac_address_reset(uint16_t bonding_port_id); * balance mode, this parameter is otherwise ignored in other modes of * operation. * - * @param bonding_port_id Port ID of bonding device. - * @param policy Balance mode transmission policy. + * @param bonding_port_id + * Port ID of bonding device. + * @param policy + * Balance mode transmission policy. * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy); @@ -264,10 +288,11 @@ rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy); /** * Get the transmit policy set on bonding device for balance mode operation * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * Balance transmit policy on success, negative value otherwise. + * Balance transmit policy on success, negative value otherwise. */ int rte_eth_bond_xmit_policy_get(uint16_t bonding_port_id); @@ -276,11 +301,13 @@ rte_eth_bond_xmit_policy_get(uint16_t bonding_port_id); * Set the link monitoring frequency (in ms) for monitoring the link status of * member devices * - * @param bonding_port_id Port ID of bonding device. - * @param internal_ms Monitoring interval in milliseconds + * @param bonding_port_id + * Port ID of bonding device. + * @param internal_ms + * Monitoring interval in milliseconds * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int @@ -290,10 +317,11 @@ rte_eth_bond_link_monitoring_set(uint16_t bonding_port_id, uint32_t internal_ms) * Get the current link monitoring frequency (in ms) for monitoring of the link * status of member devices * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * Monitoring interval on success, negative value otherwise. + * Monitoring interval on success, negative value otherwise. */ int rte_eth_bond_link_monitoring_get(uint16_t bonding_port_id); @@ -303,11 +331,13 @@ rte_eth_bond_link_monitoring_get(uint16_t bonding_port_id); * Set the period in milliseconds for delaying the disabling of a bonding link * when the link down status has been detected * - * @param bonding_port_id Port ID of bonding device. - * @param delay_ms Delay period in milliseconds. + * @param bonding_port_id + * Port ID of bonding device. + * @param delay_ms + * Delay period in milliseconds. * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int rte_eth_bond_link_down_prop_delay_set(uint16_t bonding_port_id, @@ -317,10 +347,11 @@ rte_eth_bond_link_down_prop_delay_set(uint16_t bonding_port_id, * Get the period in milliseconds set for delaying the disabling of a bonding * link when the link down status has been detected * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * Delay period on success, negative value otherwise. + * Delay period on success, negative value otherwise. */ int rte_eth_bond_link_down_prop_delay_get(uint16_t bonding_port_id); @@ -329,11 +360,13 @@ rte_eth_bond_link_down_prop_delay_get(uint16_t bonding_port_id); * Set the period in milliseconds for delaying the enabling of a bonding link * when the link up status has been detected * - * @param bonding_port_id Port ID of bonding device. - * @param delay_ms Delay period in milliseconds. + * @param bonding_port_id + * Port ID of bonding device. + * @param delay_ms + * Delay period in milliseconds. * * @return - * 0 on success, negative value otherwise. + * 0 on success, negative value otherwise. */ int rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id, @@ -343,10 +376,11 @@ rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id, * Get the period in milliseconds set for delaying the enabling of a bonding * link when the link up status has been detected * - * @param bonding_port_id Port ID of bonding device. + * @param bonding_port_id + * Port ID of bonding device. * * @return - * Delay period on success, negative value otherwise. + * Delay period on success, negative value otherwise. */ int rte_eth_bond_link_up_prop_delay_get(uint16_t bonding_port_id); diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h index 4c280c7565..4936d7fc0c 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.h +++ b/drivers/net/bonding/rte_eth_bond_8023ad.h @@ -155,8 +155,10 @@ struct rte_eth_bond_8023ad_member_info { * * Function returns current configuration of 802.3AX mode. * - * @param port_id Bonding device id - * @param conf Pointer to timeout structure. + * @param port_id + * Bonding device id + * @param conf + * Pointer to timeout structure. * * @return * 0 - if ok @@ -171,8 +173,10 @@ rte_eth_bond_8023ad_conf_get(uint16_t port_id, * * Function set new configuration of 802.3AX mode. * - * @param port_id Bonding device id - * @param conf Configuration, if NULL set default configuration. + * @param port_id + * Bonding device id + * @param conf + * Configuration, if NULL set default configuration. * @return * 0 - if ok * -EINVAL if configuration is invalid. @@ -186,8 +190,10 @@ rte_eth_bond_8023ad_setup(uint16_t port_id, * * Function returns current state of given member device. * - * @param member_id Port id of valid member. - * @param conf buffer for configuration + * @param member_id + * Port id of valid member. + * @param conf + * buffer for configuration * @return * 0 - if ok * -EINVAL if conf is NULL or member id is invalid (not a member of given @@ -201,9 +207,12 @@ rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id, /** * Configure a member port to start collecting. * - * @param port_id Bonding device id - * @param member_id Port id of valid member. - * @param enabled Non-zero when collection enabled. + * @param port_id + * Bonding device id + * @param member_id + * Port id of valid member. + * @param enabled + * Non-zero when collection enabled. * @return * 0 - if ok * -EINVAL if member is not valid. @@ -215,8 +224,10 @@ rte_eth_bond_8023ad_ext_collect(uint16_t port_id, uint16_t member_id, /** * Get COLLECTING flag from member port actor state. * - * @param port_id Bonding device id - * @param member_id Port id of valid member. + * @param port_id + * Bonding device id + * @param member_id + * Port id of valid member. * @return * 0 - if not set * 1 - if set @@ -228,9 +239,12 @@ rte_eth_bond_8023ad_ext_collect_get(uint16_t port_id, uint16_t member_id); /** * Configure a member port to start distributing. * - * @param port_id Bonding device id - * @param member_id Port id of valid member. - * @param enabled Non-zero when distribution enabled. + * @param port_id + * Bonding device id + * @param member_id + * Port id of valid member. + * @param enabled + * Non-zero when distribution enabled. * @return * 0 - if ok * -EINVAL if member is not valid. @@ -242,8 +256,10 @@ rte_eth_bond_8023ad_ext_distrib(uint16_t port_id, uint16_t member_id, /** * Get DISTRIBUTING flag from member port actor state. * - * @param port_id Bonding device id - * @param member_id Port id of valid member. + * @param port_id + * Bonding device id + * @param member_id + * Port id of valid member. * @return * 0 - if not set * 1 - if set @@ -256,9 +272,12 @@ rte_eth_bond_8023ad_ext_distrib_get(uint16_t port_id, uint16_t member_id); * LACPDU transmit path for external 802.3ad state machine. Caller retains * ownership of the packet on failure. * - * @param port_id Bonding device id - * @param member_id Port ID of valid member device. - * @param lacp_pkt mbuf containing LACPDU. + * @param port_id + * Bonding device id + * @param member_id + * Port ID of valid member device. + * @param lacp_pkt + * mbuf containing LACPDU. * * @return * 0 on success, negative value otherwise. @@ -284,7 +303,8 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t member_id, * * Bonding port must be stopped to change this configuration. * - * @param port_id Bonding device id + * @param port_id + * Bonding device id * * @return * 0 on success, negative value otherwise. @@ -299,9 +319,11 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port_id); * * Bonding port must be stopped to change this configuration. * - * @see rte_eth_bond_8023ad_slow_pkt_hw_filter_enable + * @see + * rte_eth_bond_8023ad_slow_pkt_hw_filter_enable * - * @param port_id Bonding device id + * @param port_id + * Bonding device id * @return * 0 on success, negative value otherwise. * @@ -309,9 +331,11 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port_id); int rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port_id); -/* +/** * Get aggregator mode for 8023ad - * @param port_id Bonding device id + * + * @param port_id + * Bonding device id * * @return * aggregator mode on success, negative value otherwise @@ -321,7 +345,9 @@ rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id); /** * Set aggregator mode for 8023ad - * @param port_id Bonding device id + * @param port_id + * Bonding device id + * * @return * 0 on success, negative value otherwise */ diff --git a/drivers/net/bonding/rte_eth_bond_alb.h b/drivers/net/bonding/rte_eth_bond_alb.h index f51c355d36..3cf0d87750 100644 --- a/drivers/net/bonding/rte_eth_bond_alb.h +++ b/drivers/net/bonding/rte_eth_bond_alb.h @@ -63,9 +63,12 @@ bond_mode_alb_enable(struct rte_eth_dev *bond_dev); * forwarded to application without changes. If it is ARP reply, client table * is updated. * - * @param eth_h ETH header of received packet. - * @param offset Vlan header offset. - * @param internals Bonding data. + * @param eth_h + * ETH header of received packet. + * @param offset + * Vlan header offset. + * @param internals + * Bonding data. */ void bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset, @@ -77,12 +80,15 @@ bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset, * If it is ARP Reply, it is send on member stored in client table for that * connection. On Reply function also updates data in client table. * - * @param eth_h ETH header of transmitted packet. - * @param offset Vlan header offset. - * @param internals Bonding data. + * @param eth_h + * ETH header of transmitted packet. + * @param offset + * Vlan header offset. + * @param internals + * Bonding data. * * @return - * Index of member on which packet should be sent. + * Index of member on which packet should be sent. */ uint16_t bond_mode_alb_arp_xmit(struct rte_ether_hdr *eth_h, uint16_t offset, @@ -91,12 +97,15 @@ bond_mode_alb_arp_xmit(struct rte_ether_hdr *eth_h, uint16_t offset, /** * Function fills packet with ARP data from client_info. * - * @param client_info Data of client to which packet is sent. - * @param pkt Pointer to packet which is sent. - * @param internals Bonding data. + * @param client_info + * Data of client to which packet is sent. + * @param pkt + * Pointer to packet which is sent. + * @param internals + * Bonding data. * * @return - * Index of member on which packet should be sent. + * Index of member on which packet should be sent. */ uint16_t bond_mode_alb_arp_upd(struct client_data *client_info, @@ -105,7 +114,8 @@ bond_mode_alb_arp_upd(struct client_data *client_info, /** * Function updates member indexes of active connections. * - * @param bond_dev Pointer to bonding device struct. + * @param bond_dev + * Pointer to bonding device struct. */ void bond_mode_alb_client_list_upd(struct rte_eth_dev *bond_dev); -- 2.39.1